See https://github.com/llvm/llvm-project/pull/156803#issuecomment-3275911510 for full context. Summary: * In https://github.com/llvm/llvm-project/pull/156803, we see a builtbot failure for `TestDAP_server.py` on Debian. Note that macOS and other Linux distributions (like CentOS, or whatever Linux the [required buildbot](https://github.com/llvm/llvm-project/actions/runs/17594257911/job/49982560193#logs) uses) seem to pass the tests. * In the 3 newly added tests, the most complex test case passed, while the other easier ones failed. ``` PASS: LLDB (/home/worker/2.0.1/lldb-x86_64-debian/build/bin/clang-x86_64) :: test_connection_timeout_multiple_sessions (TestDAP_server.TestDAP_server.test_connection_timeout_multiple_sessions) FAIL: LLDB (/home/worker/2.0.1/lldb-x86_64-debian/build/bin/clang-x86_64) :: test_connection_timeout_long_debug_session (TestDAP_server.TestDAP_server.test_connection_timeout_long_debug_session) FAIL: LLDB (/home/worker/2.0.1/lldb-x86_64-debian/build/bin/clang-x86_64) :: test_connection_timeout_at_server_start (TestDAP_server.TestDAP_server.test_connection_timeout_at_server_start) ``` * The error is that `process.wait(timeout)` timed out during the teardown of the tests. * The above suggests that maybe the root cause is that the timeout is set too strictly (and that maybe the server termination on Debian is slower than the other Linux distribution for some reason). * This patch loosens that timeout from 2s to 5s. Let's see if this works. * FWIW, I cannot verify the root cause, because I don't have a Debian machine.
164 lines
5.5 KiB
Python
164 lines
5.5 KiB
Python
"""
|
|
Test lldb-dap server integration.
|
|
"""
|
|
|
|
import os
|
|
import signal
|
|
import tempfile
|
|
import time
|
|
|
|
import dap_server
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
import lldbdap_testcase
|
|
|
|
|
|
class TestDAP_server(lldbdap_testcase.DAPTestCaseBase):
|
|
def start_server(
|
|
self, connection, connection_timeout=None, wait_seconds_for_termination=None
|
|
):
|
|
log_file_path = self.getBuildArtifact("dap.txt")
|
|
(process, connection) = dap_server.DebugAdapterServer.launch(
|
|
executable=self.lldbDAPExec,
|
|
connection=connection,
|
|
connection_timeout=connection_timeout,
|
|
log_file=log_file_path,
|
|
)
|
|
|
|
def cleanup():
|
|
if wait_seconds_for_termination is not None:
|
|
process.wait(wait_seconds_for_termination)
|
|
else:
|
|
process.terminate()
|
|
|
|
self.addTearDownHook(cleanup)
|
|
|
|
return (process, connection)
|
|
|
|
def run_debug_session(self, connection, name, sleep_seconds_in_middle=None):
|
|
self.dap_server = dap_server.DebugAdapterServer(
|
|
connection=connection,
|
|
)
|
|
program = self.getBuildArtifact("a.out")
|
|
source = "main.c"
|
|
breakpoint_line = line_number(source, "// breakpoint")
|
|
|
|
self.launch(
|
|
program,
|
|
args=[name],
|
|
disconnectAutomatically=False,
|
|
)
|
|
if sleep_seconds_in_middle is not None:
|
|
time.sleep(sleep_seconds_in_middle)
|
|
self.set_source_breakpoints(source, [breakpoint_line])
|
|
self.continue_to_next_stop()
|
|
self.continue_to_exit()
|
|
output = self.get_stdout()
|
|
self.assertEqual(output, f"Hello {name}!\r\n")
|
|
self.dap_server.request_disconnect()
|
|
|
|
@skipIfWindows
|
|
def test_server_port(self):
|
|
"""
|
|
Test launching a binary with a lldb-dap in server mode on a specific port.
|
|
"""
|
|
self.build()
|
|
(_, connection) = self.start_server(connection="listen://localhost:0")
|
|
self.run_debug_session(connection, "Alice")
|
|
self.run_debug_session(connection, "Bob")
|
|
|
|
@skipIfWindows
|
|
def test_server_unix_socket(self):
|
|
"""
|
|
Test launching a binary with a lldb-dap in server mode on a unix socket.
|
|
"""
|
|
dir = tempfile.gettempdir()
|
|
name = dir + "/dap-connection-" + str(os.getpid())
|
|
|
|
def cleanup():
|
|
os.unlink(name)
|
|
|
|
self.addTearDownHook(cleanup)
|
|
|
|
self.build()
|
|
(_, connection) = self.start_server(connection="accept://" + name)
|
|
self.run_debug_session(connection, "Alice")
|
|
self.run_debug_session(connection, "Bob")
|
|
|
|
@skipIfWindows
|
|
def test_server_interrupt(self):
|
|
"""
|
|
Test launching a binary with lldb-dap in server mode and shutting down the server while the debug session is still active.
|
|
"""
|
|
self.build()
|
|
(process, connection) = self.start_server(connection="listen://localhost:0")
|
|
self.dap_server = dap_server.DebugAdapterServer(
|
|
connection=connection,
|
|
)
|
|
program = self.getBuildArtifact("a.out")
|
|
source = "main.c"
|
|
breakpoint_line = line_number(source, "// breakpoint")
|
|
|
|
self.launch(
|
|
program,
|
|
args=["Alice"],
|
|
disconnectAutomatically=False,
|
|
)
|
|
self.set_source_breakpoints(source, [breakpoint_line])
|
|
self.continue_to_next_stop()
|
|
|
|
# Interrupt the server which should disconnect all clients.
|
|
process.send_signal(signal.SIGINT)
|
|
|
|
# Wait for both events since they can happen in any order.
|
|
self.dap_server.wait_for_event(["terminated", "exited"])
|
|
self.dap_server.wait_for_event(["terminated", "exited"])
|
|
self.assertIsNotNone(
|
|
self.dap_server.exit_status,
|
|
"Process exited before interrupting lldb-dap server",
|
|
)
|
|
|
|
@skipIfWindows
|
|
def test_connection_timeout_at_server_start(self):
|
|
"""
|
|
Test launching lldb-dap in server mode with connection timeout and waiting for it to terminate automatically when no client connects.
|
|
"""
|
|
self.build()
|
|
self.start_server(
|
|
connection="listen://localhost:0",
|
|
connection_timeout=1,
|
|
wait_seconds_for_termination=5,
|
|
)
|
|
|
|
@skipIfWindows
|
|
def test_connection_timeout_long_debug_session(self):
|
|
"""
|
|
Test launching lldb-dap in server mode with connection timeout and terminating the server after the a long debug session.
|
|
"""
|
|
self.build()
|
|
(_, connection) = self.start_server(
|
|
connection="listen://localhost:0",
|
|
connection_timeout=1,
|
|
wait_seconds_for_termination=5,
|
|
)
|
|
# The connection timeout should not cut off the debug session
|
|
self.run_debug_session(connection, "Alice", 1.5)
|
|
|
|
@skipIfWindows
|
|
def test_connection_timeout_multiple_sessions(self):
|
|
"""
|
|
Test launching lldb-dap in server mode with connection timeout and terminating the server after the last debug session.
|
|
"""
|
|
self.build()
|
|
(_, connection) = self.start_server(
|
|
connection="listen://localhost:0",
|
|
connection_timeout=1,
|
|
wait_seconds_for_termination=5,
|
|
)
|
|
time.sleep(0.5)
|
|
# Should be able to connect to the server.
|
|
self.run_debug_session(connection, "Alice")
|
|
time.sleep(0.5)
|
|
# Should be able to connect to the server, because it's still within the connection timeout.
|
|
self.run_debug_session(connection, "Bob")
|