The analyzer trims unnecessary nodes from the exploded graph before reporting path diagnostics. However, in some cases it can trim all nodes (including the error node), leading to an assertion failure (see https://llvm.org/bugs/show_bug.cgi?id=24184). This commit addresses the issue by adding two new APIs to CheckerContext to explicitly create error nodes. Unless the client provides a custom tag, these APIs tag the node with the checker's tag -- preventing it from being trimmed. The generateErrorNode() method creates a sink error node, while generateNonFatalErrorNode() creates an error node for a path that should continue being explored. The intent is that one of these two methods should be used whenever a checker creates an error node. This commit updates the checkers to use these APIs. These APIs (unlike addTransition() and generateSink()) do not take an explicit Pred node. This is because there are not any error nodes in the checkers that were created with an explicit different than the default (the CheckerContext's Pred node). It also changes generateSink() to require state and pred nodes (previously these were optional) to reduce confusion. Additionally, there were several cases where checkers did check whether a generated node could be null; we now explicitly check for null in these places. This commit also includes a test case written by Ying Yi as part of http://reviews.llvm.org/D12163 (that patch originally addressed this issue but was reverted because it introduced false positive regressions). Differential Revision: http://reviews.llvm.org/D12780 llvm-svn: 247859
148 lines
4.4 KiB
C++
148 lines
4.4 KiB
C++
//=== CastSizeChecker.cpp ---------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// CastSizeChecker checks when casting a malloc'ed symbolic region to type T,
|
|
// whether the size of the symbolic region is a multiple of the size of T.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
#include "ClangSACheckers.h"
|
|
#include "clang/AST/CharUnits.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
class CastSizeChecker : public Checker< check::PreStmt<CastExpr> > {
|
|
mutable std::unique_ptr<BuiltinBug> BT;
|
|
|
|
public:
|
|
void checkPreStmt(const CastExpr *CE, CheckerContext &C) const;
|
|
};
|
|
}
|
|
|
|
/// Check if we are casting to a struct with a flexible array at the end.
|
|
/// \code
|
|
/// struct foo {
|
|
/// size_t len;
|
|
/// struct bar data[];
|
|
/// };
|
|
/// \endcode
|
|
/// or
|
|
/// \code
|
|
/// struct foo {
|
|
/// size_t len;
|
|
/// struct bar data[0];
|
|
/// }
|
|
/// \endcode
|
|
/// In these cases it is also valid to allocate size of struct foo + a multiple
|
|
/// of struct bar.
|
|
static bool evenFlexibleArraySize(ASTContext &Ctx, CharUnits RegionSize,
|
|
CharUnits TypeSize, QualType ToPointeeTy) {
|
|
const RecordType *RT = ToPointeeTy->getAs<RecordType>();
|
|
if (!RT)
|
|
return false;
|
|
|
|
const RecordDecl *RD = RT->getDecl();
|
|
RecordDecl::field_iterator Iter(RD->field_begin());
|
|
RecordDecl::field_iterator End(RD->field_end());
|
|
const FieldDecl *Last = nullptr;
|
|
for (; Iter != End; ++Iter)
|
|
Last = *Iter;
|
|
assert(Last && "empty structs should already be handled");
|
|
|
|
const Type *ElemType = Last->getType()->getArrayElementTypeNoTypeQual();
|
|
CharUnits FlexSize;
|
|
if (const ConstantArrayType *ArrayTy =
|
|
Ctx.getAsConstantArrayType(Last->getType())) {
|
|
FlexSize = Ctx.getTypeSizeInChars(ElemType);
|
|
if (ArrayTy->getSize() == 1 && TypeSize > FlexSize)
|
|
TypeSize -= FlexSize;
|
|
else if (ArrayTy->getSize() != 0)
|
|
return false;
|
|
} else if (RD->hasFlexibleArrayMember()) {
|
|
FlexSize = Ctx.getTypeSizeInChars(ElemType);
|
|
} else {
|
|
return false;
|
|
}
|
|
|
|
if (FlexSize.isZero())
|
|
return false;
|
|
|
|
CharUnits Left = RegionSize - TypeSize;
|
|
if (Left.isNegative())
|
|
return false;
|
|
|
|
if (Left % FlexSize == 0)
|
|
return true;
|
|
|
|
return false;
|
|
}
|
|
|
|
void CastSizeChecker::checkPreStmt(const CastExpr *CE,CheckerContext &C) const {
|
|
const Expr *E = CE->getSubExpr();
|
|
ASTContext &Ctx = C.getASTContext();
|
|
QualType ToTy = Ctx.getCanonicalType(CE->getType());
|
|
const PointerType *ToPTy = dyn_cast<PointerType>(ToTy.getTypePtr());
|
|
|
|
if (!ToPTy)
|
|
return;
|
|
|
|
QualType ToPointeeTy = ToPTy->getPointeeType();
|
|
|
|
// Only perform the check if 'ToPointeeTy' is a complete type.
|
|
if (ToPointeeTy->isIncompleteType())
|
|
return;
|
|
|
|
ProgramStateRef state = C.getState();
|
|
const MemRegion *R = state->getSVal(E, C.getLocationContext()).getAsRegion();
|
|
if (!R)
|
|
return;
|
|
|
|
const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
|
|
if (!SR)
|
|
return;
|
|
|
|
SValBuilder &svalBuilder = C.getSValBuilder();
|
|
SVal extent = SR->getExtent(svalBuilder);
|
|
const llvm::APSInt *extentInt = svalBuilder.getKnownValue(state, extent);
|
|
if (!extentInt)
|
|
return;
|
|
|
|
CharUnits regionSize = CharUnits::fromQuantity(extentInt->getSExtValue());
|
|
CharUnits typeSize = C.getASTContext().getTypeSizeInChars(ToPointeeTy);
|
|
|
|
// Ignore void, and a few other un-sizeable types.
|
|
if (typeSize.isZero())
|
|
return;
|
|
|
|
if (regionSize % typeSize == 0)
|
|
return;
|
|
|
|
if (evenFlexibleArraySize(Ctx, regionSize, typeSize, ToPointeeTy))
|
|
return;
|
|
|
|
if (ExplodedNode *errorNode = C.generateErrorNode()) {
|
|
if (!BT)
|
|
BT.reset(new BuiltinBug(this, "Cast region with wrong size.",
|
|
"Cast a region whose size is not a multiple"
|
|
" of the destination type size."));
|
|
auto R = llvm::make_unique<BugReport>(*BT, BT->getDescription(), errorNode);
|
|
R->addRange(CE->getSourceRange());
|
|
C.emitReport(std::move(R));
|
|
}
|
|
}
|
|
|
|
void ento::registerCastSizeChecker(CheckerManager &mgr) {
|
|
mgr.registerChecker<CastSizeChecker>();
|
|
}
|