814b8e91c7
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
28 lines
952 B
LLVM
28 lines
952 B
LLVM
; RUN: opt < %s -argpromotion -S | FileCheck %s
|
|
; CHECK: call void @test(i32 %
|
|
; CHECK: !DISubprogram(name: "test",{{.*}} function: void (i32)* @test
|
|
|
|
declare void @sink(i32)
|
|
|
|
define internal void @test(i32** %X) {
|
|
%1 = load i32*, i32** %X, align 8
|
|
%2 = load i32, i32* %1, align 8
|
|
call void @sink(i32 %2)
|
|
ret void
|
|
}
|
|
|
|
define void @caller(i32** %Y) {
|
|
call void @test(i32** %Y)
|
|
ret void
|
|
}
|
|
|
|
!llvm.module.flags = !{!0}
|
|
!llvm.dbg.cu = !{!3}
|
|
|
|
!0 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!1 = !DILocation(line: 8, scope: !2)
|
|
!2 = distinct !DISubprogram(name: "test", line: 3, isLocal: true, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, scopeLine: 3, scope: null, function: void (i32**)* @test)
|
|
!3 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, producer: "clang version 3.5.0 ", isOptimized: false, emissionKind: 2, file: !5, subprograms: !4)
|
|
!4 = !{!2}
|
|
!5 = !DIFile(filename: "test.c", directory: "")
|