aee4925507
Based on post-commit review discussion on 2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith. Other uses of forcing HasEmptyPlaceHolder to false seem OK to me - they're all around pointer/reference types where the pointer/reference token will appear at the rightmost side of the left side of the type name, so they make nested types (eg: the "int" in "int *") behave as though there is a non-empty placeholder (because the "*" is essentially the placeholder as far as the "int" is concerned). This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075c Reverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakages outside of clang - lldb seems to have some strange/strong dependence on "char [N]" versus "char[N]" when printing strings (not due to that name appearing in DWARF, but probably due to using clang to stringify type names) that'll need to be addressed, plus a few other odds and ends in other subprojects (clang-tools-extra, compiler-rt, etc).
32 lines
1.2 KiB
C++
32 lines
1.2 KiB
C++
// RUN: %clangxx -fsanitize=bounds %s -O3 -o %t
|
|
// RUN: %run %t 0 0 0
|
|
// RUN: %run %t 1 2 3
|
|
// RUN: %expect_crash %run %t 2 0 0 2>&1 | FileCheck %s --check-prefix=CHECK-A-2
|
|
// RUN: %run %t 0 3 0 2>&1 | FileCheck %s --check-prefix=CHECK-B-3
|
|
// RUN: %run %t 0 0 4 2>&1 | FileCheck %s --check-prefix=CHECK-C-4
|
|
|
|
int get_int(int *const p __attribute__((pass_object_size(0))), int i) {
|
|
// CHECK-A-2: bounds.cpp:[[@LINE+1]]:10: runtime error: index 2 out of bounds for type 'int *'
|
|
return p[i];
|
|
}
|
|
|
|
int get_double(double *const p __attribute__((pass_object_size(0))), int i) {
|
|
// CHECK-A-2: bounds.cpp:[[@LINE+1]]:10: runtime error: index 2 out of bounds for type 'double *'
|
|
return p[i];
|
|
}
|
|
|
|
int main(int argc, char **argv) {
|
|
int bar[2];
|
|
get_int(bar, argv[1][0] - '0');
|
|
|
|
double baz[2];
|
|
get_double(baz, argv[1][0] - '0');
|
|
|
|
int arr[2][3][4] = {};
|
|
|
|
return arr[argv[1][0] - '0'][argv[2][0] - '0'][argv[3][0] - '0'];
|
|
// CHECK-A-2: bounds.cpp:[[@LINE-1]]:10: runtime error: index 2 out of bounds for type 'int[2][3][4]'
|
|
// CHECK-B-3: bounds.cpp:[[@LINE-2]]:10: runtime error: index 3 out of bounds for type 'int[3][4]'
|
|
// CHECK-C-4: bounds.cpp:[[@LINE-3]]:10: runtime error: index 4 out of bounds for type 'int[4]'
|
|
}
|