Tom Yang 69a5869da4
[lldb][split-dwarf] implement GetSeparateDebugInfo for SymbolFileOnDemand (#71230)
Small change to get `image dump separate-debug-info` working when using
`symbols.load-on-demand`.

Added tests to `TestDumpDwo`, and enabled the test for all platforms. If we fail to build, we skip the test, so this shouldn't cause the test to fail on unsupported platforms.
```
bin/lldb-dotest -p TestDumpDwo
```

It's easy to verify this manually by running 
```
lldb --one-line-before-file "settings set symbols.load-on-demand true" <some_target>
(lldb) image dump separate-debug-info
...
```

---------

Co-authored-by: Tom Yang <toyang@fb.com>
2023-11-20 12:17:15 -08:00

159 lines
5.3 KiB
Python

"""
Test 'target modules dump separate-debug-info' for oso files.
"""
import json
import os
from lldbsuite.test import lldbtest, lldbutil
from lldbsuite.test.decorators import *
class TestDumpOso(lldbtest.TestBase):
NO_DEBUG_INFO_TESTCASE = True
def get_osos_from_json_output(self):
"""Returns a dictionary of `symfile` -> {`OSO_PATH` -> oso_info object}."""
result = {}
output = json.loads(self.res.GetOutput())
for symfile_entry in output:
oso_dict = {}
for oso_entry in symfile_entry["separate-debug-info-files"]:
oso_dict[oso_entry["oso_path"]] = oso_entry
result[symfile_entry["symfile"]] = oso_dict
return result
@skipIfRemote
@skipUnlessDarwin
def test_shows_oso_loaded_json_output(self):
self.build(debug_info="dwarf")
exe = self.getBuildArtifact("a.out")
main_o = self.getBuildArtifact("main.o")
foo_o = self.getBuildArtifact("foo.o")
# Make sure o files exist
self.assertTrue(os.path.exists(main_o), f'Make sure "{main_o}" file exists')
self.assertTrue(os.path.exists(foo_o), f'Make sure "{foo_o}" file exists')
target = self.dbg.CreateTarget(exe)
self.assertTrue(target, lldbtest.VALID_TARGET)
self.runCmd("target modules dump separate-debug-info --json")
# Check the output
osos = self.get_osos_from_json_output()
self.assertTrue(osos[exe][main_o]["loaded"])
self.assertTrue(osos[exe][foo_o]["loaded"])
@skipIfRemote
@skipUnlessDarwin
def test_shows_oso_not_loaded_json_output(self):
self.build(debug_info="dwarf")
exe = self.getBuildArtifact("a.out")
main_o = self.getBuildArtifact("main.o")
foo_o = self.getBuildArtifact("foo.o")
# REMOVE the o files
os.unlink(main_o)
target = self.dbg.CreateTarget(exe)
self.assertTrue(target, lldbtest.VALID_TARGET)
self.runCmd("target modules dump separate-debug-info --json")
# Check the output
osos = self.get_osos_from_json_output()
self.assertFalse(osos[exe][main_o]["loaded"])
self.assertIn("error", osos[exe][main_o])
self.assertTrue(osos[exe][foo_o]["loaded"])
self.assertNotIn("error", osos[exe][foo_o])
# Check with --errors-only
self.runCmd("target modules dump separate-debug-info --json --errors-only")
output = self.get_osos_from_json_output()
self.assertFalse(output[exe][main_o]["loaded"])
self.assertIn("error", output[exe][main_o])
self.assertNotIn(foo_o, output[exe])
@skipIfRemote
@skipUnlessDarwin
def test_shows_oso_loaded_table_output(self):
self.build(debug_info="dwarf")
exe = self.getBuildArtifact("a.out")
main_o = self.getBuildArtifact("main.o")
foo_o = self.getBuildArtifact("foo.o")
# Make sure o files exist
self.assertTrue(os.path.exists(main_o), f'Make sure "{main_o}" file exists')
self.assertTrue(os.path.exists(foo_o), f'Make sure "{foo_o}" file exists')
target = self.dbg.CreateTarget(exe)
self.assertTrue(target, lldbtest.VALID_TARGET)
self.expect(
"target modules dump separate-debug-info",
patterns=[
"Symbol file: .*?a\.out",
'Type: "oso"',
"Mod Time\s+Err\s+Oso Path",
"0x[a-zA-Z0-9]{16}\s+.*main\.o",
"0x[a-zA-Z0-9]{16}\s+.*foo\.o",
],
)
@skipIfRemote
@skipUnlessDarwin
def test_shows_oso_not_loaded_table_output(self):
self.build(debug_info="dwarf")
exe = self.getBuildArtifact("a.out")
main_o = self.getBuildArtifact("main.o")
foo_o = self.getBuildArtifact("foo.o")
# REMOVE the o files
os.unlink(main_o)
os.unlink(foo_o)
target = self.dbg.CreateTarget(exe)
self.assertTrue(target, lldbtest.VALID_TARGET)
self.expect(
"target modules dump separate-debug-info",
patterns=[
"Symbol file: .*?a\.out",
'Type: "oso"',
"Mod Time\s+Err\s+Oso Path",
"0x[a-zA-Z0-9]{16}\s+E\s+.*main\.o",
"0x[a-zA-Z0-9]{16}\s+E\s+.*foo\.o",
],
)
@skipIfRemote
@skipUnlessDarwin
def test_osos_loaded_symbols_on_demand(self):
self.build(debug_info="dwarf")
exe = self.getBuildArtifact("a.out")
main_o = self.getBuildArtifact("main.o")
foo_o = self.getBuildArtifact("foo.o")
# Make sure o files exist
self.assertTrue(os.path.exists(main_o), f'Make sure "{main_o}" file exists')
self.assertTrue(os.path.exists(foo_o), f'Make sure "{foo_o}" file exists')
target = self.dbg.CreateTarget(exe)
self.assertTrue(target, lldbtest.VALID_TARGET)
self.runCmd("target modules dump separate-debug-info --json")
# Load symbols on-demand
self.runCmd("settings set symbols.load-on-demand true")
target = self.dbg.CreateTarget(exe)
self.assertTrue(target, lldbtest.VALID_TARGET)
self.runCmd("target modules dump separate-debug-info --json")
# Check the output
osos = self.get_osos_from_json_output()
self.assertTrue(osos[exe][main_o]["loaded"])
self.assertTrue(osos[exe][foo_o]["loaded"])