5be7f2a943
Assemblers change certain relocations referencing a local symbol to reference the section symbol instead. This conversion is disabled for many conditions (`shouldRelocateWithSymbol`), e.g. TLS symbol, for most targets (including AArch32, x86, PowerPC, and RISC-V) GOT-generating relocations. However, AArch64 encodes the GOT-generating intent in MCValue::RefKind instead of MCSymbolRef::Kind (see commit 0999cbd0b9ed8aa893cce10d681dec6d54b200ad (2014)), therefore not affected by the code `case MCSymbolRefExpr::VK_GOT:`. As GNU ld and ld.lld create GOT entries based on the symbol, ignoring addend, the two ldr instructions will share the same GOT entry, which is not expected: ``` ldr x1, [x1, :got_lo12:x] // converted to .data+0 ldr x1, [x1, :got_lo12:y] // converted to .data+4 .data // .globl x, y would suppress STT_SECTION conversion x: .zero 4 y: .long 42 ``` This patch changes AArch64 to suppress local symbol to STT_SECTION conversion for GOT relocations, matching most other targets. x and y will use different GOT entries, which IMO is the most sensable behavior. With this change, the ABI decision on https://github.com/ARM-software/abi-aa/issues/217 will only affect relocations explicitly referencing STT_SECTION symbols, e.g. ``` ldr x1, [x1, :got_lo12:(.data+0)] ldr x1, [x1, :got_lo12:(.data+4)] // I consider this unreasonable uses ``` IMO all reasonable use cases are unaffected. Link: https://github.com/llvm/llvm-project/issues/63418 GNU assembler PR: https://sourceware.org/bugzilla/show_bug.cgi?id=30788 Reviewed By: peter.smith Differential Revision: https://reviews.llvm.org/D158577
94 lines
2.8 KiB
C++
94 lines
2.8 KiB
C++
//===-- LanaiELFObjectWriter.cpp - Lanai ELF Writer -----------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "MCTargetDesc/LanaiBaseInfo.h"
|
|
#include "MCTargetDesc/LanaiFixupKinds.h"
|
|
#include "llvm/BinaryFormat/ELF.h"
|
|
#include "llvm/MC/MCELFObjectWriter.h"
|
|
#include "llvm/MC/MCObjectWriter.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
class LanaiELFObjectWriter : public MCELFObjectTargetWriter {
|
|
public:
|
|
explicit LanaiELFObjectWriter(uint8_t OSABI);
|
|
|
|
~LanaiELFObjectWriter() override = default;
|
|
|
|
protected:
|
|
unsigned getRelocType(MCContext &Ctx, const MCValue &Target,
|
|
const MCFixup &Fixup, bool IsPCRel) const override;
|
|
bool needsRelocateWithSymbol(const MCValue &Val, const MCSymbol &Sym,
|
|
unsigned Type) const override;
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
LanaiELFObjectWriter::LanaiELFObjectWriter(uint8_t OSABI)
|
|
: MCELFObjectTargetWriter(/*Is64Bit_=*/false, OSABI, ELF::EM_LANAI,
|
|
/*HasRelocationAddend_=*/true) {}
|
|
|
|
unsigned LanaiELFObjectWriter::getRelocType(MCContext & /*Ctx*/,
|
|
const MCValue & /*Target*/,
|
|
const MCFixup &Fixup,
|
|
bool /*IsPCRel*/) const {
|
|
unsigned Type;
|
|
unsigned Kind = static_cast<unsigned>(Fixup.getKind());
|
|
switch (Kind) {
|
|
case Lanai::FIXUP_LANAI_21:
|
|
Type = ELF::R_LANAI_21;
|
|
break;
|
|
case Lanai::FIXUP_LANAI_21_F:
|
|
Type = ELF::R_LANAI_21_F;
|
|
break;
|
|
case Lanai::FIXUP_LANAI_25:
|
|
Type = ELF::R_LANAI_25;
|
|
break;
|
|
case Lanai::FIXUP_LANAI_32:
|
|
case FK_Data_4:
|
|
Type = ELF::R_LANAI_32;
|
|
break;
|
|
case Lanai::FIXUP_LANAI_HI16:
|
|
Type = ELF::R_LANAI_HI16;
|
|
break;
|
|
case Lanai::FIXUP_LANAI_LO16:
|
|
Type = ELF::R_LANAI_LO16;
|
|
break;
|
|
case Lanai::FIXUP_LANAI_NONE:
|
|
Type = ELF::R_LANAI_NONE;
|
|
break;
|
|
|
|
default:
|
|
llvm_unreachable("Invalid fixup kind!");
|
|
}
|
|
return Type;
|
|
}
|
|
|
|
bool LanaiELFObjectWriter::needsRelocateWithSymbol(const MCValue &,
|
|
const MCSymbol &,
|
|
unsigned Type) const {
|
|
switch (Type) {
|
|
case ELF::R_LANAI_21:
|
|
case ELF::R_LANAI_21_F:
|
|
case ELF::R_LANAI_25:
|
|
case ELF::R_LANAI_32:
|
|
case ELF::R_LANAI_HI16:
|
|
return true;
|
|
default:
|
|
return false;
|
|
}
|
|
}
|
|
|
|
std::unique_ptr<MCObjectTargetWriter>
|
|
llvm::createLanaiELFObjectWriter(uint8_t OSABI) {
|
|
return std::make_unique<LanaiELFObjectWriter>(OSABI);
|
|
}
|