
Updates the implementation `std::reference_wrapper` - [P2944R3](https://wg21.link/P2944R3) as discussed in https://github.com/llvm/llvm-project/pull/117664#discussion_r1857826166 This PR also refactors the tests in preparation to implements the constrained comparisons for `optional`, `variant` etc. - Moves the test helpers (concepts and types) for testing constrained comparisons to `test_comparisons.h`. - Updates the `std::reference_wrapper` implementation to use the concept `__core_convertible_to<bool>` as per comments in #135759. Closes #138233 # References: - [refwrap.comparisons](https://wg21.link/refwrap.comparisons) --------- Co-authored-by: Hristo Hristov <zingam@outlook.com> Co-authored-by: Nikolas Klauser <nikolasklauser@berlin.de>
90 lines
2.3 KiB
C++
90 lines
2.3 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// REQUIRES: std-at-least-c++26
|
|
|
|
// <functional>
|
|
|
|
// class reference_wrapper
|
|
|
|
// [refwrap.comparisons], comparisons
|
|
|
|
// friend constexpr auto operator<=>(reference_wrapper, reference_wrapper); // Since C++26
|
|
|
|
#include <cassert>
|
|
#include <concepts>
|
|
#include <functional>
|
|
|
|
#include "test_comparisons.h"
|
|
#include "test_macros.h"
|
|
// Test SFINAE.
|
|
|
|
static_assert(HasOperatorSpaceship<std::reference_wrapper<StrongOrder>>);
|
|
static_assert(HasOperatorSpaceship<std::reference_wrapper<WeakOrder>>);
|
|
static_assert(HasOperatorSpaceship<std::reference_wrapper<PartialOrder>>);
|
|
|
|
static_assert(!HasOperatorSpaceship<std::reference_wrapper<NonComparable>>);
|
|
|
|
// Test comparisons.
|
|
|
|
template <typename T, typename Order>
|
|
constexpr void test() {
|
|
T t{47};
|
|
|
|
T bigger{94};
|
|
T smaller{82};
|
|
|
|
T unordered{std::numeric_limits<int>::min()};
|
|
|
|
// Identical contents
|
|
{
|
|
std::reference_wrapper<T> rw1{t};
|
|
std::reference_wrapper<T> rw2{t};
|
|
assert(testOrder(rw1, rw2, Order::equivalent));
|
|
}
|
|
// Less
|
|
{
|
|
std::reference_wrapper<T> rw1{smaller};
|
|
std::reference_wrapper<T> rw2{bigger};
|
|
assert(testOrder(rw1, rw2, Order::less));
|
|
}
|
|
// Greater
|
|
{
|
|
std::reference_wrapper<T> rw1{bigger};
|
|
std::reference_wrapper<T> rw2{smaller};
|
|
assert(testOrder(rw1, rw2, Order::greater));
|
|
}
|
|
// Unordered
|
|
if constexpr (std::same_as<T, PartialOrder>) {
|
|
std::reference_wrapper<T> rw1{bigger};
|
|
std::reference_wrapper<T> rw2{unordered};
|
|
assert(testOrder(rw1, rw2, Order::unordered));
|
|
}
|
|
}
|
|
|
|
constexpr bool test() {
|
|
test<int, std::strong_ordering>();
|
|
test<StrongOrder, std::strong_ordering>();
|
|
test<int, std::weak_ordering>();
|
|
test<WeakOrder, std::weak_ordering>();
|
|
test<int, std::partial_ordering>();
|
|
test<PartialOrder, std::partial_ordering>();
|
|
|
|
// `LessAndEqComp` does not have `operator<=>`. Ordering is synthesized based on `operator<`
|
|
test<LessAndEqComp, std::weak_ordering>();
|
|
|
|
return true;
|
|
}
|
|
|
|
int main(int, char**) {
|
|
test();
|
|
static_assert(test());
|
|
|
|
return 0;
|
|
}
|