7c1b948e30
Pointers and GEP are untyped. SPIR-V required structured OpAccessChain. This means the backend will have to determine a good way to retrieve the structured access from an untyped GEP. This is not a trivial problem, and needs to be addressed to have a robust compiler. The issue is other workstreams relies on the access chain deduction to work. So we have 2 options: - pause all dependent work until we have a good chain deduction. - submit this limited fix to we can work on both this and other features in parallel. Choice we want to make is #2: submitting this **knowing this is not a good** fix. It only increase the number of patterns we can work with, thus allowing others to continue working on other parts of the backend. This patch as-is has many limitations: - If cannot robustly determine the depth of the structured access from a GEP. Fixing this would require looking ahead at the full GEP chain. - It cannot always figure out the correct access indices, especially with dynamic indices. This will require frontend collaboration. Because we know this is a temporary hack, this patch only impacts the logical SPIR-V target. Physical SPIR-V, which can rely on pointer cast remains on the old method. Related to #145002
61 lines
2.2 KiB
LLVM
61 lines
2.2 KiB
LLVM
; RUN: llc -O0 -mtriple=spirv-unknown-vulkan1.3-compute %s -o - -print-after-all | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-vulkan1.3-compute %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK-DAG: [[uint:%[0-9]+]] = OpTypeInt 32 0
|
|
|
|
%A = type {
|
|
i32,
|
|
i32
|
|
}
|
|
; CHECK-DAG: [[A:%[0-9]+]] = OpTypeStruct [[uint]] [[uint]]
|
|
|
|
%B = type {
|
|
%A,
|
|
i32,
|
|
%A
|
|
}
|
|
; CHECK-DAG: [[B:%[0-9]+]] = OpTypeStruct [[A]] [[uint]] [[A]]
|
|
|
|
; CHECK-DAG: [[uint_0:%[0-9]+]] = OpConstant [[uint]] 0
|
|
; CHECK-DAG: [[uint_1:%[0-9]+]] = OpConstant [[uint]] 1
|
|
; CHECK-DAG: [[uint_2:%[0-9]+]] = OpConstant [[uint]] 2
|
|
|
|
; CHECK-DAG: [[ptr_uint:%[0-9]+]] = OpTypePointer Function [[uint]]
|
|
; CHECK-DAG: [[ptr_A:%[0-9]+]] = OpTypePointer Function [[A]]
|
|
; CHECK-DAG: [[ptr_B:%[0-9]+]] = OpTypePointer Function [[B]]
|
|
|
|
define void @main() #1 {
|
|
entry:
|
|
%0 = alloca %B, align 4
|
|
; CHECK: [[tmp:%[0-9]+]] = OpVariable [[ptr_B]] Function
|
|
|
|
%1 = getelementptr %B, ptr %0, i32 0, i32 0
|
|
; CHECK: {{%[0-9]+}} = OpAccessChain [[ptr_A]] [[tmp]] [[uint_0]]
|
|
%2 = getelementptr inbounds %B, ptr %0, i32 0, i32 0
|
|
; CHECK: {{%[0-9]+}} = OpInBoundsAccessChain [[ptr_A]] [[tmp]] [[uint_0]]
|
|
|
|
%3 = getelementptr %B, ptr %0, i32 0, i32 1
|
|
; CHECK: {{%[0-9]+}} = OpAccessChain [[ptr_uint]] [[tmp]] [[uint_1]]
|
|
%4 = getelementptr inbounds %B, ptr %0, i32 0, i32 1
|
|
; CHECK: {{%[0-9]+}} = OpInBoundsAccessChain [[ptr_uint]] [[tmp]] [[uint_1]]
|
|
|
|
%5 = getelementptr %B, ptr %0, i32 0, i32 2
|
|
; CHECK: {{%[0-9]+}} = OpAccessChain [[ptr_A]] [[tmp]] [[uint_2]]
|
|
%6 = getelementptr inbounds %B, ptr %0, i32 0, i32 2
|
|
; CHECK: {{%[0-9]+}} = OpInBoundsAccessChain [[ptr_A]] [[tmp]] [[uint_2]]
|
|
|
|
%7 = getelementptr %B, ptr %0, i32 0, i32 2, i32 1
|
|
; CHECK: {{%[0-9]+}} = OpAccessChain [[ptr_uint]] [[tmp]] [[uint_2]] [[uint_1]]
|
|
%8 = getelementptr inbounds %B, ptr %0, i32 0, i32 2, i32 1
|
|
; CHECK: {{%[0-9]+}} = OpInBoundsAccessChain [[ptr_uint]] [[tmp]] [[uint_2]] [[uint_1]]
|
|
|
|
%9 = getelementptr %B, ptr %0, i32 0, i32 2
|
|
%10 = getelementptr %A, ptr %9, i32 0, i32 1
|
|
; CHECK: [[x:%[0-9]+]] = OpAccessChain [[ptr_A]] [[tmp]] [[uint_2]]
|
|
; CHECK: {{%[0-9]+}} = OpAccessChain [[ptr_uint]] [[x]] [[uint_1]]
|
|
|
|
ret void
|
|
}
|
|
|
|
attributes #1 = { "hlsl.numthreads"="4,8,16" "hlsl.shader"="compute" }
|