dfb9bf35c4
By SPIR-V specification: "If an instruction, enumerant, or other feature specifies multiple enabling capabilities, only one such capability needs to be declared to use the feature." However, one capability may be preferred over another. One important case is Shader capability that may not be supported by a backend, but always is inserted if "OpDecorate SpecId" is found, because Enabling Capabilities for the latter is the list of Shader and Kernel, where Shader is coming first and thus always selected as the first available option. In this PR we address the problem by keeping current behaviour of selecting the first option among enabling capabilities as is, but giving a user a way to filter capabilities during the selection process via a newly introduced "--avoid-spirv-capabilities" command line option. This option is to avoid selection of certain capabilities if there are other available enabling capabilities. This PR is changing also existing pruneCapabilities() function. It doesn't remove capability from module requirement anymore, but only adds implicitly required capabilities recursively, so its name is changed accordingly. This change fixes the present bug in collecting required by a module capabilities. Before the change, introduced by this PR, pruneCapabilities() function has been removing, for example, Kernel capability from required by a module, because Kernel is initially required and the second time it was needed pruneCapabilities() removed it by mistake.
63 lines
2.9 KiB
LLVM
63 lines
2.9 KiB
LLVM
; RUN: llc -O0 -mtriple=spirv32-unknown-unknown --avoid-spirv-capabilities=Shader %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown --avoid-spirv-capabilities=Shader %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK-SPIRV-DAG: OpCapability Kernel
|
|
; CHECK-SPIRV-NOT: OpCapability Matrix
|
|
; CHECK-SPIRV-NOT: OpCapability Shader
|
|
|
|
; CHECK-SPIRV-DAG: OpDecorate %[[#SC0:]] SpecId 0
|
|
; CHECK-SPIRV-DAG: OpDecorate %[[#SC1:]] SpecId 1
|
|
; CHECK-SPIRV-DAG: OpDecorate %[[#SC2:]] SpecId 2
|
|
; CHECK-SPIRV-DAG: OpDecorate %[[#SC3:]] SpecId 3
|
|
; CHECK-SPIRV-DAG: OpDecorate %[[#SC4:]] SpecId 4
|
|
; CHECK-SPIRV-DAG: OpDecorate %[[#SC5:]] SpecId 5
|
|
; CHECK-SPIRV-DAG: OpDecorate %[[#SC6:]] SpecId 6
|
|
; CHECK-SPIRV-DAG: OpDecorate %[[#SC7:]] SpecId 7
|
|
|
|
; CHECK-SPIRV-DAG: %[[#SC0]] = OpSpecConstantFalse %[[#]]
|
|
; CHECK-SPIRV-DAG: %[[#SC1]] = OpSpecConstant %[[#]] 100
|
|
; CHECK-SPIRV-DAG: %[[#SC2]] = OpSpecConstant %[[#]] 1
|
|
; CHECK-SPIRV-DAG: %[[#SC3]] = OpSpecConstant %[[#]] 2
|
|
; CHECK-SPIRV-DAG: %[[#SC4]] = OpSpecConstant %[[#]] 3 0
|
|
; CHECK-SPIRV-DAG: %[[#SC5]] = OpSpecConstant %[[#]] 14336
|
|
; CHECK-SPIRV-DAG: %[[#SC6]] = OpSpecConstant %[[#]] 1067450368
|
|
; CHECK-SPIRV-DAG: %[[#SC7]] = OpSpecConstant %[[#]] 0 1073807360
|
|
|
|
define spir_kernel void @foo(i8 addrspace(1)* nocapture %b, i8 addrspace(1)* nocapture %c, i16 addrspace(1)* nocapture %s, i32 addrspace(1)* nocapture %i, i64 addrspace(1)* nocapture %l, half addrspace(1)* nocapture %h, float addrspace(1)* nocapture %f, double addrspace(1)* nocapture %d) local_unnamed_addr {
|
|
entry:
|
|
%0 = call i1 @_Z20__spirv_SpecConstantib(i32 0, i1 false)
|
|
%conv = zext i1 %0 to i8
|
|
store i8 %conv, i8 addrspace(1)* %b, align 1
|
|
|
|
%1 = call i8 @_Z20__spirv_SpecConstantia(i32 1, i8 100)
|
|
store i8 %1, i8 addrspace(1)* %c, align 1
|
|
|
|
%2 = call i16 @_Z20__spirv_SpecConstantis(i32 2, i16 1)
|
|
store i16 %2, i16 addrspace(1)* %s, align 2
|
|
|
|
%3 = call i32 @_Z20__spirv_SpecConstantii(i32 3, i32 2)
|
|
store i32 %3, i32 addrspace(1)* %i, align 4
|
|
|
|
%4 = call i64 @_Z20__spirv_SpecConstantix(i32 4, i64 3)
|
|
store i64 %4, i64 addrspace(1)* %l, align 8
|
|
|
|
%5 = call half @_Z20__spirv_SpecConstantih(i32 5, half 0xH3800)
|
|
store half %5, half addrspace(1)* %h, align 2
|
|
|
|
%6 = call float @_Z20__spirv_SpecConstantif(i32 6, float 1.250000e+00)
|
|
store float %6, float addrspace(1)* %f, align 4
|
|
|
|
%7 = call double @_Z20__spirv_SpecConstantid(i32 7, double 2.125000e+00)
|
|
store double %7, double addrspace(1)* %d, align 8
|
|
ret void
|
|
}
|
|
|
|
declare i1 @_Z20__spirv_SpecConstantib(i32, i1)
|
|
declare i8 @_Z20__spirv_SpecConstantia(i32, i8)
|
|
declare i16 @_Z20__spirv_SpecConstantis(i32, i16)
|
|
declare i32 @_Z20__spirv_SpecConstantii(i32, i32)
|
|
declare i64 @_Z20__spirv_SpecConstantix(i32, i64)
|
|
declare half @_Z20__spirv_SpecConstantih(i32, half)
|
|
declare float @_Z20__spirv_SpecConstantif(i32, float)
|
|
declare double @_Z20__spirv_SpecConstantid(i32, double)
|