3bdf9a0880
Currently iterators over EquivalenceClasses will iterate over std::set, which guarantees the order specified by the comperator. Unfortunately in many cases, EquivalenceClasses are used with pointers, so iterating over std::set of pointers will not be deterministic across runs. There are multiple places that explicitly try to sort the equivalence classes before using them to try to get a deterministic order (LowerTypeTests, SplitModule), but there are others that do not at the moment and this can result at least in non-determinstic value naming in Float2Int. This patch updates EquivalenceClasses to keep track of all members via a extra SmallVector and removes code from LowerTypeTests and SplitModule to sort the classes before processing. Overall it looks like compile-time slightly decreases in most cases, but close to noise: https://llvm-compile-time-tracker.com/compare.php?from=7d441d9892295a6eb8aaf481e1715f039f6f224f&to=b0c2ac67a88d3ef86987e2f82115ea0170675a17&stat=instructions PR: https://github.com/llvm/llvm-project/pull/134075
48 lines
1.2 KiB
LLVM
48 lines
1.2 KiB
LLVM
; We should never separate alias from aliasee.
|
|
; RUN: llvm-split -j=3 -preserve-locals -o %t %s
|
|
; RUN: llvm-dis -o - %t0 | FileCheck --check-prefix=CHECK0 %s
|
|
; RUN: llvm-dis -o - %t1 | FileCheck --check-prefix=CHECK1 %s
|
|
; RUN: llvm-dis -o - %t2 | FileCheck --check-prefix=CHECK2 %s
|
|
|
|
; Checks are not critical here - verifier will assert if we fail.
|
|
; CHECK0: @funInternalAlias = alias
|
|
; CHECK0: define internal i32 @funInternal
|
|
|
|
; CHECK1: @funExternalAlias = alias
|
|
; CHECK1: define i32 @funExternal
|
|
|
|
; CHECK2: @funInternal2Alias = alias
|
|
; CHECK2: @funExternal2Alias = alias
|
|
; CHECK2: define internal i32 @funInternal2
|
|
; CHECK2: define i32 @funExternal2
|
|
|
|
@funInternalAlias = alias i32 (), ptr @funInternal
|
|
@funExternalAlias = alias i32 (), ptr @funExternal
|
|
@funInternal2Alias = alias i32 (), ptr @funInternal2
|
|
@funExternal2Alias = alias i32 (), ptr @funExternal2
|
|
|
|
define internal i32 @funInternal() {
|
|
entry:
|
|
ret i32 0
|
|
}
|
|
|
|
define i32 @funExternal() {
|
|
entry:
|
|
%x = call i32 @funInternalAlias()
|
|
ret i32 %x
|
|
}
|
|
|
|
define internal i32 @funInternal2() {
|
|
entry:
|
|
%x = call i32 @funInternalAlias()
|
|
ret i32 %x
|
|
}
|
|
|
|
define i32 @funExternal2() {
|
|
entry:
|
|
%x = call i32 @funInternal2()
|
|
%y = call i32 @funExternalAlias()
|
|
%z = add nsw i32 %x, %y
|
|
ret i32 %z
|
|
}
|