50a3368f22
The Generic_GCC::GCCInstallationDetector class picks the GCC installation directory with the largest version number. Since the location of the libstdc++ include directories is tied to the GCC version, this can break C++ compilation if the libstdc++ headers for this particular GCC version are not available. Linux distributions tend to package the libstdc++ headers separately from GCC. This frequently leads to situations in which a newer version of GCC gets installed as a dependency of another package without installing the corresponding libstdc++ package. Clang then fails to compile C++ code because it cannot find the libstdc++ headers. Since libstdc++ headers are in fact installed on the system, the GCC installation continues to work, the user may not be aware of the details of the GCC detection, and the compiler does not recognize the situation and emit a warning, this behavior can be hard to understand - as witnessed by many related bug reports over the years. The goal of this work is to change the GCC detection to prefer GCC installations that contain libstdc++ include directories over those which do not. This should happen regardless of the input language since picking different GCC installations for a build that mixes C and C++ might lead to incompatibilities. Any change to the GCC installation detection will probably have a negative impact on some users. For instance, for a C user who relies on using the GCC installation with the largest version number, it might become necessary to use the --gcc-install-dir option to ensure that this GCC version is selected. This seems like an acceptable trade-off given that the situation for users who do not have any special demands on the particular GCC installation directory would be improved significantly. This patch does not yet change the automatic GCC installation directory choice. Instead, it does introduce a warning that informs the user about the future change if the chosen GCC installation directory differs from the one that would be chosen if the libstdc++ headers are taken into account. See also this related Discourse discussion: https://discourse.llvm.org/t/rfc-take-libstdc-into-account-during-gcc-detection/86992.
29 lines
2.0 KiB
C++
29 lines
2.0 KiB
C++
// UNSUPPORTED: system-windows
|
|
|
|
// This file tests that the GCC installation directory detection takes
|
|
// the libstdc++ includes into account. In each directory
|
|
// Inputs/gcc_toolchain_libstdcxx/gccX, the installation directory for
|
|
// gcc X should be picked in the future since it is the directory with
|
|
// the largest version number which also contains the libstdc++
|
|
// include directory.
|
|
|
|
// RUN: %clang --gcc-toolchain=%S/Inputs/gcc_toolchain_libstdcxx/gcc10/usr -v 2>&1 |& FileCheck %s --check-prefix=GCC10
|
|
// GCC10: clang: warning: future releases of the clang compiler will prefer GCC installations containing libstdc++ include directories; '[[PREFIX:.*gcc_toolchain_libstdcxx/gcc10/usr/lib/gcc/x86_64-linux-gnu]]/10' would be chosen over '[[PREFIX]]/12' [-Wgcc-install-dir-libstdcxx]
|
|
// GCC10: Found candidate GCC installation: [[PREFIX]]/10
|
|
// GCC10: Found candidate GCC installation: [[PREFIX]]/11
|
|
// GCC10: Found candidate GCC installation: [[PREFIX]]/12
|
|
// GCC10: Selected GCC installation: [[PREFIX]]/12
|
|
|
|
// RUN: %clang --gcc-toolchain=%S/Inputs/gcc_toolchain_libstdcxx/gcc11/usr -v 2>&1 |& FileCheck %s --check-prefix=ONLY_GCC11
|
|
// ONLY_GCC11: clang: warning: future releases of the clang compiler will prefer GCC installations containing libstdc++ include directories; '[[PREFIX:.*gcc_toolchain_libstdcxx/gcc11/usr/lib/gcc/x86_64-linux-gnu]]/11' would be chosen over '[[PREFIX]]/12' [-Wgcc-install-dir-libstdcxx]
|
|
// ONLY_GCC11: Found candidate GCC installation: [[PREFIX]]/10
|
|
// ONLY_GCC11: Found candidate GCC installation: [[PREFIX]]/11
|
|
// ONLY_GCC11: Found candidate GCC installation: [[PREFIX]]/12
|
|
// ONLY_GCC11: Selected GCC installation: [[PREFIX]]/12
|
|
|
|
// RUN: %clang --gcc-toolchain=%S/Inputs/gcc_toolchain_libstdcxx/gcc12/usr -v 2>&1 |& FileCheck %s --check-prefix=GCC12
|
|
// GCC12: Found candidate GCC installation: [[PREFIX:.*gcc_toolchain_libstdcxx/gcc12/usr/lib/gcc/x86_64-linux-gnu]]/10
|
|
// GCC12: Found candidate GCC installation: [[PREFIX]]/11
|
|
// GCC12: Found candidate GCC installation: [[PREFIX]]/12
|
|
// GCC12: Selected GCC installation: [[PREFIX]]/12
|