896ece41e4
Summary:
I found the following case having tail blocks with no successors merging opportunities after block placement.
Before block placement:
bb0:
...
bne a0, 0, bb2:
bb1:
mv a0, 1
ret
bb2:
...
bb3:
mv a0, 1
ret
bb4:
mv a0, -1
ret
The conditional branch bne in bb0 is opposite to beq.
After block placement:
bb0:
...
beq a0, 0, bb1
bb2:
...
bb4:
mv a0, -1
ret
bb1:
mv a0, 1
ret
bb3:
mv a0, 1
ret
After block placement, that appears new tail merging opportunity, bb1 and bb3 can be merged as one block. So the conditional constraint for merging tail blocks with no successors should be removed. In my experiment for RISC-V, it decreases code size.
Author of original patch: Jim Lin
Reviewers: haicheng, aheejin, craig.topper, rnk, RKSimon, Jim, dmgreen
Reviewed By: Jim, dmgreen
Subscribers: xbolva00, dschuff, javed.absar, sbc100, jgravelle-google, aheejin, kito-cheng, dmgreen, PkmX, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D54411
llvm-svn: 363284
56 lines
1.1 KiB
LLVM
56 lines
1.1 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
|
; RUN: llc -mtriple=x86_64-pc-linux-gnu -tail-merge-threshold 2 < %s | FileCheck %s
|
|
|
|
; Test that we still do some merging if a block has more than
|
|
; tail-merge-threshold predecessors.
|
|
|
|
declare void @bar()
|
|
|
|
define void @foo(i32 %xxx) nounwind {
|
|
; CHECK-LABEL: foo:
|
|
; CHECK: # %bb.0:
|
|
; CHECK-NEXT: pushq %rax
|
|
; CHECK-NEXT: cmpl $3, %edi
|
|
; CHECK-NEXT: ja .LBB0_4
|
|
; CHECK-NEXT: # %bb.1:
|
|
; CHECK-NEXT: movl %edi, %eax
|
|
; CHECK-NEXT: jmpq *.LJTI0_0(,%rax,8)
|
|
; CHECK-NEXT: .LBB0_3: # %bb3
|
|
; CHECK-NEXT: callq bar
|
|
; CHECK-NEXT: popq %rax
|
|
; CHECK-NEXT: retq
|
|
; CHECK-NEXT: .LBB0_4: # %bb4
|
|
; CHECK-NEXT: callq bar
|
|
; CHECK-NEXT: popq %rax
|
|
; CHECK-NEXT: retq
|
|
switch i32 %xxx, label %bb4 [
|
|
i32 0, label %bb0
|
|
i32 1, label %bb1
|
|
i32 2, label %bb2
|
|
i32 3, label %bb3
|
|
]
|
|
|
|
bb0:
|
|
call void @bar()
|
|
br label %bb5
|
|
|
|
bb1:
|
|
call void @bar()
|
|
br label %bb5
|
|
|
|
bb2:
|
|
call void @bar()
|
|
br label %bb5
|
|
|
|
bb3:
|
|
call void @bar()
|
|
br label %bb5
|
|
|
|
bb4:
|
|
call void @bar()
|
|
br label %bb5
|
|
|
|
bb5:
|
|
ret void
|
|
}
|