1a58be2ac5
Summary: Without this patch, the jump threading pass ignores profiling data whenever we invoke the pass with the new pass manager. Specifically, JumpThreadingPass::run calls runImpl with class variable HasProfileData always set to false. In turn, runImpl sets HasProfileData to false again: HasProfileData = HasProfileData_; In the end, we don't use profiling data at all with the new pass manager. This patch fixes the problem by passing F.hasProfileData() to runImpl. The bug appears to have been introduced at: https://reviews.llvm.org/D41461 which removed local variable HasProfileData in JumpThreadingPass::run even though there was one more use left in the same function. As a result, the remaining use ended referring to the class variable instead. Note that F.hasProfileData is an extremely lightweight function, so I don't see the need to cache its result. Once this patch is approved, I'm planning to stop caching the result of F.hasProfileData in runOnFunction. Reviewers: wmi, eli.friedman Subscribers: hiraditya, jfb, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70509
45 lines
899 B
LLVM
45 lines
899 B
LLVM
; RUN: opt -S -jump-threading %s | FileCheck %s
|
|
; RUN: opt -S -passes=jump-threading %s | FileCheck %s
|
|
|
|
; Test if edge weights are properly updated after jump threading.
|
|
|
|
; CHECK: !2 = !{!"branch_weights", i32 1629125526, i32 518358122}
|
|
|
|
define void @foo(i32 %n) !prof !0 {
|
|
entry:
|
|
%cmp = icmp sgt i32 %n, 10
|
|
br i1 %cmp, label %if.then.1, label %if.else.1, !prof !1
|
|
|
|
if.then.1:
|
|
tail call void @a()
|
|
br label %if.cond
|
|
|
|
if.else.1:
|
|
tail call void @b()
|
|
br label %if.cond
|
|
|
|
if.cond:
|
|
%cmp1 = icmp sgt i32 %n, 5
|
|
br i1 %cmp1, label %if.then.2, label %if.else.2, !prof !2
|
|
|
|
if.then.2:
|
|
tail call void @c()
|
|
br label %if.end
|
|
|
|
if.else.2:
|
|
tail call void @d()
|
|
br label %if.end
|
|
|
|
if.end:
|
|
ret void
|
|
}
|
|
|
|
declare void @a()
|
|
declare void @b()
|
|
declare void @c()
|
|
declare void @d()
|
|
|
|
!0 = !{!"function_entry_count", i64 1}
|
|
!1 = !{!"branch_weights", i32 10, i32 5}
|
|
!2 = !{!"branch_weights", i32 10, i32 1}
|