Jakub Kuderski d98cb81cd1 Handle successor's PHI node correctly when flattening CFG merges two if-regions
Summary:
FlattenCFG merges two 'if' basicblocks by inserting one basicblock
to another basicblock. The inserted basicblock can have a successor
that contains a PHI node whoes incoming basicblock is the inserted
basicblock. Since the existing code does not handle it, it becomes
a badref.

if (cond1)
  statement
if (cond2)
  statement
successor - contains PHI node whose predecessor is cond2

-->
if (cond1 || cond2)
  statement
(BB for cond2 was deleted)
successor - contains PHI node whose predecessor is cond2 --> bad ref!

Author: Jaebaek Seo

Reviewers: asbirlea, kuhar, tstellar, chandlerc, davide, dexonsmith

Reviewed By: kuhar

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68032

llvm-svn: 372989
2019-09-26 15:20:17 +00:00

87 lines
2.5 KiB
LLVM

; RUN: opt -flattencfg -S < %s | FileCheck %s
; This test checks whether the pass completes without a crash.
; The code is not transformed in any way
;
; CHECK-LABEL: @test_not_crash
define void @test_not_crash(i32 %in_a) #0 {
entry:
%cmp0 = icmp eq i32 %in_a, -1
%cmp1 = icmp ne i32 %in_a, 0
%cond0 = and i1 %cmp0, %cmp1
br i1 %cond0, label %b0, label %b1
b0: ; preds = %entry
%cmp2 = icmp eq i32 %in_a, 0
%cmp3 = icmp ne i32 %in_a, 1
%cond1 = or i1 %cmp2, %cmp3
br i1 %cond1, label %exit, label %b1
b1: ; preds = %entry, %b0
br label %exit
exit: ; preds = %entry, %b0, %b1
ret void
}
; CHECK-LABEL: @test_not_crash2
; CHECK-NEXT: entry:
; CHECK-NEXT: %0 = fcmp ult float %a
; CHECK-NEXT: %1 = fcmp ult float %b
; CHECK-NEXT: [[COND:%[a-z0-9]+]] = or i1 %0, %1
; CHECK-NEXT: br i1 [[COND]], label %bb4, label %bb3
; CHECK: bb3:
; CHECK-NEXT: br label %bb4
; CHECK: bb4:
; CHECK-NEXT: ret void
define void @test_not_crash2(float %a, float %b) #0 {
entry:
%0 = fcmp ult float %a, 1.000000e+00
br i1 %0, label %bb0, label %bb1
bb3: ; preds = %bb0
br label %bb4
bb4: ; preds = %bb0, %bb3
ret void
bb1: ; preds = %entry
br label %bb0
bb0: ; preds = %bb1, %entry
%1 = fcmp ult float %b, 1.000000e+00
br i1 %1, label %bb4, label %bb3
}
; CHECK-LABEL: @test_not_crash3
; CHECK-NEXT: entry:
; CHECK-NEXT: %a_eq_0 = icmp eq i32 %a, 0
; CHECK-NEXT: %a_eq_1 = icmp eq i32 %a, 1
; CHECK-NEXT: [[COND:%[a-z0-9]+]] = or i1 %a_eq_0, %a_eq_1
; CHECK-NEXT: br i1 [[COND]], label %bb2, label %bb3
; CHECK: bb2:
; CHECK-NEXT: br label %bb3
; CHECK: bb3:
; CHECK-NEXT: %check_badref = phi i32 [ 17, %entry ], [ 11, %bb2 ]
; CHECK-NEXT: ret void
define void @test_not_crash3(i32 %a) #0 {
entry:
%a_eq_0 = icmp eq i32 %a, 0
br i1 %a_eq_0, label %bb0, label %bb1
bb0: ; preds = %entry
br label %bb1
bb1: ; preds = %bb0, %entry
%a_eq_1 = icmp eq i32 %a, 1
br i1 %a_eq_1, label %bb2, label %bb3
bb2: ; preds = %bb1
br label %bb3
bb3: ; preds = %bb2, %bb1
%check_badref = phi i32 [ 17, %bb1 ], [ 11, %bb2 ]
ret void
}