c140810ea1
This changes the output of `llvm-readelf -n` from: ``` Displaying notes found at file offset 0x<...> with length 0x<...>: ``` to: ``` Displaying notes found in: .note.foo ``` And similarly, adds a `Name:` field to the `llvm-readobj -n` output for notes. This change not only increases GNU compatibility, it also makes it much easier to read notes. Note that we still fall back to printing the file offset/length in cases where we don't have a section name, such as when printing notes in program headers or printing notes in a partially stripped file (GNU readelf does the same). Fixes llvm.org/PR41339. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D75647
38 lines
1.3 KiB
Plaintext
38 lines
1.3 KiB
Plaintext
# Verify that --add-section can be used to add a note section which is
|
|
# successfully interpreted by tools that read notes.
|
|
|
|
# Add [namesz, descsz, type, name, desc] for a build id.
|
|
# RUN: echo -e -n "\x04\x00\x00\x00" > %t-note.bin
|
|
# RUN: echo -e -n "\x10\x00\x00\x00" >> %t-note.bin
|
|
# RUN: echo -e -n "\x03\x00\x00\x00" >> %t-note.bin
|
|
# RUN: echo -e -n "GNU\x00" >> %t-note.bin
|
|
# RUN: echo -e -n "\x00\x01\x02\x03" >> %t-note.bin
|
|
# RUN: echo -e -n "\x04\x05\x06\x07" >> %t-note.bin
|
|
# RUN: echo -e -n "\x08\x09\x0a\x0b" >> %t-note.bin
|
|
# RUN: echo -e -n "\x0c\x0d\x0e\x0f" >> %t-note.bin
|
|
|
|
# RUN: yaml2obj %s -o %t.o
|
|
# RUN: llvm-objcopy --add-section=.note.gnu.build-id=%t-note.bin %t.o %t-with-note.o
|
|
# RUN: llvm-readobj --notes %t-with-note.o | FileCheck %s
|
|
|
|
!ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_REL
|
|
Machine: EM_X86_64
|
|
|
|
# CHECK: Notes [
|
|
# CHECK-NEXT: NoteSection {
|
|
# CHECK-NEXT: Name: .note.gnu.build-id
|
|
# CHECK-NEXT: Offset:
|
|
# CHECK-NEXT: Size:
|
|
# CHECK-NEXT: Note {
|
|
# CHECK-NEXT: Owner: GNU
|
|
# CHECK-NEXT: Data size: 0x10
|
|
# CHECK-NEXT: Type: NT_GNU_BUILD_ID
|
|
# CHECK-NEXT: Build ID: 000102030405060708090a0b0c0d0e0f
|
|
# CHECK-NEXT: }
|
|
# CHECK-NEXT: }
|
|
# CHECK-NEXT: ]
|