479f992291
Currently, when the string shrink into the SSO buffer, the `__rep_.__s` member isn't activated before the `traits_type::copy` call yet, so internal `__builtin_memmove` call writing to the buffer causes constant evaluation failure. The existing test coverage seems a bit defective and doesn't cover this case - `shrink_to_fit` is called on the copy of string after erasure, not the original string object. This PR reorders the `__set_short_size` call, which starts the lifetime of the SSO buffer, before the copy operation. Test coverage is achieved by calling `shrink_to_fit` on the original erased string.
89 lines
2.1 KiB
C++
89 lines
2.1 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// <string>
|
|
|
|
// void shrink_to_fit(); // constexpr since C++20
|
|
|
|
#include <cassert>
|
|
#include <string>
|
|
|
|
#include "asan_testing.h"
|
|
#include "increasing_allocator.h"
|
|
#include "min_allocator.h"
|
|
#include "test_macros.h"
|
|
|
|
template <class S>
|
|
TEST_CONSTEXPR_CXX20 void test(S& s) {
|
|
typename S::size_type old_cap = s.capacity();
|
|
S s0 = s;
|
|
s.shrink_to_fit();
|
|
LIBCPP_ASSERT(s.__invariants());
|
|
assert(s == s0);
|
|
assert(s.capacity() <= old_cap);
|
|
assert(s.capacity() >= s.size());
|
|
LIBCPP_ASSERT(is_string_asan_correct(s));
|
|
}
|
|
|
|
template <class S>
|
|
TEST_CONSTEXPR_CXX20 void test_string() {
|
|
S s;
|
|
test(s);
|
|
|
|
s.assign(10, 'a');
|
|
s.erase(5);
|
|
test(s);
|
|
|
|
s.assign(50, 'a');
|
|
s.erase(5);
|
|
test(s);
|
|
|
|
s.assign(100, 'a');
|
|
s.erase(50);
|
|
test(s);
|
|
|
|
s.assign(100, 'a');
|
|
for (int i = 0; i <= 9; ++i) {
|
|
s.erase(90 - 10 * i);
|
|
test(s);
|
|
}
|
|
}
|
|
|
|
TEST_CONSTEXPR_CXX20 bool test() {
|
|
test_string<std::string>();
|
|
#if TEST_STD_VER >= 11
|
|
test_string<std::basic_string<char, std::char_traits<char>, min_allocator<char>>>();
|
|
test_string<std::basic_string<char, std::char_traits<char>, safe_allocator<char>>>();
|
|
#endif
|
|
|
|
#if TEST_STD_VER >= 23
|
|
{ // Make sure shrink_to_fit never increases capacity
|
|
// See: https://github.com/llvm/llvm-project/issues/95161
|
|
std::basic_string<char, std::char_traits<char>, increasing_allocator<char>> s{
|
|
"String does not fit in the internal buffer"};
|
|
std::size_t capacity = s.capacity();
|
|
std::size_t size = s.size();
|
|
s.shrink_to_fit();
|
|
assert(s.capacity() <= capacity);
|
|
assert(s.size() == size);
|
|
LIBCPP_ASSERT(is_string_asan_correct(s));
|
|
}
|
|
#endif
|
|
|
|
return true;
|
|
}
|
|
|
|
int main(int, char**) {
|
|
test();
|
|
#if TEST_STD_VER > 17
|
|
static_assert(test());
|
|
#endif
|
|
|
|
return 0;
|
|
}
|