Volodymyr Sapsai e32ff09685 [Preprocessor] Fix crash emitting note with framework location for "file not found" error. ...

A filename can be remapped with a header map to point to a framework
header and we can find the corresponding framework without the header.
But if the original filename doesn't have a remapped framework name,
we'll fail to find its location and will dereference a null pointer
during diagnostics emission.

Fix by tracking remappings better and emit the note only if a framework
is found before any of the remappings.

rdar://problem/48883447

Reviewers: arphaman, erik.pilkington, jkorous

Reviewed By: arphaman

Subscribers: dexonsmith, cfe-commits

Differential Revision: https://reviews.llvm.org/D61707

llvm-svn: 361779

2019-05-27 19:15:30 +00:00

..

Inputs

[Preprocessor] Fix crash emitting note with framework location for "file not found" error.

2019-05-27 19:15:30 +00:00

_Pragma-dependency2.c

…

_Pragma-dependency.c

Replace tok::angle_string_literal with new tok::header_name.

2019-03-19 22:09:55 +00:00

_Pragma-in-macro-arg.c

…

_Pragma-in-macro-arg.cpp

Remove use of lookahead from _Pragma handling and from all other

2019-04-11 21:18:22 +00:00

_Pragma-location.c

Add -fuse-line-directive flag to control usage of #line with -E

2015-02-26 00:17:25 +00:00

_Pragma-physloc.c

…

_Pragma.c

Improved error recovery for _Pragma

2015-07-30 21:30:00 +00:00

aarch64-target-features.c

[AArch64] Add support for MTE intrinsics

2019-04-26 21:08:11 +00:00

annotate_in_macro_arg.c

Lex: Don't call getIdentifierInfo on annotation tokens

2015-03-18 07:53:20 +00:00

arm-acle-6.4.c

[ARM] Prevent DSP and SIM32 being set for v6m

2018-09-28 10:18:02 +00:00

arm-acle-6.5.c

Avoid int to string conversion in Twine or raw_ostream contexts.

2017-12-28 16:58:54 +00:00

arm-pic-predefines.c

[ARM] Add pre-defined macros for ROPI and RWPI

2019-02-18 12:39:47 +00:00

arm-target-features.c

[ARM][CMSE] Add commandline option and feature macro

2019-05-21 14:21:26 +00:00

assembler-with-cpp.c

…

bigoutput.c

Adding a test for PR25717.

2016-01-27 02:18:28 +00:00

bpf-predefined-macros.c

[BPF] do not generate predefined macro bpf

2019-04-26 15:35:51 +00:00

builtin_line.c

…

c17.c

Add language standard aliases for -std=c18, -std=gnu18, and -std=iso9899:2018.

2018-10-18 17:42:41 +00:00

c90.c

…

c99-6_10_3_3_p4.c

…

c99-6_10_3_4_p5.c

…

c99-6_10_3_4_p6.c

…

c99-6_10_3_4_p7.c

…

c99-6_10_3_4_p9.c

…

clang_headers.c

…

comment_save_if.c

…

comment_save_macro.c

[Clang] Remove unwanted --check-prefix=CHECK from unit tests. NFC.

2016-04-20 01:02:18 +00:00

comment_save.c

…

cuda-approx-transcendentals.cu

[CUDA] Updated CUDA tests that must run w/o CUDA installation.

2016-08-02 23:43:04 +00:00

cuda-macos-includes.cu

[CUDA] Attempt to fix test failures in cuda-macos-includes.cu.

2016-11-18 01:11:32 +00:00

cuda-preprocess.cu

[CUDA] Updated CUDA tests that must run w/o CUDA installation.

2016-08-02 23:43:04 +00:00

cuda-types.cu

Revert 319303: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2

2018-01-15 21:16:25 +00:00

cxx_and.cpp

…

cxx_bitand.cpp

…

cxx_bitor.cpp

…

cxx_compl.cpp

…

cxx_not_eq.cpp

…

cxx_not.cpp

…

cxx_oper_keyword_ms_compat.cpp

Emit warning if define or undef reserved identifier or keyword.

2014-12-11 12:18:08 +00:00

cxx_oper_keyword.cpp

Keep the IdentifierInfo in the Token for alternative operator keyword

2017-07-14 09:23:40 +00:00

cxx_oper_spelling.cpp

…

cxx_or.cpp

…

cxx_true.cpp

Avoid false positive/negative test results from line directive interference.NFC.

2015-06-26 17:49:10 +00:00

cxx_xor.cpp

…

dependencies-and-pp.c

Fix PR31644 introduced by r287138 and add a regression test.

2017-01-14 21:12:08 +00:00

directive-invalid.c

…

disabled-cond-diags2.c

…

disabled-cond-diags.c

…

dump_import.h

[Preprocessor] Support for '-dI' flag

2016-11-17 22:45:31 +00:00

dump_import.m

[Preprocessor] Support for '-dI' flag

2016-11-17 22:45:31 +00:00

dump_include.c

[Preprocessor] Support for '-dI' flag

2016-11-17 22:45:31 +00:00

dump_include.h

[Preprocessor] Support for '-dI' flag

2016-11-17 22:45:31 +00:00

dump_macros.c

…

dump-macros-spacing.c

…

dump-macros-undef.c

…

dump-options.c

…

dumptokens_phyloc.c

…

elfiamcu-predefines.c

[x86] Correct setting of WIntType for MCU target

2016-02-04 11:54:45 +00:00

empty_file_to_include.h

Diagnose likely typos in #include directives.

2018-09-13 21:10:08 +00:00

expr_comma.c

…

expr_define_expansion.c

Add -Wexpansion-to-undefined: warn when using defined in a macro definition.

2016-01-19 15:15:31 +00:00

expr_invalid_tok.c

Improve diagnostic for the case when a non-defined function-like macro is used

2016-04-16 00:07:09 +00:00

expr_liveness.c

…

expr_multichar.c

…

expr_usual_conversions.c

…

extension-warning.c

…

feature_tests.c

[Clang] Add __builtin_launder

2018-12-14 21:11:28 +00:00

file_name_macro.c

Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro"

2019-05-16 21:13:49 +00:00

file_to_include.h

…

first-line-indent.c

…

function_macro_file.c

…

function_macro_file.h

…

has_attribute.c

Improve diagnostic for the case when a non-defined function-like macro is used

2016-04-16 00:07:09 +00:00

has_attribute.cpp

Introduce the _Clang scoped attribute token.

2018-11-09 17:19:45 +00:00

has_c_attribute.c

Correct line endings that got mixed up in r320088; NFC.

2017-12-07 23:10:09 +00:00

has_include.c

Factor out repeated code parsing and concatenating header-names from

2019-03-19 01:51:19 +00:00

hash_line.c

…

hash_space.c

…

header_is_main_file.c

Do not print include_next/pragma once warnings when input is a header.

2016-10-27 14:17:10 +00:00

header_lookup1.c

Move a bunch of tests to directly use the CC1 layer. This at least saves

2014-01-15 09:08:07 +00:00

headermap-rel2.c

[hmaptool] Turn %hmaptool into a proper substitution

2018-06-22 09:46:40 +00:00

headermap-rel.c

[hmaptool] Turn %hmaptool into a proper substitution

2018-06-22 09:46:40 +00:00

hexagon-predefines.c

[Hexagon] Add support for Hexagon V66

2018-12-05 21:38:35 +00:00

if_warning.c

…

ifdef-recover.c

Preprocessor: support defined() with operator names for MS compatibility

2014-05-21 06:13:51 +00:00

ignore-pragmas.c

Revert 320391: Certain targets are failing, pulling back to diagnose.

2017-12-11 18:14:51 +00:00

import_self.c

…

include-cycle.c

[Preprocessor] Stop entering included files after hitting a fatal error.

2018-07-25 19:16:26 +00:00

include-directive1.c

…

include-directive2.c

…

include-directive3.c

…

include-header-missing-in-framework-with-headermap.c

[Preprocessor] Fix crash emitting note with framework location for "file not found" error.

2019-05-27 19:15:30 +00:00

include-header-missing-in-framework.c

[Preprocessor] Add a note with framework location for "file not found" error.

2019-02-05 22:34:55 +00:00

include-leading-nonalpha-no-suggest.c

Add testcases for r342667.

2018-09-20 17:22:43 +00:00

include-likely-typo.c

[MSVC Compat] Fix typo correction for inclusion directives.

2019-01-15 20:08:23 +00:00

include-macros.c

…

include-next.c

Improve the diagnostic for #include_next occurring in a file not found

2019-03-21 20:42:13 +00:00

include-nonalpha-no-crash.c

[Preprocessor] Fix a crash when handling non-alpha include header.

2018-10-01 14:38:43 +00:00

indent_macro.c

Fixed tests where grep was not matching the linefeed

2019-05-10 20:11:36 +00:00

init-v7k-compat.c

ARMv7k: implement ABI changes for watchOS from standard iOS.

2015-10-30 16:30:45 +00:00

init.c

Add AIX Version Macros

2019-05-16 14:22:37 +00:00

invalid-__has_warning1.c

Consolidate and improve the handling of built-in feature-like macros

2016-04-05 08:36:47 +00:00

invalid-__has_warning2.c

Consolidate and improve the handling of built-in feature-like macros

2016-04-05 08:36:47 +00:00

is_target_arm64.c

__is_target_arch: Check the arch and subarch instead of the arch name

2017-12-15 19:58:38 +00:00

is_target_arm.c

Commit missing tests for r320734

2017-12-14 19:22:41 +00:00

is_target_environment_version.c

__is_target_environment: Check the environment after parsing it

2017-12-15 20:07:53 +00:00

is_target_os_darwin.c

Commit missing tests for r320734

2017-12-14 19:22:41 +00:00

is_target_unknown.c

Commit missing tests for r320734

2017-12-14 19:22:41 +00:00

is_target.c

Commit missing tests for r320734

2017-12-14 19:22:41 +00:00

iwithprefix.c

[multilib] Teach Clang's code about multilib by threading

2014-12-29 12:09:08 +00:00

line-directive-output.c

Add test coverage for recent behavior change in GNU line marker pre-processing

2017-05-23 16:09:13 +00:00

line-directive.c

Switch C compilations to C11 by default.

2014-10-20 23:26:58 +00:00

macho-embedded-predefines.c

ARM: Correctly identify cortex-m4 as v7em.

2014-06-26 17:24:16 +00:00

macro_arg_directive.c

Print a note to the called macro when diagnosing err_embedded_directive

2019-02-14 04:13:17 +00:00

macro_arg_directive.h

…

macro_arg_empty.c

Fix whitespace handling in empty macro arguments

2014-02-04 19:18:32 +00:00

macro_arg_keyword.c

…

macro_arg_slocentry_merge.c

Stop printing macro backtraces that don't help diagnostics.

2015-08-12 18:24:59 +00:00

macro_arg_slocentry_merge.h

…

macro_backslash.c

…

macro_disable.c

…

macro_expand_empty.c

If preprocessing results in a token with leading whitespace that was expanded

2014-02-24 20:50:36 +00:00

macro_expand.c

Fixed preprocessed output of the first token for pragmas.

2016-02-09 08:51:26 +00:00

macro_expandloc.c

…

macro_fn_comma_swallow2.c

…

macro_fn_comma_swallow.c

…

macro_fn_disable_expand.c

…

macro_fn_lparen_scan2.c

…

macro_fn_lparen_scan.c

…

macro_fn_placemarker.c

…

macro_fn_preexpand.c

…

macro_fn_varargs_iso.c

…

macro_fn_varargs_named.c

Fixed tests where grep was not matching the linefeed

2019-05-10 20:11:36 +00:00

macro_fn.c

…

macro_misc.c

…

macro_not_define.c

Fixed tests where grep was not matching the linefeed

2019-05-10 20:11:36 +00:00

macro_paste_bad.c

Lex: Fix an invalid access into a SmallString

2014-10-25 11:40:40 +00:00

macro_paste_bcpl_comment.c

…

macro_paste_c_block_comment.c

…

macro_paste_commaext.c

Fix typos in clang

2018-04-06 15:14:32 +00:00

macro_paste_empty.c

…

macro_paste_hard.c

…

macro_paste_hashhash.c

…

macro_paste_identifier_error.c

…

macro_paste_msextensions.c

Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode.

2015-12-29 23:06:17 +00:00

macro_paste_none.c

…

macro_paste_simple.c

…

macro_paste_spacing2.c

…

macro_paste_spacing.c

Fix whitespace handling in ## operator

2014-02-04 19:18:28 +00:00

macro_raw_string.cpp

Stringizing raw string literals containing newline

2017-12-06 17:00:53 +00:00

macro_redefined.c

Put macro redefinition warnings under -Wmacro-redefined

2014-04-04 00:17:16 +00:00

macro_rescan2.c

…

macro_rescan_varargs.c

…

macro_rescan.c

…

macro_rparen_scan2.c

…

macro_rparen_scan.c

Fixed tests where grep was not matching the linefeed

2019-05-10 20:11:36 +00:00

macro_space.c

Fix whitespace handling in empty macro expansions

2014-02-04 19:18:35 +00:00

macro_undef.c

…

macro_vaopt_check.cpp

[c++2a] Implement P0306 __VA_OPT__ (Comma omission and comma deletion)

2017-10-15 01:26:26 +00:00

macro_vaopt_expand.cpp

[c++20] Implement tweaked __VA_OPT__ rules from P1042R1:

2019-05-04 06:46:18 +00:00

macro_vaopt_p1042r1.cpp

[c++20] Implement tweaked __VA_OPT__ rules from P1042R1:

2019-05-04 06:46:18 +00:00

macro_variadic.cl

[OpenCL] Allow variadic macros as Clang feature.

2019-03-26 11:22:37 +00:00

macro_with_initializer_list.cpp

…

macro-multiline.c

Use backslash escape, replacing xargs -0 in test macro-multiline.c

2018-01-04 22:58:30 +00:00

macro-reserved-cxx11.cpp

[Tests] Add explicit -std=lang option to a number of tests.

2015-08-01 02:55:59 +00:00

macro-reserved-ms.c

Fixed warnings on redefine keywords and reserved ids.

2014-12-18 11:14:21 +00:00

macro-reserved.c

Fixed warnings on redefine keywords and reserved ids.

2014-12-18 11:14:21 +00:00

macro-reserved.cpp

[Tests] Add explicit -std=lang option to a number of tests.

2015-08-01 02:55:59 +00:00

mi_opt2.c

…

mi_opt2.h

…

mi_opt.c

…

mi_opt.h

…

microsoft-ext.c

[MSVC Compat] Accept elided commas in macro function arguments

2016-01-22 19:26:44 +00:00

microsoft-header-search.c

Rename -Wmsvc-include to -Wmicrosoft-include, now that -Wmicrosoft is split up.

2015-07-28 16:48:12 +00:00

microsoft-import.c

…

missing-include-range-check.h

Include full filename range for missing includes

2016-10-25 10:13:10 +00:00

missing-system-header.c

…

missing-system-header.h

…

mmx.c

…

non_fragile_feature1.m

…

non_fragile_feature.m

…

nonportable-include-with-hmap.c

[hmaptool] Turn %hmaptool into a proper substitution

2018-06-22 09:46:40 +00:00

objc-pp.m

…

openmp-macro-expansion.c

According to the OpenMP spec, all the preprocessor macros should be

2015-06-15 23:44:27 +00:00

optimize.c

…

output_paste_avoid.cpp

…

overflow.c

…

pic.c

Restructure the propagation of -fPIC/-fPIE.

2016-06-23 15:07:32 +00:00

pp-modules.c

Add pragma to perform module import and use it in -E output.

2017-04-29 00:34:47 +00:00

pp-modules.h

…

pp-record.c

…

pp-record.h

…

pr2086.c

…

pr2086.h

…

pr13851.c

…

pr19649-signed-wchar_t.c

Commit patch for PR19649. Set the correct sign of wide character for literals based on underlying type of wchar_t.

2015-02-24 13:34:20 +00:00

pr19649-unsigned-wchar_t.c

Driver: hoist the wchar_t handling to the driver

2017-10-06 23:09:55 +00:00

pragma_assume_nonnull.c

[Preprocessor] Preserve #pragma clang assume_nonnull in preprocessed output

2017-09-27 23:29:37 +00:00

pragma_diagnostic_output.c

…

pragma_diagnostic_sections.cpp

…

pragma_diagnostic.c

Use the -Wunknown-warning-option group for the "unknown warning group"

2017-04-28 14:45:25 +00:00

pragma_microsoft.c

Replace lit feature keyword 'non-ms-sdk' with 'ms-sdk'; eliminate

2019-05-10 13:40:17 +00:00

pragma_microsoft.cpp

…

pragma_module.c

Permit keywords in module names in #pragma clang module *.

2017-05-05 22:34:07 +00:00

pragma_poison.c

…

pragma_ps4.c

Adds a warning for unrecognized argument to #pragma comment() on PS4.

2015-03-23 20:41:42 +00:00

pragma_sysheader.c

…

pragma_sysheader.h

…

pragma_unknown.c

Preserve unknown STDC pragma through preprocessor

2018-01-05 22:45:03 +00:00

pragma-captured.c

…

pragma-comment-linux.c

Support #pragma comment(lib, "name") in the frontend for ELF

2018-02-07 01:46:46 +00:00

pragma-pushpop-macro.c

…

pragma.c

Fix combining pragma __debug dump & parser_crash with -E

2018-11-15 03:04:21 +00:00

predefined-arch-macros.c

[X86] Add 'yonah' test to predefined-arch-macros.c test.

2019-03-13 05:14:50 +00:00

predefined-exceptions.m

Frontend: Define __EXCEPTIONS if -fexceptions is passed

2014-10-27 20:02:19 +00:00

predefined-macros.c

Revert the tests that should've been reverted in rL341115

2018-08-30 20:53:15 +00:00

predefined-nullability.c

Add __nonnull/__nullable/__null_unspecified predefines for Darwin.

2015-06-24 22:02:16 +00:00

predefined-win-macros.c

[X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

2019-03-21 20:36:08 +00:00

print_line_count.c

…

print_line_empty_file.c

…

print_line_include.c

…

print_line_include.h

…

print_line_track.c

…

print-assembler.s

Don't print end-of-directive tokens in -E output

2017-10-16 23:07:15 +00:00

print-pragma-microsoft.c

Expand macros in pragmas with -fms-extensions and -E

2014-02-20 22:59:51 +00:00

pushable-diagnostics.c

Accept "-Weverything" in clang diagnistic pragmas

2016-02-13 01:44:05 +00:00

riscv-target-features.c

[PATCH] [RISCV] Extend getTargetDefines for RISCVTargetInfo

2018-04-05 12:54:00 +00:00

skipping_unclean.c

…

stdint.c

By popular demand, switch in64_t on NetBSD/AArch64 and NetBSD/PowerPC64

2018-07-17 12:33:19 +00:00

stringize_misc.c

Diagnose missing macro argument following charize operator.

2016-04-01 19:02:20 +00:00

stringize_space.c

Fix whitespace before token-paste of an argument.

2017-05-04 21:31:17 +00:00

sycl-macro.cpp

[SYCL] Add clang front-end option to enable SYCL device compilation flow.

2019-02-25 11:48:48 +00:00

sysroot-prefix.c

Fix sysroot-prefix.c on Windows (/ vs \).

2016-05-06 21:17:32 +00:00

traditional-cpp.c

Fix CHECK directives that weren't checking.

2015-08-31 21:48:52 +00:00

ucn-allowed-chars.c

Fix the range for Malayam UCNs in C99.

2014-02-05 15:32:23 +00:00

ucn-pp-identifier.c

Preprocessor: support defined() with operator names for MS compatibility

2014-05-21 06:13:51 +00:00

undef-error.c

…

unterminated.c

…

user_defined_system_framework.c

…

utf8-allowed-chars.c

…

warn-disabled-macro-expansion.c

…

warn-macro-unused.c

…

warn-macro-unused.h

…

warning_tests.c

Consolidate and improve the handling of built-in feature-like macros

2016-04-05 08:36:47 +00:00

wasm-target-features.c

[WebAssembly] Add multivalue and tail-call target features

2019-05-23 17:26:47 +00:00

wchar_t.c

Driver: hoist the wchar_t handling to the driver

2017-10-06 23:09:55 +00:00

Weverything_pragma.c

Accept "-Weverything" in clang diagnistic pragmas

2016-02-13 01:44:05 +00:00

woa-defaults.c

Basic: correct __WINT_TYPE__ on Windows

2018-09-19 16:18:55 +00:00

woa-wchar_t.c

Target: fix wchar_t definition for Windows on ARM

2014-05-04 01:56:04 +00:00

x86_asm_flag_output.c

[X86] Add clang support for X86 flag output parameters.

2019-02-14 19:27:25 +00:00

x86_target_features.c

[X86] Stop implicitly enabling avx512vl when avx512bf16 is enabled.

2019-05-16 18:28:17 +00:00