e3d14bee23
Discovered by reducing a different problem, we currently assert because we failed to make the constraint expressions not dependent, since a RecoveryExpr cannot be transformed. This patch fixes that, and gets reasonably nice diagnostics by introducing a concept (hah!) of "ContainsErrors" to the Satisfaction types, which causes us to treat the candidate as non-viable. However, just making THAT candidate non-viable would result in choosing the 'next best' canddiate, which can result in awkward errors, where we start evaluating a candidate that is not intended to be selected. Because of this, and to make diagnostics more relevant, we now just cause the entire lookup to result in a 'no-viable-candidates'. This means we will only emit the list of candidates, rather than any cascading failures.
68 lines
2.8 KiB
C++
68 lines
2.8 KiB
C++
//===--- ASTConcept.cpp - Concepts Related AST Data Structures --*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
///
|
|
/// \file
|
|
/// \brief This file defines AST data structures related to concepts.
|
|
///
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/AST/ASTConcept.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/AST/Decl.h"
|
|
#include "clang/AST/TemplateBase.h"
|
|
#include "llvm/ADT/ArrayRef.h"
|
|
#include "llvm/ADT/FoldingSet.h"
|
|
using namespace clang;
|
|
|
|
ASTConstraintSatisfaction::ASTConstraintSatisfaction(
|
|
const ASTContext &C, const ConstraintSatisfaction &Satisfaction)
|
|
: NumRecords{Satisfaction.Details.size()},
|
|
IsSatisfied{Satisfaction.IsSatisfied}, ContainsErrors{
|
|
Satisfaction.ContainsErrors} {
|
|
for (unsigned I = 0; I < NumRecords; ++I) {
|
|
auto &Detail = Satisfaction.Details[I];
|
|
if (Detail.second.is<Expr *>())
|
|
new (getTrailingObjects<UnsatisfiedConstraintRecord>() + I)
|
|
UnsatisfiedConstraintRecord{Detail.first,
|
|
UnsatisfiedConstraintRecord::second_type(
|
|
Detail.second.get<Expr *>())};
|
|
else {
|
|
auto &SubstitutionDiagnostic =
|
|
*Detail.second.get<std::pair<SourceLocation, StringRef> *>();
|
|
unsigned MessageSize = SubstitutionDiagnostic.second.size();
|
|
char *Mem = new (C) char[MessageSize];
|
|
memcpy(Mem, SubstitutionDiagnostic.second.data(), MessageSize);
|
|
auto *NewSubstDiag = new (C) std::pair<SourceLocation, StringRef>(
|
|
SubstitutionDiagnostic.first, StringRef(Mem, MessageSize));
|
|
new (getTrailingObjects<UnsatisfiedConstraintRecord>() + I)
|
|
UnsatisfiedConstraintRecord{Detail.first,
|
|
UnsatisfiedConstraintRecord::second_type(
|
|
NewSubstDiag)};
|
|
}
|
|
}
|
|
}
|
|
|
|
ASTConstraintSatisfaction *
|
|
ASTConstraintSatisfaction::Create(const ASTContext &C,
|
|
const ConstraintSatisfaction &Satisfaction) {
|
|
std::size_t size =
|
|
totalSizeToAlloc<UnsatisfiedConstraintRecord>(
|
|
Satisfaction.Details.size());
|
|
void *Mem = C.Allocate(size, alignof(ASTConstraintSatisfaction));
|
|
return new (Mem) ASTConstraintSatisfaction(C, Satisfaction);
|
|
}
|
|
|
|
void ConstraintSatisfaction::Profile(
|
|
llvm::FoldingSetNodeID &ID, const ASTContext &C,
|
|
const NamedDecl *ConstraintOwner, ArrayRef<TemplateArgument> TemplateArgs) {
|
|
ID.AddPointer(ConstraintOwner);
|
|
ID.AddInteger(TemplateArgs.size());
|
|
for (auto &Arg : TemplateArgs)
|
|
Arg.Profile(ID, C);
|
|
}
|