75e164f61d
The cleanup was manual, but assisted by "include-what-you-use". It consists in 1. Removing unused forward declaration. No impact expected. 2. Removing unused headers in .cpp files. No impact expected. 3. Removing unused headers in .h files. This removes implicit dependencies and is generally considered a good thing, but this may break downstream builds. I've updated llvm, clang, lld, lldb and mlir deps, and included a list of the modification in the second part of the commit. 4. Replacing header inclusion by forward declaration. This has the same impact as 3. Notable changes: - llvm/Support/TargetParser.h no longer includes llvm/Support/AArch64TargetParser.h nor llvm/Support/ARMTargetParser.h - llvm/Support/TypeSize.h no longer includes llvm/Support/WithColor.h - llvm/Support/YAMLTraits.h no longer includes llvm/Support/Regex.h - llvm/ADT/SmallVector.h no longer includes llvm/Support/MemAlloc.h nor llvm/Support/ErrorHandling.h You may need to add some of these headers in your compilation units, if needs be. As an hint to the impact of the cleanup, running clang++ -E -Iinclude -I../llvm/include ../llvm/lib/Support/*.cpp -std=c++14 -fno-rtti -fno-exceptions | wc -l before: 8000919 lines after: 7917500 lines Reduced dependencies also helps incremental rebuilds and is more ccache friendly, something not shown by the above metric :-) Discourse thread on the topic: https://llvm.discourse.group/t/include-what-you-use-include-cleanup/5831
60 lines
1.8 KiB
C++
60 lines
1.8 KiB
C++
//===--- ToolOutputFile.cpp - Implement the ToolOutputFile class --------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This implements the ToolOutputFile class.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Support/ToolOutputFile.h"
|
|
#include "llvm/Support/FileSystem.h"
|
|
#include "llvm/Support/Signals.h"
|
|
using namespace llvm;
|
|
|
|
static bool isStdout(StringRef Filename) { return Filename == "-"; }
|
|
|
|
ToolOutputFile::CleanupInstaller::CleanupInstaller(StringRef Filename)
|
|
: Filename(std::string(Filename)), Keep(false) {
|
|
// Arrange for the file to be deleted if the process is killed.
|
|
if (!isStdout(Filename))
|
|
sys::RemoveFileOnSignal(Filename);
|
|
}
|
|
|
|
ToolOutputFile::CleanupInstaller::~CleanupInstaller() {
|
|
if (isStdout(Filename))
|
|
return;
|
|
|
|
// Delete the file if the client hasn't told us not to.
|
|
if (!Keep)
|
|
sys::fs::remove(Filename);
|
|
|
|
// Ok, the file is successfully written and closed, or deleted. There's no
|
|
// further need to clean it up on signals.
|
|
sys::DontRemoveFileOnSignal(Filename);
|
|
}
|
|
|
|
ToolOutputFile::ToolOutputFile(StringRef Filename, std::error_code &EC,
|
|
sys::fs::OpenFlags Flags)
|
|
: Installer(Filename) {
|
|
if (isStdout(Filename)) {
|
|
OS = &outs();
|
|
EC = std::error_code();
|
|
return;
|
|
}
|
|
OSHolder.emplace(Filename, EC, Flags);
|
|
OS = OSHolder.getPointer();
|
|
// If open fails, no cleanup is needed.
|
|
if (EC)
|
|
Installer.Keep = true;
|
|
}
|
|
|
|
ToolOutputFile::ToolOutputFile(StringRef Filename, int FD)
|
|
: Installer(Filename) {
|
|
OSHolder.emplace(FD, true);
|
|
OS = OSHolder.getPointer();
|
|
}
|