e987ab11a6
Instead of relying on any pass manager to schedule Polly's passes, add Polly's own pipeline manager which is seen as a monolithic pass in LLVM's pass manager. Polly's former passes are now phases of the new PhaseManager component. Relying on LLVM's pass manager (the legacy as well as the New Pass Manager) to manage Polly's phases never was a good fit that the PhaseManager resolves: * Polly passes were modifying analysis results, in particular RegionInfo and ScopInfo. This means that there was not just one unique and "definite" analysis result, the actual result depended on which analyses ran prior, and the pass manager was not allowed to throw away cached analyses or prior SCoP optimizations would have been forgotten. The LLVM pass manger's persistance of analysis results is not contractual but designed for caching. * Polly depends on a particular execution order of passes and regions (e.g. regression tests, invalidation of consecutive SCoPs). LLVM's pass manager does not guarantee any excecution order. * Polly does not completely preserve DominatorTree, RegionInfo, LoopInfo, or ScalarEvolution, but only as-needed for Polly's own uses. Because the ScopDetection object stores references to those analyses, it still had to lie to the pass manager that they would be preserved, or the pass manager would have released and recomputed the invalidated analysis objects that ScopDetection/ScopInfo was still referencing. To ensure that no non-Polly pass would see these not-completely-preserved analyses, all analyses still had to be thrown away after the ScopPassManager, respectively with a BarrierNoopPass in case of the LPM. * The NPM's PassInstrumentation wraps the IR unit into an `llvm::Any` object, but implementations such as PrintIRInstrumentation call llvm_unreachable on encountering an unknown IR unit, such as SCoPs, with no extension points to add support. Hence LLVM crashes when dumping IR between SCoP passes (such as `-print-before-changed` with Polly being active). The new PhaseManager uses some command line options that previously belonged to Polly's legacy passes, such as `-polly-print-detect` (so the option will continue to work). Hence the LPM support is incompatible with the new approach and support for it is removed.
61 lines
2.2 KiB
C++
61 lines
2.2 KiB
C++
//===---- CodePreparation.cpp - Code preparation for Scop Detection -------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// The Polly code preparation pass is executed before SCoP detection. Its
|
|
// currently only splits the entry block of the SCoP to make room for alloc
|
|
// instructions as they are generated during code generation.
|
|
//
|
|
// XXX: In the future, we should remove the need for this pass entirely and
|
|
// instead add this spitting to the code generation pass.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "polly/CodePreparation.h"
|
|
#include "polly/Support/ScopHelper.h"
|
|
#include "llvm/Analysis/DominanceFrontier.h"
|
|
#include "llvm/Analysis/LoopInfo.h"
|
|
#include "llvm/Analysis/RegionInfo.h"
|
|
#include "llvm/Analysis/ScalarEvolution.h"
|
|
|
|
using namespace llvm;
|
|
using namespace polly;
|
|
|
|
static bool runCodePreprationImpl(Function &F, DominatorTree *DT, LoopInfo *LI,
|
|
RegionInfo *RI) {
|
|
// Find first non-alloca instruction. Every basic block has a non-alloca
|
|
// instruction, as every well formed basic block has a terminator.
|
|
auto &EntryBlock = F.getEntryBlock();
|
|
BasicBlock::iterator I = EntryBlock.begin();
|
|
while (isa<AllocaInst>(I))
|
|
++I;
|
|
|
|
// Abort if not necessary to split
|
|
if (I->isTerminator() && isa<BranchInst>(I) &&
|
|
cast<BranchInst>(I)->isUnconditional())
|
|
return false;
|
|
|
|
// splitBlock updates DT, LI and RI.
|
|
splitEntryBlockForAlloca(&EntryBlock, DT, LI, RI);
|
|
|
|
return true;
|
|
}
|
|
|
|
PreservedAnalyses CodePreparationPass::run(Function &F,
|
|
FunctionAnalysisManager &FAM) {
|
|
auto &DT = FAM.getResult<DominatorTreeAnalysis>(F);
|
|
auto &LI = FAM.getResult<LoopAnalysis>(F);
|
|
bool Changed = runCodePreprationImpl(F, &DT, &LI, nullptr);
|
|
if (!Changed)
|
|
return PreservedAnalyses::all();
|
|
|
|
PreservedAnalyses PA;
|
|
PA.preserve<DominatorTreeAnalysis>();
|
|
PA.preserve<LoopAnalysis>();
|
|
return PA;
|
|
}
|