
@kadircet mentioned in
448d8fa880 (diff-fb3ba8a781117ff04736f951a274812cb7ad1678f9d71d4d91870b711ab45da0L285)
that:
> this is definitely a functional change, clangd is used in environments
that solely relies on VFS, and doesn't depend on ASTUnit at all.
> right now this is both introducing a dependency on ASTUnit, and making
all the logical IO physical instead. can you instead use the regular
compiler utilities in clangd, and get the astreader from
CompilerInstance directly, which is VFS-aware, and doesn't depend on
ASTUnit ?
This tries to resolve the problem by creating ASTReader directly and use
VFS to create the FileManager.
374 lines
14 KiB
C++
374 lines
14 KiB
C++
//===----------------- ModulesBuilder.cpp ------------------------*- C++-*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ModulesBuilder.h"
|
|
#include "Compiler.h"
|
|
#include "support/Logger.h"
|
|
#include "clang/Frontend/FrontendAction.h"
|
|
#include "clang/Frontend/FrontendActions.h"
|
|
#include "clang/Serialization/ASTReader.h"
|
|
#include "clang/Serialization/InMemoryModuleCache.h"
|
|
|
|
namespace clang {
|
|
namespace clangd {
|
|
|
|
namespace {
|
|
|
|
// Create a path to store module files. Generally it should be:
|
|
//
|
|
// {TEMP_DIRS}/clangd/module_files/{hashed-file-name}-%%-%%-%%-%%-%%-%%/.
|
|
//
|
|
// {TEMP_DIRS} is the temporary directory for the system, e.g., "/var/tmp"
|
|
// or "C:/TEMP".
|
|
//
|
|
// '%%' means random value to make the generated path unique.
|
|
//
|
|
// \param MainFile is used to get the root of the project from global
|
|
// compilation database.
|
|
//
|
|
// TODO: Move these module fils out of the temporary directory if the module
|
|
// files are persistent.
|
|
llvm::SmallString<256> getUniqueModuleFilesPath(PathRef MainFile) {
|
|
llvm::SmallString<128> HashedPrefix = llvm::sys::path::filename(MainFile);
|
|
// There might be multiple files with the same name in a project. So appending
|
|
// the hash value of the full path to make sure they won't conflict.
|
|
HashedPrefix += std::to_string(llvm::hash_value(MainFile));
|
|
|
|
llvm::SmallString<256> ResultPattern;
|
|
|
|
llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true,
|
|
ResultPattern);
|
|
|
|
llvm::sys::path::append(ResultPattern, "clangd");
|
|
llvm::sys::path::append(ResultPattern, "module_files");
|
|
|
|
llvm::sys::path::append(ResultPattern, HashedPrefix);
|
|
|
|
ResultPattern.append("-%%-%%-%%-%%-%%-%%");
|
|
|
|
llvm::SmallString<256> Result;
|
|
llvm::sys::fs::createUniquePath(ResultPattern, Result,
|
|
/*MakeAbsolute=*/false);
|
|
|
|
llvm::sys::fs::create_directories(Result);
|
|
return Result;
|
|
}
|
|
|
|
// Get a unique module file path under \param ModuleFilesPrefix.
|
|
std::string getModuleFilePath(llvm::StringRef ModuleName,
|
|
PathRef ModuleFilesPrefix) {
|
|
llvm::SmallString<256> ModuleFilePath(ModuleFilesPrefix);
|
|
auto [PrimaryModuleName, PartitionName] = ModuleName.split(':');
|
|
llvm::sys::path::append(ModuleFilePath, PrimaryModuleName);
|
|
if (!PartitionName.empty()) {
|
|
ModuleFilePath.append("-");
|
|
ModuleFilePath.append(PartitionName);
|
|
}
|
|
|
|
ModuleFilePath.append(".pcm");
|
|
return std::string(ModuleFilePath);
|
|
}
|
|
|
|
// FailedPrerequisiteModules - stands for the PrerequisiteModules which has
|
|
// errors happened during the building process.
|
|
class FailedPrerequisiteModules : public PrerequisiteModules {
|
|
public:
|
|
~FailedPrerequisiteModules() override = default;
|
|
|
|
// We shouldn't adjust the compilation commands based on
|
|
// FailedPrerequisiteModules.
|
|
void adjustHeaderSearchOptions(HeaderSearchOptions &Options) const override {
|
|
}
|
|
|
|
// FailedPrerequisiteModules can never be reused.
|
|
bool
|
|
canReuse(const CompilerInvocation &CI,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>) const override {
|
|
return false;
|
|
}
|
|
};
|
|
|
|
struct ModuleFile {
|
|
ModuleFile(StringRef ModuleName, PathRef ModuleFilePath)
|
|
: ModuleName(ModuleName.str()), ModuleFilePath(ModuleFilePath.str()) {}
|
|
|
|
ModuleFile() = delete;
|
|
|
|
ModuleFile(const ModuleFile &) = delete;
|
|
ModuleFile operator=(const ModuleFile &) = delete;
|
|
|
|
// The move constructor is needed for llvm::SmallVector.
|
|
ModuleFile(ModuleFile &&Other)
|
|
: ModuleName(std::move(Other.ModuleName)),
|
|
ModuleFilePath(std::move(Other.ModuleFilePath)) {
|
|
Other.ModuleName.clear();
|
|
Other.ModuleFilePath.clear();
|
|
}
|
|
|
|
ModuleFile &operator=(ModuleFile &&Other) {
|
|
if (this == &Other)
|
|
return *this;
|
|
|
|
this->~ModuleFile();
|
|
new (this) ModuleFile(std::move(Other));
|
|
return *this;
|
|
}
|
|
|
|
~ModuleFile() {
|
|
if (!ModuleFilePath.empty())
|
|
llvm::sys::fs::remove(ModuleFilePath);
|
|
}
|
|
|
|
std::string ModuleName;
|
|
std::string ModuleFilePath;
|
|
};
|
|
|
|
bool IsModuleFileUpToDate(PathRef ModuleFilePath,
|
|
const PrerequisiteModules &RequisiteModules,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS) {
|
|
auto HSOpts = std::make_shared<HeaderSearchOptions>();
|
|
RequisiteModules.adjustHeaderSearchOptions(*HSOpts);
|
|
HSOpts->ForceCheckCXX20ModulesInputFiles = true;
|
|
HSOpts->ValidateASTInputFilesContent = true;
|
|
|
|
clang::clangd::IgnoreDiagnostics IgnoreDiags;
|
|
IntrusiveRefCntPtr<DiagnosticsEngine> Diags =
|
|
CompilerInstance::createDiagnostics(new DiagnosticOptions, &IgnoreDiags,
|
|
/*ShouldOwnClient=*/false);
|
|
|
|
LangOptions LangOpts;
|
|
LangOpts.SkipODRCheckInGMF = true;
|
|
|
|
FileManager FileMgr(FileSystemOptions(), VFS);
|
|
|
|
SourceManager SourceMgr(*Diags, FileMgr);
|
|
|
|
HeaderSearch HeaderInfo(HSOpts, SourceMgr, *Diags, LangOpts,
|
|
/*Target=*/nullptr);
|
|
|
|
TrivialModuleLoader ModuleLoader;
|
|
Preprocessor PP(std::make_shared<PreprocessorOptions>(), *Diags, LangOpts,
|
|
SourceMgr, HeaderInfo, ModuleLoader);
|
|
|
|
IntrusiveRefCntPtr<InMemoryModuleCache> ModuleCache = new InMemoryModuleCache;
|
|
PCHContainerOperations PCHOperations;
|
|
ASTReader Reader(PP, *ModuleCache, /*ASTContext=*/nullptr,
|
|
PCHOperations.getRawReader(), {});
|
|
|
|
// We don't need any listener here. By default it will use a validator
|
|
// listener.
|
|
Reader.setListener(nullptr);
|
|
|
|
if (Reader.ReadAST(ModuleFilePath, serialization::MK_MainFile,
|
|
SourceLocation(),
|
|
ASTReader::ARR_None) != ASTReader::Success)
|
|
return false;
|
|
|
|
bool UpToDate = true;
|
|
Reader.getModuleManager().visit([&](serialization::ModuleFile &MF) -> bool {
|
|
Reader.visitInputFiles(
|
|
MF, /*IncludeSystem=*/false, /*Complain=*/false,
|
|
[&](const serialization::InputFile &IF, bool isSystem) {
|
|
if (!IF.getFile() || IF.isOutOfDate())
|
|
UpToDate = false;
|
|
});
|
|
return !UpToDate;
|
|
});
|
|
return UpToDate;
|
|
}
|
|
|
|
bool IsModuleFilesUpToDate(
|
|
llvm::SmallVector<PathRef> ModuleFilePaths,
|
|
const PrerequisiteModules &RequisiteModules,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS) {
|
|
return llvm::all_of(
|
|
ModuleFilePaths, [&RequisiteModules, VFS](auto ModuleFilePath) {
|
|
return IsModuleFileUpToDate(ModuleFilePath, RequisiteModules, VFS);
|
|
});
|
|
}
|
|
|
|
// StandalonePrerequisiteModules - stands for PrerequisiteModules for which all
|
|
// the required modules are built successfully. All the module files
|
|
// are owned by the StandalonePrerequisiteModules class.
|
|
//
|
|
// Any of the built module files won't be shared with other instances of the
|
|
// class. So that we can avoid worrying thread safety.
|
|
//
|
|
// We don't need to worry about duplicated module names here since the standard
|
|
// guarantees the module names should be unique to a program.
|
|
class StandalonePrerequisiteModules : public PrerequisiteModules {
|
|
public:
|
|
StandalonePrerequisiteModules() = default;
|
|
|
|
StandalonePrerequisiteModules(const StandalonePrerequisiteModules &) = delete;
|
|
StandalonePrerequisiteModules
|
|
operator=(const StandalonePrerequisiteModules &) = delete;
|
|
StandalonePrerequisiteModules(StandalonePrerequisiteModules &&) = delete;
|
|
StandalonePrerequisiteModules
|
|
operator=(StandalonePrerequisiteModules &&) = delete;
|
|
|
|
~StandalonePrerequisiteModules() override = default;
|
|
|
|
void adjustHeaderSearchOptions(HeaderSearchOptions &Options) const override {
|
|
// Appending all built module files.
|
|
for (auto &RequiredModule : RequiredModules)
|
|
Options.PrebuiltModuleFiles.insert_or_assign(
|
|
RequiredModule.ModuleName, RequiredModule.ModuleFilePath);
|
|
}
|
|
|
|
bool canReuse(const CompilerInvocation &CI,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>) const override;
|
|
|
|
bool isModuleUnitBuilt(llvm::StringRef ModuleName) const {
|
|
return BuiltModuleNames.contains(ModuleName);
|
|
}
|
|
|
|
void addModuleFile(llvm::StringRef ModuleName,
|
|
llvm::StringRef ModuleFilePath) {
|
|
RequiredModules.emplace_back(ModuleName, ModuleFilePath);
|
|
BuiltModuleNames.insert(ModuleName);
|
|
}
|
|
|
|
private:
|
|
llvm::SmallVector<ModuleFile, 8> RequiredModules;
|
|
// A helper class to speedup the query if a module is built.
|
|
llvm::StringSet<> BuiltModuleNames;
|
|
};
|
|
|
|
// Build a module file for module with `ModuleName`. The information of built
|
|
// module file are stored in \param BuiltModuleFiles.
|
|
llvm::Error buildModuleFile(llvm::StringRef ModuleName,
|
|
const GlobalCompilationDatabase &CDB,
|
|
const ThreadsafeFS &TFS, ProjectModules &MDB,
|
|
PathRef ModuleFilesPrefix,
|
|
StandalonePrerequisiteModules &BuiltModuleFiles) {
|
|
if (BuiltModuleFiles.isModuleUnitBuilt(ModuleName))
|
|
return llvm::Error::success();
|
|
|
|
PathRef ModuleUnitFileName = MDB.getSourceForModuleName(ModuleName);
|
|
// It is possible that we're meeting third party modules (modules whose
|
|
// source are not in the project. e.g, the std module may be a third-party
|
|
// module for most projects) or something wrong with the implementation of
|
|
// ProjectModules.
|
|
// FIXME: How should we treat third party modules here? If we want to ignore
|
|
// third party modules, we should return true instead of false here.
|
|
// Currently we simply bail out.
|
|
if (ModuleUnitFileName.empty())
|
|
return llvm::createStringError("Failed to get the primary source");
|
|
|
|
// Try cheap operation earlier to boil-out cheaply if there are problems.
|
|
auto Cmd = CDB.getCompileCommand(ModuleUnitFileName);
|
|
if (!Cmd)
|
|
return llvm::createStringError(
|
|
llvm::formatv("No compile command for {0}", ModuleUnitFileName));
|
|
|
|
for (auto &RequiredModuleName : MDB.getRequiredModules(ModuleUnitFileName)) {
|
|
// Return early if there are errors building the module file.
|
|
if (llvm::Error Err = buildModuleFile(RequiredModuleName, CDB, TFS, MDB,
|
|
ModuleFilesPrefix, BuiltModuleFiles))
|
|
return llvm::createStringError(
|
|
llvm::formatv("Failed to build dependency {0}: {1}",
|
|
RequiredModuleName, llvm::toString(std::move(Err))));
|
|
}
|
|
|
|
Cmd->Output = getModuleFilePath(ModuleName, ModuleFilesPrefix);
|
|
|
|
ParseInputs Inputs;
|
|
Inputs.TFS = &TFS;
|
|
Inputs.CompileCommand = std::move(*Cmd);
|
|
|
|
IgnoreDiagnostics IgnoreDiags;
|
|
auto CI = buildCompilerInvocation(Inputs, IgnoreDiags);
|
|
if (!CI)
|
|
return llvm::createStringError("Failed to build compiler invocation");
|
|
|
|
auto FS = Inputs.TFS->view(Inputs.CompileCommand.Directory);
|
|
auto Buf = FS->getBufferForFile(Inputs.CompileCommand.Filename);
|
|
if (!Buf)
|
|
return llvm::createStringError("Failed to create buffer");
|
|
|
|
// In clang's driver, we will suppress the check for ODR violation in GMF.
|
|
// See the implementation of RenderModulesOptions in Clang.cpp.
|
|
CI->getLangOpts().SkipODRCheckInGMF = true;
|
|
|
|
// Hash the contents of input files and store the hash value to the BMI files.
|
|
// So that we can check if the files are still valid when we want to reuse the
|
|
// BMI files.
|
|
CI->getHeaderSearchOpts().ValidateASTInputFilesContent = true;
|
|
|
|
BuiltModuleFiles.adjustHeaderSearchOptions(CI->getHeaderSearchOpts());
|
|
|
|
CI->getFrontendOpts().OutputFile = Inputs.CompileCommand.Output;
|
|
auto Clang =
|
|
prepareCompilerInstance(std::move(CI), /*Preamble=*/nullptr,
|
|
std::move(*Buf), std::move(FS), IgnoreDiags);
|
|
if (!Clang)
|
|
return llvm::createStringError("Failed to prepare compiler instance");
|
|
|
|
GenerateReducedModuleInterfaceAction Action;
|
|
Clang->ExecuteAction(Action);
|
|
|
|
if (Clang->getDiagnostics().hasErrorOccurred())
|
|
return llvm::createStringError("Compilation failed");
|
|
|
|
BuiltModuleFiles.addModuleFile(ModuleName, Inputs.CompileCommand.Output);
|
|
return llvm::Error::success();
|
|
}
|
|
} // namespace
|
|
|
|
std::unique_ptr<PrerequisiteModules>
|
|
ModulesBuilder::buildPrerequisiteModulesFor(PathRef File,
|
|
const ThreadsafeFS &TFS) const {
|
|
std::unique_ptr<ProjectModules> MDB = CDB.getProjectModules(File);
|
|
if (!MDB) {
|
|
elog("Failed to get Project Modules information for {0}", File);
|
|
return std::make_unique<FailedPrerequisiteModules>();
|
|
}
|
|
|
|
std::vector<std::string> RequiredModuleNames = MDB->getRequiredModules(File);
|
|
if (RequiredModuleNames.empty())
|
|
return std::make_unique<StandalonePrerequisiteModules>();
|
|
|
|
llvm::SmallString<256> ModuleFilesPrefix = getUniqueModuleFilesPath(File);
|
|
|
|
log("Trying to build required modules for {0} in {1}", File,
|
|
ModuleFilesPrefix);
|
|
|
|
auto RequiredModules = std::make_unique<StandalonePrerequisiteModules>();
|
|
|
|
for (llvm::StringRef RequiredModuleName : RequiredModuleNames) {
|
|
// Return early if there is any error.
|
|
if (llvm::Error Err =
|
|
buildModuleFile(RequiredModuleName, CDB, TFS, *MDB.get(),
|
|
ModuleFilesPrefix, *RequiredModules.get())) {
|
|
elog("Failed to build module {0}; due to {1}", RequiredModuleName,
|
|
toString(std::move(Err)));
|
|
return std::make_unique<FailedPrerequisiteModules>();
|
|
}
|
|
}
|
|
|
|
log("Built required modules for {0} in {1}", File, ModuleFilesPrefix);
|
|
|
|
return std::move(RequiredModules);
|
|
}
|
|
|
|
bool StandalonePrerequisiteModules::canReuse(
|
|
const CompilerInvocation &CI,
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS) const {
|
|
if (RequiredModules.empty())
|
|
return true;
|
|
|
|
SmallVector<StringRef> BMIPaths;
|
|
for (auto &MF : RequiredModules)
|
|
BMIPaths.push_back(MF.ModuleFilePath);
|
|
return IsModuleFilesUpToDate(BMIPaths, *this, VFS);
|
|
}
|
|
|
|
} // namespace clangd
|
|
} // namespace clang
|