230b437d05
### 1. ElementType deduction for pointer-based array sections Problem: Pointer-based array sections were previously ignored during `ElementType` deduction, leading to incorrect assumptions about array item types. This often resulted in out-of-bounds access, as seen in the assertion failure: ``` Assertion `idx < size()' failed. llvm-project/llvm/include/llvm/ADT/SmallVector.h:292: reference llvm::SmallVectorTemplateCommon<llvm::Value *>::operatorsize_type [T = llvm::Value *] ``` Fix: Added a check in clang/lib/CodeGen/CGOpenMPRuntime.cpp to ensure `ElementType` is correctly detected for cases involving non-contiguous updates with a base pointer. Impact: Resolves failures in OpenMP_VV (formerly sollve_vv) and other offload/clang-OpenMP tests: All tests under: https://github.com/OpenMP-Validation-and-Verification/OpenMP_VV/tree/master/tests/5.0/target_update test_target_update_mapper_from_discontiguous.c test_target_update_mapper_to_discontiguous.c test_target_update_to_discontiguous.c test_target_update_from_discontiguous.c ### 2. Zero-dimension propagation in struct member mappings Problem: A zero-dimension entry for struct members introduced inconsistencies in complex mapping logic within OMPIRBuilder.cpp. Placeholder zeros propagated to emitNonContiguousDescriptor(), breaking reverse indexing logic and corrupting IR: Loops assume `Dims[I] >= 1`. When `Dims[I] == 0`: Reverse indexing still stores pointers to uninitialized allocas or mismatched slots. Runtime interprets `ArgSizes[I]` (derived from `Dims[I])` as dimensionality, causing size/offset calculations to collapse to zero → results in `size=0` async copy and plugin interface errors. Fix: Prepend a synthetic dimension of size 1 instead of appending a zero, preserving correctness in `targetDataUpdate()` for non-contiguous updates. Impact: Added dedicated test cases that previously failed on main.
75 lines
1.8 KiB
C
75 lines
1.8 KiB
C
// RUN: %libomptarget-compile-run-and-check-generic
|
|
// This test checks that "update from" clause in OpenMP supports strided
|
|
// sections. #pragma omp target update from(result[0:N/2:2]) updates every other
|
|
// element from device
|
|
#include <omp.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
#define N 32
|
|
|
|
int main() {
|
|
double *result = (double *)calloc(N, sizeof(double));
|
|
|
|
printf("initial host array values:\n");
|
|
for (int i = 0; i < N; i++)
|
|
printf("%f\n", result[i]);
|
|
printf("\n");
|
|
|
|
#pragma omp target data map(to : result[0 : N])
|
|
{
|
|
#pragma omp target map(alloc : result[0 : N])
|
|
for (int i = 0; i < N; i++)
|
|
result[i] += i;
|
|
|
|
// Update strided elements from device: even indices 0,2,4,...,30
|
|
#pragma omp target update from(result[0 : 16 : 2])
|
|
}
|
|
|
|
printf("after target update from (even indices up to 30 updated):\n");
|
|
for (int i = 0; i < N; i++)
|
|
printf("%f\n", result[i]);
|
|
printf("\n");
|
|
|
|
// Expected: even indices i, odd indices 0
|
|
// CHECK: after target update from
|
|
// CHECK: 0.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 2.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 4.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 6.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 8.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 10.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 12.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 14.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 16.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 18.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 20.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 22.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 24.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 26.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 28.000000
|
|
// CHECK: 0.000000
|
|
// CHECK: 30.000000
|
|
// CHECK: 0.000000
|
|
// CHECK-NOT: 1.000000
|
|
// CHECK-NOT: 3.000000
|
|
// CHECK-NOT: 31.000000
|
|
|
|
free(result);
|
|
return 0;
|
|
}
|