Xiaoyang Liu 7cafe04e0d
[libc++] P3029R1: Better mdspan's CTAD (#87873)
## Abstract

This pull request implements [P3029R1](https://wg21.link/P3029R1). The
paper discusses the current behavior of `mdspan`'s most common
pointer-indices CTAD, where the `Extents` template parameter is deduced
as `dextents` (dynamic extents), even when passing compile-time constant
values. The author believes this behavior is suboptimal, as it doesn't
take advantage of the compile-time information. The proposed change
suggests deducing static extents if `integral_constant`-like constants
are passed, resulting in more intuitive syntax and less error-prone
code.

## Reference

- [P3029R1](https://wg21.link/P3029R1)
- [Draft C++ Standard: [span.syn]](https://eel.is/c++draft/span.syn)
- [Draft C++ Standard: [mdspan.syn]](https://eel.is/c++draft/mdspan.syn)
2024-04-12 19:25:22 +02:00

127 lines
3.1 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17
// <span>
// template<class It, class EndOrSize>
// span(It, EndOrSize) -> span<remove_reference_t<iter_reference_t<_It>>>;
//
// template<class T, size_t N>
// span(T (&)[N]) -> span<T, N>;
//
// template<class T, size_t N>
// span(array<T, N>&) -> span<T, N>;
//
// template<class T, size_t N>
// span(const array<T, N>&) -> span<const T, N>;
//
// template<class R>
// span(R&&) -> span<remove_reference_t<ranges::range_reference_t<R>>>;
#include <span>
#include <array>
#include <cassert>
#include <iterator>
#include <memory>
#include <string>
#include <type_traits>
#include "test_macros.h"
void test_iterator_sentinel() {
int arr[] = {1, 2, 3};
{
std::span s{std::begin(arr), std::end(arr)};
ASSERT_SAME_TYPE(decltype(s), std::span<int>);
assert(s.size() == std::size(arr));
assert(s.data() == std::data(arr));
}
{
std::span s{std::begin(arr), 3};
ASSERT_SAME_TYPE(decltype(s), std::span<int>);
assert(s.size() == std::size(arr));
assert(s.data() == std::data(arr));
}
#if _LIBCPP_STD_VER >= 26
// P3029R1: deduction from `integral_constant`
{
std::span s{std::begin(arr), std::integral_constant<size_t, 3>{}};
ASSERT_SAME_TYPE(decltype(s), std::span<int, 3>);
assert(s.size() == std::size(arr));
assert(s.data() == std::data(arr));
}
#endif
}
void test_c_array() {
{
int arr[] = {1, 2, 3};
std::span s{arr};
ASSERT_SAME_TYPE(decltype(s), std::span<int, 3>);
assert(s.size() == std::size(arr));
assert(s.data() == std::data(arr));
}
{
const int arr[] = {1,2,3};
std::span s{arr};
ASSERT_SAME_TYPE(decltype(s), std::span<const int, 3>);
assert(s.size() == std::size(arr));
assert(s.data() == std::data(arr));
}
}
void test_std_array() {
{
std::array<double, 4> arr = {1.0, 2.0, 3.0, 4.0};
std::span s{arr};
ASSERT_SAME_TYPE(decltype(s), std::span<double, 4>);
assert(s.size() == arr.size());
assert(s.data() == arr.data());
}
{
const std::array<long, 5> arr = {4, 5, 6, 7, 8};
std::span s{arr};
ASSERT_SAME_TYPE(decltype(s), std::span<const long, 5>);
assert(s.size() == arr.size());
assert(s.data() == arr.data());
}
}
void test_range_std_container() {
{
std::string str{"ABCDE"};
std::span s{str};
ASSERT_SAME_TYPE(decltype(s), std::span<char>);
assert(s.size() == str.size());
assert(s.data() == str.data());
}
{
const std::string str{"QWERTYUIOP"};
std::span s{str};
ASSERT_SAME_TYPE(decltype(s), std::span<const char>);
assert(s.size() == str.size());
assert(s.data() == str.data());
}
}
int main(int, char**)
{
test_iterator_sentinel();
test_c_array();
test_std_array();
test_range_std_container();
return 0;
}