Alex Bradbury c2e84072bd
[RISCV] Set riscv-fpimm-cost threshold to 3 by default (#159352)
`-riscv-fp-imm-cost` controls the threshold at which the constant pool
is used for float constants rather than generating directly (typically
into a GPR followed by an `fmv`). The value used for this knob indicates
the number of instructions that can be used to produce the value
(otherwise we fall back to the constant pool). Upping to to 3 covers a
huge number of additional constants (see
<https://github.com/llvm/llvm-project/issues/153402>), e.g. most whole
numbers which can be generated through lui+shift+fmv. As in general we
struggle with efficient code generation for constant pool accesses,
reducing the number of constant pool accesses is beneficial. We are
typically replacing a two-instruction sequence (which includes a load)
with a three instruction sequence (two simple arithmetic operations plus
a fmv), which.

The CHECK prefixes for various tests had to be updated to avoid
conflicts leading to check lines being dropped altogether (see
<https://github.com/llvm/llvm-project/pull/159321> for a change to
update_llc_test_checks to aid diagnosing this).
2025-09-24 10:50:01 +01:00

75 lines
2.3 KiB
LLVM

; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc -mtriple=riscv32 -mattr=+f -verify-machineinstrs < %s \
; RUN: -target-abi=ilp32f | FileCheck %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
; RUN: -target-abi=lp64f | FileCheck %s
; RUN: llc -mtriple=riscv32 -mattr=+zfinx -verify-machineinstrs < %s \
; RUN: -target-abi=ilp32 | FileCheck --check-prefixes=CHECKZFINX,RV32ZFINX %s
; RUN: llc -mtriple=riscv64 -mattr=+zfinx -verify-machineinstrs < %s \
; RUN: -target-abi=lp64 | FileCheck --check-prefixes=CHECKZFINX,RV64ZFINX %s
; TODO: constant pool shouldn't be necessary for RV64IF.
define float @float_imm() nounwind {
; CHECK-LABEL: float_imm:
; CHECK: # %bb.0:
; CHECK-NEXT: lui a0, 263313
; CHECK-NEXT: addi a0, a0, -37
; CHECK-NEXT: fmv.w.x fa0, a0
; CHECK-NEXT: ret
;
; CHECKZFINX-LABEL: float_imm:
; CHECKZFINX: # %bb.0:
; CHECKZFINX-NEXT: lui a0, 263313
; CHECKZFINX-NEXT: addi a0, a0, -37
; CHECKZFINX-NEXT: # kill: def $x10_w killed $x10_w killed $x10
; CHECKZFINX-NEXT: ret
ret float 3.14159274101257324218750
}
define float @float_imm_op(float %a) nounwind {
; CHECK-LABEL: float_imm_op:
; CHECK: # %bb.0:
; CHECK-NEXT: lui a0, 260096
; CHECK-NEXT: fmv.w.x fa5, a0
; CHECK-NEXT: fadd.s fa0, fa0, fa5
; CHECK-NEXT: ret
;
; CHECKZFINX-LABEL: float_imm_op:
; CHECKZFINX: # %bb.0:
; CHECKZFINX-NEXT: lui a1, 260096
; CHECKZFINX-NEXT: fadd.s a0, a0, a1
; CHECKZFINX-NEXT: ret
%1 = fadd float %a, 1.0
ret float %1
}
define float @float_positive_zero(ptr %pf) nounwind {
; CHECK-LABEL: float_positive_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: fmv.w.x fa0, zero
; CHECK-NEXT: ret
;
; CHECKZFINX-LABEL: float_positive_zero:
; CHECKZFINX: # %bb.0:
; CHECKZFINX-NEXT: li a0, 0
; CHECKZFINX-NEXT: ret
ret float 0.0
}
define float @float_negative_zero(ptr %pf) nounwind {
; CHECK-LABEL: float_negative_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: lui a0, 524288
; CHECK-NEXT: fmv.w.x fa0, a0
; CHECK-NEXT: ret
;
; CHECKZFINX-LABEL: float_negative_zero:
; CHECKZFINX: # %bb.0:
; CHECKZFINX-NEXT: lui a0, 524288
; CHECKZFINX-NEXT: ret
ret float -0.0
}
;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
; RV32ZFINX: {{.*}}
; RV64ZFINX: {{.*}}