38818b60c5
Use deduction guides instead of helper functions.
The only non-automatic changes have been:
1. ArrayRef(some_uint8_pointer, 0) needs to be changed into ArrayRef(some_uint8_pointer, (size_t)0) to avoid an ambiguous call with ArrayRef((uint8_t*), (uint8_t*))
2. CVSymbol sym(makeArrayRef(symStorage)); needed to be rewritten as CVSymbol sym{ArrayRef(symStorage)}; otherwise the compiler is confused and thinks we have a (bad) function prototype. There was a few similar situation across the codebase.
3. ADL doesn't seem to work the same for deduction-guides and functions, so at some point the llvm namespace must be explicitly stated.
4. The "reference mode" of makeArrayRef(ArrayRef<T> &) that acts as no-op is not supported (a constructor cannot achieve that).
Per reviewers' comment, some useless makeArrayRef have been removed in the process.
This is a follow-up to https://reviews.llvm.org/D140896 that introduced
the deduction guides.
Differential Revision: https://reviews.llvm.org/D140955
64 lines
1.7 KiB
C++
64 lines
1.7 KiB
C++
//===- llvm/unittest/Support/EditDistanceTest.cpp - Edit distance tests ---===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/ADT/StringRef.h"
|
|
#include "llvm/ADT/edit_distance.h"
|
|
#include "gtest/gtest.h"
|
|
#include <cstdlib>
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
struct Result {
|
|
unsigned NumMaps;
|
|
unsigned EditDist;
|
|
};
|
|
} // namespace
|
|
|
|
static Result editDistanceAndMaps(StringRef A, StringRef B,
|
|
unsigned MaxEditDistance = 0) {
|
|
unsigned NumMaps = 0;
|
|
auto TrackMaps = [&](const char X) {
|
|
++NumMaps;
|
|
return X;
|
|
};
|
|
unsigned EditDist = llvm::ComputeMappedEditDistance(
|
|
ArrayRef(A.data(), A.size()), ArrayRef(B.data(), B.size()), TrackMaps,
|
|
true, MaxEditDistance);
|
|
return {NumMaps, EditDist};
|
|
}
|
|
|
|
TEST(EditDistance, VerifyShortCircuit) {
|
|
StringRef Hello = "Hello";
|
|
StringRef HelloWorld = "HelloWorld";
|
|
Result R = editDistanceAndMaps(Hello, HelloWorld, 5);
|
|
EXPECT_EQ(R.EditDist, 5U);
|
|
EXPECT_GT(R.NumMaps, 0U);
|
|
|
|
R = editDistanceAndMaps(Hello, HelloWorld);
|
|
EXPECT_EQ(R.EditDist, 5U);
|
|
EXPECT_GT(R.NumMaps, 0U);
|
|
|
|
R = editDistanceAndMaps(Hello, HelloWorld, 4);
|
|
EXPECT_EQ(R.EditDist, 5U);
|
|
EXPECT_EQ(R.NumMaps, 0U);
|
|
|
|
R = editDistanceAndMaps(HelloWorld, Hello, 4);
|
|
EXPECT_EQ(R.EditDist, 5U);
|
|
EXPECT_EQ(R.NumMaps, 0U);
|
|
|
|
R = editDistanceAndMaps(Hello, HelloWorld, 1);
|
|
EXPECT_EQ(R.EditDist, 2U);
|
|
EXPECT_EQ(R.NumMaps, 0U);
|
|
|
|
R = editDistanceAndMaps(HelloWorld, Hello, 1);
|
|
EXPECT_EQ(R.EditDist, 2U);
|
|
EXPECT_EQ(R.NumMaps, 0U);
|
|
}
|