7b0f70a9b2
Currently wasm adds an extra level of options that work backwards from the standard options, and overwrites them. The ExceptionModel field in TM->Options is the standard user configuration option for the exception model to use. MCAsmInfo's ExceptionsType is a constant for the default to use for the triple if not explicitly set in the TargetOptions ExceptionModel. This was adding 2 custom flags, changing the MCAsmInfo default, and overwriting the ExceptionModel from the custom flags. These comments about compiling bitcode with clang are describing a toolchain bug or user error. TargetOptions is bad, and we should move to eliminating it. It is module state not captured in the IR. Ideally the exception model should either come implied from the triple, or a module flag and not depend on this side state. Currently it is the responsibility of the toolchain and/or user to ensure the same command line flags are used at each phase of the compilation. It is not the backend's responsibilty to try to second guess these options. -wasm-enable-eh and -wasm-enable-sjlj should also be removed in favor of the standard exception control. I'm a bit confused by how all of these fields are supposed to interact, but there are a few uses in the backend that are directly looking at these flags instead of the already parsed ExceptionModel which need to be cleaned up. Additionally, this was enforcing some rules about the combinations of flags at a random point in the IR pass pipeline configuration. This is a module property that should be handled at TargetMachine construction time at the latest. This required adding flags to a few mir and clang tests which never got this far to avoid hitting the errors.
62 lines
2.0 KiB
C++
62 lines
2.0 KiB
C++
//===-- WebAssemblyMCAsmInfo.cpp - WebAssembly asm properties -------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
///
|
|
/// \file
|
|
/// This file contains the declarations of the WebAssemblyMCAsmInfo
|
|
/// properties.
|
|
///
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "WebAssemblyMCAsmInfo.h"
|
|
#include "WebAssemblyMCTargetDesc.h"
|
|
#include "llvm/MC/MCExpr.h"
|
|
#include "llvm/TargetParser/Triple.h"
|
|
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "wasm-mc-asm-info"
|
|
|
|
const MCAsmInfo::AtSpecifier atSpecifiers[] = {
|
|
{WebAssembly::S_TYPEINDEX, "TYPEINDEX"},
|
|
{WebAssembly::S_TBREL, "TBREL"},
|
|
{WebAssembly::S_MBREL, "MBREL"},
|
|
{WebAssembly::S_TLSREL, "TLSREL"},
|
|
{WebAssembly::S_GOT, "GOT"},
|
|
{WebAssembly::S_GOT_TLS, "GOT@TLS"},
|
|
{WebAssembly::S_FUNCINDEX, "FUNCINDEX"},
|
|
};
|
|
|
|
WebAssemblyMCAsmInfo::~WebAssemblyMCAsmInfo() = default; // anchor.
|
|
|
|
WebAssemblyMCAsmInfo::WebAssemblyMCAsmInfo(const Triple &T,
|
|
const MCTargetOptions &Options) {
|
|
CodePointerSize = CalleeSaveStackSlotSize = T.isArch64Bit() ? 8 : 4;
|
|
|
|
// TODO: What should MaxInstLength be?
|
|
|
|
UseDataRegionDirectives = true;
|
|
|
|
// Use .skip instead of .zero because .zero is confusing when used with two
|
|
// arguments (it doesn't actually zero things out).
|
|
ZeroDirective = "\t.skip\t";
|
|
|
|
Data8bitsDirective = "\t.int8\t";
|
|
Data16bitsDirective = "\t.int16\t";
|
|
Data32bitsDirective = "\t.int32\t";
|
|
Data64bitsDirective = "\t.int64\t";
|
|
|
|
AlignmentIsInBytes = false;
|
|
COMMDirectiveAlignmentIsInBytes = false;
|
|
LCOMMDirectiveAlignmentType = LCOMM::Log2Alignment;
|
|
|
|
SupportsDebugInformation = true;
|
|
ExceptionsType = ExceptionHandling::None;
|
|
|
|
initializeAtSpecifiers(atSpecifiers);
|
|
}
|