f866ef202c
The LLVM Coding Standards [1] specify that: > [T]o match error message styles commonly produced by other tools, > start the first sentence with a lowercase letter, and finish the last > sentence without a period, if it would end in one otherwise. Historically, that hasn't been something we've enforced in LLDB, but in the past year or so I've started to pay more attention to this in code reviews. This PR brings more error messages in compliance, further increasing consistency. I also adopted `createStringErrorV` where it improved the code as a drive-by for lines I was already touching. [1] https://llvm.org/docs/CodingStandards.html#error-and-warning-messages Assisted-by: Claude Code
67 lines
2.2 KiB
C++
67 lines
2.2 KiB
C++
//===-- LibCxxQueue.cpp ---------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "LibCxx.h"
|
|
#include "lldb/DataFormatters/FormattersHelpers.h"
|
|
#include "llvm/Support/ErrorExtras.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
namespace {
|
|
|
|
class QueueFrontEnd : public SyntheticChildrenFrontEnd {
|
|
public:
|
|
QueueFrontEnd(ValueObject &valobj) : SyntheticChildrenFrontEnd(valobj) {
|
|
Update();
|
|
}
|
|
|
|
llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {
|
|
if (m_container_sp)
|
|
return m_container_sp->GetIndexOfChildWithName(name);
|
|
return llvm::createStringErrorV("type has no child named '{0}'", name);
|
|
}
|
|
|
|
lldb::ChildCacheState Update() override;
|
|
|
|
llvm::Expected<uint32_t> CalculateNumChildren() override {
|
|
return m_container_sp ? m_container_sp->GetNumChildren() : 0;
|
|
}
|
|
|
|
ValueObjectSP GetChildAtIndex(uint32_t idx) override {
|
|
return m_container_sp ? m_container_sp->GetChildAtIndex(idx)
|
|
: nullptr;
|
|
}
|
|
|
|
private:
|
|
// The lifetime of a ValueObject and all its derivative ValueObjects
|
|
// (children, clones, etc.) is managed by a ClusterManager. These
|
|
// objects are only destroyed when every shared pointer to any of them
|
|
// is destroyed, so we must not store a shared pointer to any ValueObject
|
|
// derived from our backend ValueObject (since we're in the same cluster).
|
|
ValueObject* m_container_sp = nullptr;
|
|
};
|
|
} // namespace
|
|
|
|
lldb::ChildCacheState QueueFrontEnd::Update() {
|
|
m_container_sp = nullptr;
|
|
ValueObjectSP c_sp = m_backend.GetChildMemberWithName("c");
|
|
if (!c_sp)
|
|
return lldb::ChildCacheState::eRefetch;
|
|
m_container_sp = c_sp->GetSyntheticValue().get();
|
|
return lldb::ChildCacheState::eRefetch;
|
|
}
|
|
|
|
SyntheticChildrenFrontEnd *
|
|
formatters::LibcxxQueueFrontEndCreator(CXXSyntheticChildren *,
|
|
lldb::ValueObjectSP valobj_sp) {
|
|
if (valobj_sp)
|
|
return new QueueFrontEnd(*valobj_sp);
|
|
return nullptr;
|
|
}
|