f866ef202c
The LLVM Coding Standards [1] specify that: > [T]o match error message styles commonly produced by other tools, > start the first sentence with a lowercase letter, and finish the last > sentence without a period, if it would end in one otherwise. Historically, that hasn't been something we've enforced in LLDB, but in the past year or so I've started to pay more attention to this in code reviews. This PR brings more error messages in compliance, further increasing consistency. I also adopted `createStringErrorV` where it improved the code as a drive-by for lines I was already touching. [1] https://llvm.org/docs/CodingStandards.html#error-and-warning-messages Assisted-by: Claude Code
112 lines
3.6 KiB
C++
112 lines
3.6 KiB
C++
//===---------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "LibStdcpp.h"
|
|
|
|
#include "lldb/DataFormatters/FormattersHelpers.h"
|
|
#include "lldb/Utility/ConstString.h"
|
|
#include "lldb/ValueObject/ValueObject.h"
|
|
#include "llvm/ADT/APSInt.h"
|
|
#include "llvm/Support/Error.h"
|
|
#include "llvm/Support/ErrorExtras.h"
|
|
#include <cstddef>
|
|
#include <optional>
|
|
|
|
using namespace lldb;
|
|
|
|
namespace lldb_private::formatters {
|
|
|
|
class LibStdcppSpanSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
|
|
public:
|
|
LibStdcppSpanSyntheticFrontEnd(const lldb::ValueObjectSP &valobj_sp)
|
|
: SyntheticChildrenFrontEnd(*valobj_sp) {
|
|
if (valobj_sp)
|
|
Update();
|
|
}
|
|
|
|
~LibStdcppSpanSyntheticFrontEnd() override = default;
|
|
|
|
llvm::Expected<uint32_t> CalculateNumChildren() override {
|
|
return m_num_elements;
|
|
}
|
|
|
|
lldb::ValueObjectSP GetChildAtIndex(uint32_t idx) override {
|
|
if (!m_start)
|
|
return {};
|
|
|
|
uint64_t offset = (static_cast<uint64_t>(idx) * m_element_size);
|
|
offset += m_start->GetValueAsUnsigned(0);
|
|
const std::string name = llvm::formatv("[{0}]", idx);
|
|
return CreateValueObjectFromAddress(
|
|
name, offset, m_backend.GetExecutionContextRef(), m_element_type);
|
|
}
|
|
|
|
lldb::ChildCacheState Update() override {
|
|
const ValueObjectSP data_ptr = m_backend.GetChildMemberWithName("_M_ptr");
|
|
if (!data_ptr)
|
|
return lldb::ChildCacheState::eRefetch;
|
|
|
|
m_element_type = data_ptr->GetCompilerType().GetPointeeType();
|
|
|
|
// Get element size.
|
|
llvm::Expected<uint64_t> size_or_err = m_element_type.GetByteSize(nullptr);
|
|
if (!size_or_err) {
|
|
LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters), size_or_err.takeError(),
|
|
"{0}");
|
|
return lldb::ChildCacheState::eReuse;
|
|
}
|
|
|
|
m_element_size = *size_or_err;
|
|
if (m_element_size > 0) {
|
|
m_start = data_ptr.get();
|
|
}
|
|
|
|
// Get number of elements.
|
|
if (const ValueObjectSP size_sp =
|
|
m_backend.GetChildAtNamePath({"_M_extent", "_M_extent_value"})) {
|
|
m_num_elements = size_sp->GetValueAsUnsigned(0);
|
|
} else if (const auto arg =
|
|
m_backend.GetCompilerType().GetIntegralTemplateArgument(1)) {
|
|
|
|
m_num_elements = arg->value.GetAPSInt().getLimitedValue();
|
|
}
|
|
|
|
return lldb::ChildCacheState::eReuse;
|
|
}
|
|
|
|
llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {
|
|
if (!m_start)
|
|
return llvm::createStringErrorV("type has no child named '{0}'", name);
|
|
|
|
auto optional_idx = formatters::ExtractIndexFromString(name.GetCString());
|
|
if (!optional_idx) {
|
|
return llvm::createStringErrorV("type has no child named '{0}'", name);
|
|
}
|
|
return *optional_idx;
|
|
}
|
|
|
|
private:
|
|
ValueObject *m_start = nullptr; ///< First element of span. Held, not owned.
|
|
CompilerType m_element_type; ///< Type of span elements.
|
|
size_t m_num_elements = 0; ///< Number of elements in span.
|
|
uint32_t m_element_size = 0; ///< Size in bytes of each span element.
|
|
};
|
|
|
|
SyntheticChildrenFrontEnd *
|
|
LibStdcppSpanSyntheticFrontEndCreator(CXXSyntheticChildren * /*unused*/,
|
|
lldb::ValueObjectSP valobj_sp) {
|
|
if (!valobj_sp)
|
|
return nullptr;
|
|
const CompilerType type = valobj_sp->GetCompilerType();
|
|
if (!type || type.GetNumTemplateArguments() != 2)
|
|
return nullptr;
|
|
return new LibStdcppSpanSyntheticFrontEnd(valobj_sp);
|
|
}
|
|
|
|
} // namespace lldb_private::formatters
|