This patch corrects the state of the error node generated by the
core.DivideZero checker when it detects potential division by zero
involving a tainted denominator.
The checker split in
91ac5ed10a
started to introduce a conflicting assumption about the denominator into
the error node:
Node with the Bug Report "Division by a tainted value, possibly zero"
has an assumption "denominator != 0".
This has been done as a shortcut to continue analysis with the correct
assumption *after* the division - if we proceed, we can only assume the
denominator was not zero. However, this assumption is introduced
one-node too soon, leading to a self-contradictory error node.
In this patch, I make the error node with assumption of zero denominator
fatal, but allow analysis to continue on the second half of the state
split with the assumption of non-zero denominator.
---
CPP-6376
140 lines
4.8 KiB
C++
140 lines
4.8 KiB
C++
//== DivZeroChecker.cpp - Division by zero checker --------------*- C++ -*--==//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This defines DivZeroChecker, a builtin check in ExprEngine that performs
|
|
// checks for division by zeros.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/StaticAnalyzer/Checkers/Taint.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
#include <optional>
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
using namespace taint;
|
|
|
|
namespace {
|
|
class DivZeroChecker : public CheckerFamily<check::PreStmt<BinaryOperator>> {
|
|
void reportBug(StringRef Msg, ProgramStateRef StateZero,
|
|
CheckerContext &C) const;
|
|
void reportTaintBug(StringRef Msg, ProgramStateRef StateZero,
|
|
CheckerContext &C,
|
|
llvm::ArrayRef<SymbolRef> TaintedSyms) const;
|
|
|
|
public:
|
|
/// This checker family implements two user-facing checker parts.
|
|
CheckerFrontendWithBugType DivideZeroChecker{"Division by zero"};
|
|
CheckerFrontendWithBugType TaintedDivChecker{"Division by zero",
|
|
categories::TaintedData};
|
|
|
|
void checkPreStmt(const BinaryOperator *B, CheckerContext &C) const;
|
|
|
|
/// Identifies this checker family for debugging purposes.
|
|
StringRef getDebugTag() const override { return "DivZeroChecker"; }
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
static const Expr *getDenomExpr(const ExplodedNode *N) {
|
|
const Stmt *S = N->getLocationAs<PreStmt>()->getStmt();
|
|
if (const auto *BE = dyn_cast<BinaryOperator>(S))
|
|
return BE->getRHS();
|
|
return nullptr;
|
|
}
|
|
|
|
void DivZeroChecker::reportBug(StringRef Msg, ProgramStateRef StateZero,
|
|
CheckerContext &C) const {
|
|
if (!DivideZeroChecker.isEnabled())
|
|
return;
|
|
if (ExplodedNode *N = C.generateErrorNode(StateZero)) {
|
|
auto R =
|
|
std::make_unique<PathSensitiveBugReport>(DivideZeroChecker, Msg, N);
|
|
bugreporter::trackExpressionValue(N, getDenomExpr(N), *R);
|
|
C.emitReport(std::move(R));
|
|
}
|
|
}
|
|
|
|
void DivZeroChecker::reportTaintBug(
|
|
StringRef Msg, ProgramStateRef StateZero, CheckerContext &C,
|
|
llvm::ArrayRef<SymbolRef> TaintedSyms) const {
|
|
if (!TaintedDivChecker.isEnabled())
|
|
return;
|
|
if (ExplodedNode *N = C.generateErrorNode(StateZero)) {
|
|
auto R =
|
|
std::make_unique<PathSensitiveBugReport>(TaintedDivChecker, Msg, N);
|
|
bugreporter::trackExpressionValue(N, getDenomExpr(N), *R);
|
|
for (auto Sym : TaintedSyms)
|
|
R->markInteresting(Sym);
|
|
C.emitReport(std::move(R));
|
|
}
|
|
}
|
|
|
|
void DivZeroChecker::checkPreStmt(const BinaryOperator *B,
|
|
CheckerContext &C) const {
|
|
BinaryOperator::Opcode Op = B->getOpcode();
|
|
if (Op != BO_Div &&
|
|
Op != BO_Rem &&
|
|
Op != BO_DivAssign &&
|
|
Op != BO_RemAssign)
|
|
return;
|
|
|
|
if (!B->getRHS()->getType()->isScalarType())
|
|
return;
|
|
|
|
SVal Denom = C.getSVal(B->getRHS());
|
|
std::optional<DefinedSVal> DV = Denom.getAs<DefinedSVal>();
|
|
|
|
// Divide-by-undefined handled in the generic checking for uses of
|
|
// undefined values.
|
|
if (!DV)
|
|
return;
|
|
|
|
// Check for divide by zero.
|
|
ConstraintManager &CM = C.getConstraintManager();
|
|
ProgramStateRef stateNotZero, stateZero;
|
|
std::tie(stateNotZero, stateZero) = CM.assumeDual(C.getState(), *DV);
|
|
|
|
if (!stateNotZero) {
|
|
assert(stateZero);
|
|
reportBug("Division by zero", stateZero, C);
|
|
return;
|
|
}
|
|
|
|
if ((stateNotZero && stateZero)) {
|
|
std::vector<SymbolRef> taintedSyms = getTaintedSymbols(C.getState(), *DV);
|
|
if (!taintedSyms.empty()) {
|
|
reportTaintBug("Division by a tainted value, possibly zero", stateZero, C,
|
|
taintedSyms);
|
|
// Fallthrough to continue analysis in case of non-zero denominator.
|
|
}
|
|
}
|
|
|
|
// If we get here, then the denom should not be zero. We abandon the implicit
|
|
// zero denom case for now.
|
|
C.addTransition(stateNotZero);
|
|
}
|
|
|
|
void ento::registerDivZeroChecker(CheckerManager &Mgr) {
|
|
Mgr.getChecker<DivZeroChecker>()->DivideZeroChecker.enable(Mgr);
|
|
}
|
|
|
|
bool ento::shouldRegisterDivZeroChecker(const CheckerManager &) { return true; }
|
|
|
|
void ento::registerTaintedDivChecker(CheckerManager &Mgr) {
|
|
Mgr.getChecker<DivZeroChecker>()->TaintedDivChecker.enable(Mgr);
|
|
}
|
|
|
|
bool ento::shouldRegisterTaintedDivChecker(const CheckerManager &) {
|
|
return true;
|
|
}
|