f9c1ede254
Per discussion at https://discourse.llvm.org/t/representing-buffer-descriptors-in-the-amdgpu-target-call-for-suggestions/68798, we define two new address spaces for AMDGCN targets. The first is address space 7, a non-integral address space (which was already in the data layout) that has 160-bit pointers (which are 256-bit aligned) and uses a 32-bit offset. These pointers combine a 128-bit buffer descriptor and a 32-bit offset, and will be usable with normal LLVM operations (load, store, GEP). However, they will be rewritten out of existence before code generation. The second of these is address space 8, the address space for "buffer resources". These will be used to represent the resource arguments to buffer instructions, and new buffer intrinsics will be defined that take them instead of <4 x i32> as resource arguments. ptr addrspace(8). These pointers are 128-bits long (with the same alignment). They must not be used as the arguments to getelementptr or otherwise used in address computations, since they can have arbitrarily complex inherent addressing semantics that can't be represented in LLVM. Even though, like their address space 7 cousins, these pointers have deterministic ptrtoint/inttoptr semantics, they are defined to be non-integral in order to prevent optimizations that rely on pointers being a [0, [addr_max]] value from applying to them. Future work includes: - Defining new buffer intrinsics that take ptr addrspace(8) resources. - A late rewrite to turn address space 7 operations into buffer intrinsics and offset computations. This commit also updates the "fallback address space" for buffer intrinsics to the buffer resource, and updates the alias analysis table. Depends on D143437 Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D145441
104 lines
4.8 KiB
C++
104 lines
4.8 KiB
C++
//===- DataLayoutUpgradeTest.cpp - Tests for DataLayout upgrades ----------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/IR/AutoUpgrade.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
TEST(DataLayoutUpgradeTest, ValidDataLayoutUpgrade) {
|
|
std::string DL1 =
|
|
UpgradeDataLayoutString("e-m:e-p:32:32-i64:64-f80:128-n8:16:32:64-S128",
|
|
"x86_64-unknown-linux-gnu");
|
|
std::string DL2 = UpgradeDataLayoutString(
|
|
"e-m:w-p:32:32-i64:64-f80:32-n8:16:32-S32", "i686-pc-windows-msvc");
|
|
std::string DL3 = UpgradeDataLayoutString("e-m:o-i64:64-i128:128-n32:64-S128",
|
|
"x86_64-apple-macosx");
|
|
EXPECT_EQ(DL1, "e-m:e-p:32:32-p270:32:32-p271:32:32-p272:64:64-i64:64"
|
|
"-f80:128-n8:16:32:64-S128");
|
|
EXPECT_EQ(DL2, "e-m:w-p:32:32-p270:32:32-p271:32:32-p272:64:64-i64:64"
|
|
"-f80:128-n8:16:32-S32");
|
|
EXPECT_EQ(DL3, "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128"
|
|
"-n32:64-S128");
|
|
|
|
// Check that AMDGPU targets add -G1 if it's not present.
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:32:32", "r600"), "e-p:32:32-G1");
|
|
// and that ANDGCN adds p7 and p8 as well.
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:64:64", "amdgcn"),
|
|
"e-p:64:64-G1-p7:160:256:256:32-p8:128:128-ni:7:8");
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:64:64-G1", "amdgcn"),
|
|
"e-p:64:64-G1-p7:160:256:256:32-p8:128:128-ni:7:8");
|
|
// but that r600 does not.
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:32:32-G1", "r600"), "e-p:32:32-G1");
|
|
|
|
// Check that AMDGCN makes address space 8 non-integral if there's an existing
|
|
// non-integrality declaration.
|
|
EXPECT_EQ(UpgradeDataLayoutString(
|
|
"e-p:64:64-G1-p7:160:256:256:32-p8:128:128-ni:7", "amdgcn"),
|
|
"e-p:64:64-G1-p7:160:256:256:32-p8:128:128-ni:7:8");
|
|
|
|
// Check that RISCV64 upgrades -n64 to -n32:64.
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-m:e-p:64:64-i64:64-i128:128-n64-S128",
|
|
"riscv64"),
|
|
"e-m:e-p:64:64-i64:64-i128:128-n32:64-S128");
|
|
}
|
|
|
|
TEST(DataLayoutUpgradeTest, NoDataLayoutUpgrade) {
|
|
std::string DL1 = UpgradeDataLayoutString(
|
|
"e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32"
|
|
"-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
|
|
"-n8:16:32:64-S128",
|
|
"x86_64-unknown-linux-gnu");
|
|
std::string DL2 = UpgradeDataLayoutString("e-p:32:32", "i686-apple-darwin9");
|
|
std::string DL3 = UpgradeDataLayoutString("e-m:e-i64:64-n32:64",
|
|
"powerpc64le-unknown-linux-gnu");
|
|
std::string DL4 =
|
|
UpgradeDataLayoutString("e-m:o-i64:64-i128:128-n32:64-S128", "aarch64--");
|
|
EXPECT_EQ(DL1, "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64"
|
|
"-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64"
|
|
"-f80:128:128-n8:16:32:64-S128");
|
|
EXPECT_EQ(DL2, "e-p:32:32");
|
|
EXPECT_EQ(DL3, "e-m:e-i64:64-n32:64");
|
|
EXPECT_EQ(DL4, "e-m:o-i64:64-i128:128-n32:64-S128");
|
|
|
|
// Check that AMDGPU targets don't add -G1 if there is already a -G flag.
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:32:32-G2", "r600"), "e-p:32:32-G2");
|
|
EXPECT_EQ(UpgradeDataLayoutString("G2", "r600"), "G2");
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:64:64-G2", "amdgcn"),
|
|
"e-p:64:64-G2-p7:160:256:256:32-p8:128:128-ni:7:8");
|
|
EXPECT_EQ(UpgradeDataLayoutString("G2-e-p:64:64", "amdgcn"),
|
|
"G2-e-p:64:64-p7:160:256:256:32-p8:128:128-ni:7:8");
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:64:64-G0", "amdgcn"),
|
|
"e-p:64:64-G0-p7:160:256:256:32-p8:128:128-ni:7:8");
|
|
|
|
// Check that AMDGCN targets don't add already declared address space 7.
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:64:64-p7:64:64", "amdgcn"),
|
|
"e-p:64:64-p7:64:64-G1-p8:128:128-ni:7:8");
|
|
EXPECT_EQ(UpgradeDataLayoutString("p7:64:64-G2-e-p:64:64", "amdgcn"),
|
|
"p7:64:64-G2-e-p:64:64-p8:128:128-ni:7:8");
|
|
EXPECT_EQ(UpgradeDataLayoutString("e-p:64:64-p7:64:64-G1", "amdgcn"),
|
|
"e-p:64:64-p7:64:64-G1-p8:128:128-ni:7:8");
|
|
}
|
|
|
|
TEST(DataLayoutUpgradeTest, EmptyDataLayout) {
|
|
std::string DL1 = UpgradeDataLayoutString("", "x86_64-unknown-linux-gnu");
|
|
std::string DL2 = UpgradeDataLayoutString(
|
|
"e-m:e-p:32:32-i64:64-f80:128-n8:16:32:64-S128", "");
|
|
EXPECT_EQ(DL1, "");
|
|
EXPECT_EQ(DL2, "e-m:e-p:32:32-i64:64-f80:128-n8:16:32:64-S128");
|
|
|
|
// Check that AMDGPU targets add G1 if it's not present.
|
|
EXPECT_EQ(UpgradeDataLayoutString("", "r600"), "G1");
|
|
EXPECT_EQ(UpgradeDataLayoutString("", "amdgcn"),
|
|
"G1-p7:160:256:256:32-p8:128:128-ni:7:8");
|
|
}
|
|
|
|
} // end namespace
|