In binary form, 64-bit values are split into two 32-bit values as per the spec. Naturally this works fine with all tools. However, the text format does not have a formal specification but SPIR-V-Tools, which we already rely on in the SPIRV workflow (clang calls `spirv-as` for example), expects the full 64 bit value, but today we print the two 32-bit values. causing the tool to error and report that the format is invalid. The SPIR-V Translator also prints a single 64-bit value for text format. This case is already handled specifically for `OpConstant`, but `OpSwitch` was missed. The SPIR-V translator also has special code in `OpSwitch` handling for this case. Recombine the two 32-bit operands into a single 64-bit value to print in `AsmPrinter`. The actual ASM (aka binary form) emission is unchanged. --------- Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
75 lines
2.7 KiB
C++
75 lines
2.7 KiB
C++
//=- SPIRVMCInstLower.cpp - Convert SPIR-V MachineInstr to MCInst -*- C++ -*-=//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file contains code to lower SPIR-V MachineInstrs to their corresponding
|
|
// MCInst records.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "SPIRVMCInstLower.h"
|
|
#include "SPIRVModuleAnalysis.h"
|
|
#include "SPIRVUtils.h"
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
|
#include "llvm/IR/Constants.h"
|
|
|
|
using namespace llvm;
|
|
|
|
void SPIRVMCInstLower::lower(const MachineInstr *MI, MCInst &OutMI,
|
|
SPIRV::ModuleAnalysisInfo *MAI) const {
|
|
OutMI.setOpcode(MI->getOpcode());
|
|
// Propagate previously set flags
|
|
if (MI->getAsmPrinterFlags() & SPIRV::ASM_PRINTER_WIDTH16)
|
|
OutMI.setFlags(SPIRV::INST_PRINTER_WIDTH16);
|
|
if (MI->getAsmPrinterFlags() & SPIRV::ASM_PRINTER_WIDTH64)
|
|
OutMI.setFlags(SPIRV::INST_PRINTER_WIDTH64);
|
|
const MachineFunction *MF = MI->getMF();
|
|
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
|
|
const MachineOperand &MO = MI->getOperand(i);
|
|
MCOperand MCOp;
|
|
switch (MO.getType()) {
|
|
default:
|
|
llvm_unreachable("unknown operand type");
|
|
case MachineOperand::MO_GlobalAddress: {
|
|
MCRegister FuncReg = MAI->getFuncReg(dyn_cast<Function>(MO.getGlobal()));
|
|
if (!FuncReg.isValid()) {
|
|
std::string DiagMsg;
|
|
raw_string_ostream OS(DiagMsg);
|
|
MI->print(OS);
|
|
DiagMsg = "Unknown function in:" + DiagMsg;
|
|
report_fatal_error(DiagMsg.c_str());
|
|
}
|
|
MCOp = MCOperand::createReg(FuncReg);
|
|
break;
|
|
}
|
|
case MachineOperand::MO_MachineBasicBlock:
|
|
MCOp = MCOperand::createReg(MAI->getOrCreateMBBRegister(*MO.getMBB()));
|
|
break;
|
|
case MachineOperand::MO_Register: {
|
|
MCRegister NewReg = MAI->getRegisterAlias(MF, MO.getReg());
|
|
MCOp = MCOperand::createReg(NewReg.isValid() ? NewReg
|
|
: MO.getReg().asMCReg());
|
|
break;
|
|
}
|
|
case MachineOperand::MO_Immediate:
|
|
if (MI->getOpcode() == SPIRV::OpExtInst && i == 2) {
|
|
MCRegister Reg = MAI->getExtInstSetReg(MO.getImm());
|
|
MCOp = MCOperand::createReg(Reg);
|
|
} else {
|
|
MCOp = MCOperand::createImm(MO.getImm());
|
|
}
|
|
break;
|
|
case MachineOperand::MO_FPImmediate:
|
|
MCOp = MCOperand::createDFPImm(
|
|
MO.getFPImm()->getValueAPF().convertToFloat());
|
|
break;
|
|
}
|
|
|
|
OutMI.addOperand(MCOp);
|
|
}
|
|
}
|