76a21502fd
ClangCheckerRegistry is a very non-obvious, poorly documented, weird concept. It derives from CheckerRegistry, and is placed in lib/StaticAnalyzer/Frontend, whereas it's base is located in lib/StaticAnalyzer/Core. It was, from what I can imagine, used to circumvent the problem that the registry functions of the checkers are located in the clangStaticAnalyzerCheckers library, but that library depends on clangStaticAnalyzerCore. However, clangStaticAnalyzerFrontend depends on both of those libraries. One can make the observation however, that CheckerRegistry has no place in Core, it isn't used there at all! The only place where it is used is Frontend, which is where it ultimately belongs. This move implies that since include/clang/StaticAnalyzer/Checkers/ClangCheckers.h only contained a single function: class CheckerRegistry; void registerBuiltinCheckers(CheckerRegistry ®istry); it had to re purposed, as CheckerRegistry is no longer available to clangStaticAnalyzerCheckers. It was renamed to BuiltinCheckerRegistration.h, which actually describes it a lot better -- it does not contain the registration functions for checkers, but only those generated by the tblgen files. Differential Revision: https://reviews.llvm.org/D54436 llvm-svn: 349275
63 lines
2.3 KiB
C++
63 lines
2.3 KiB
C++
//=== CXXSelfAssignmentChecker.cpp -----------------------------*- C++ -*--===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines CXXSelfAssignmentChecker, which tests all custom defined
|
|
// copy and move assignment operators for the case of self assignment, thus
|
|
// where the parameter refers to the same location where the this pointer
|
|
// points to. The checker itself does not do any checks at all, but it
|
|
// causes the analyzer to check every copy and move assignment operator twice:
|
|
// once for when 'this' aliases with the parameter and once for when it may not.
|
|
// It is the task of the other enabled checkers to find the bugs in these two
|
|
// different cases.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
|
|
class CXXSelfAssignmentChecker : public Checker<check::BeginFunction> {
|
|
public:
|
|
CXXSelfAssignmentChecker();
|
|
void checkBeginFunction(CheckerContext &C) const;
|
|
};
|
|
}
|
|
|
|
CXXSelfAssignmentChecker::CXXSelfAssignmentChecker() {}
|
|
|
|
void CXXSelfAssignmentChecker::checkBeginFunction(CheckerContext &C) const {
|
|
if (!C.inTopFrame())
|
|
return;
|
|
const auto *LCtx = C.getLocationContext();
|
|
const auto *MD = dyn_cast<CXXMethodDecl>(LCtx->getDecl());
|
|
if (!MD)
|
|
return;
|
|
if (!MD->isCopyAssignmentOperator() && !MD->isMoveAssignmentOperator())
|
|
return;
|
|
auto &State = C.getState();
|
|
auto &SVB = C.getSValBuilder();
|
|
auto ThisVal =
|
|
State->getSVal(SVB.getCXXThis(MD, LCtx->getStackFrame()));
|
|
auto Param = SVB.makeLoc(State->getRegion(MD->getParamDecl(0), LCtx));
|
|
auto ParamVal = State->getSVal(Param);
|
|
ProgramStateRef SelfAssignState = State->bindLoc(Param, ThisVal, LCtx);
|
|
C.addTransition(SelfAssignState);
|
|
ProgramStateRef NonSelfAssignState = State->bindLoc(Param, ParamVal, LCtx);
|
|
C.addTransition(NonSelfAssignState);
|
|
}
|
|
|
|
void ento::registerCXXSelfAssignmentChecker(CheckerManager &Mgr) {
|
|
Mgr.registerChecker<CXXSelfAssignmentChecker>();
|
|
}
|