9eef4d1c5f
This removes the delayed typo correction functionality from Clang (regular typo correction still remains) due to fragility of the solution. An RFC was posted here: https://discourse.llvm.org/t/rfc-removing-support-for-delayed-typo-correction/86631 and while that RFC was asking for folks to consider stepping up to be maintainers, and we did have a few new contributors show some interest, experiments show that it's likely worth it to remove this functionality entirely and focus efforts on improving regular typo correction. This removal fixes ~20 open issues (quite possibly more), improves compile time performance by roughly .3-.4% (https://llvm-compile-time-tracker.com/?config=Overview&stat=instructions%3Au&remote=AaronBallman&sortBy=date), and does not appear to regress diagnostic behavior in a way we wouldn't find acceptable. Fixes #142457 Fixes #139913 Fixes #138850 Fixes #137867 Fixes #137860 Fixes #107840 Fixes #93308 Fixes #69470 Fixes #59391 Fixes #58172 Fixes #46215 Fixes #45915 Fixes #45891 Fixes #44490 Fixes #36703 Fixes #32903 Fixes #23312 Fixes #69874
117 lines
2.7 KiB
C++
117 lines
2.7 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
struct T {
|
|
void f();
|
|
};
|
|
|
|
struct A {
|
|
T* operator->();
|
|
// expected-note@-1 {{member found by ambiguous name lookup}}
|
|
};
|
|
|
|
struct B {
|
|
T* operator->();
|
|
// expected-note@-1 {{member found by ambiguous name lookup}}
|
|
};
|
|
|
|
struct C : A, B {
|
|
};
|
|
|
|
struct D : A { };
|
|
|
|
struct E; // expected-note {{forward declaration of 'E'}}
|
|
|
|
void f(C &c, D& d, E& e) {
|
|
c->f();
|
|
// expected-error@-1 {{member 'operator->' found in multiple base classes of different types}}
|
|
d->f();
|
|
e->f(); // expected-error{{incomplete definition of type}}
|
|
}
|
|
|
|
namespace rdar8875304 {
|
|
class Point {};
|
|
class Line_Segment{ public: Line_Segment(const Point&){} };
|
|
class Node { public: Point Location(){ Point p; return p; } };
|
|
|
|
void f()
|
|
{
|
|
Node** node1;
|
|
Line_Segment(node1->Location()); // expected-error {{not a structure or union}}
|
|
}
|
|
}
|
|
|
|
|
|
namespace arrow_suggest {
|
|
|
|
template <typename T>
|
|
class wrapped_ptr {
|
|
public:
|
|
wrapped_ptr(T* ptr) : ptr_(ptr) {}
|
|
T* operator->() { return ptr_; }
|
|
void Check();
|
|
private:
|
|
T *ptr_;
|
|
};
|
|
|
|
class Worker {
|
|
public:
|
|
void DoSomething();
|
|
void Chuck();
|
|
};
|
|
|
|
void test() {
|
|
wrapped_ptr<Worker> worker(new Worker);
|
|
worker.DoSomething(); // expected-error {{no member named 'DoSomething' in 'arrow_suggest::wrapped_ptr<arrow_suggest::Worker>'; did you mean to use '->' instead of '.'?}}
|
|
worker.DoSamething(); // expected-error {{no member named 'DoSamething' in 'arrow_suggest::wrapped_ptr<arrow_suggest::Worker>'}}
|
|
worker.Chuck(); // expected-error {{no member named 'Chuck' in 'arrow_suggest::wrapped_ptr<arrow_suggest::Worker>'}}
|
|
}
|
|
|
|
} // namespace arrow_suggest
|
|
|
|
namespace no_crash_dependent_type {
|
|
|
|
template <class T>
|
|
struct A {
|
|
void call();
|
|
A *operator->();
|
|
};
|
|
|
|
template <class T>
|
|
void foo() {
|
|
// The "requires an initializer" error seems unnecessary.
|
|
A<int> &x = blah[7]; // expected-error {{use of undeclared identifier 'blah'}} \
|
|
// expected-error {{requires an initializer}}
|
|
// x is dependent.
|
|
x->call();
|
|
}
|
|
|
|
void test() {
|
|
foo<int>(); // expected-note {{requested here}}
|
|
}
|
|
|
|
} // namespace no_crash_dependent_type
|
|
|
|
namespace clangd_issue_1073_no_crash_dependent_type {
|
|
|
|
template <typename T> struct Ptr {
|
|
T *operator->();
|
|
};
|
|
|
|
struct Struct {
|
|
int len;
|
|
};
|
|
|
|
template <int>
|
|
struct TemplateStruct {
|
|
Ptr<Struct> val(); // expected-note {{declared here}}
|
|
};
|
|
|
|
template <int I>
|
|
void templateFunc(const TemplateStruct<I> &ts) {
|
|
Ptr<Struct> ptr = ts.val(); // expected-error {{function is not marked const}}
|
|
auto foo = ptr->len;
|
|
}
|
|
|
|
template void templateFunc<0>(const TemplateStruct<0> &); // expected-note {{requested here}}
|
|
|
|
} // namespace clangd_issue_1073_no_crash_dependent_type
|