7c402b8b81
The checks for the 'z' and 't' format specifiers added in the original PR #143653 had some issues and were overly strict, causing some build failures and were consequently reverted at4c85bf2fe8. In the latest commit27c58629ec, I relaxed the checks for the 'z' and 't' format specifiers, so warnings are now only issued when they are used with mismatched types. The original intent of these checks was to diagnose code that assumes the underlying type of `size_t` is `unsigned` or `unsigned long`, for example: ```c printf("%zu", 1ul); // Not portable, but not an error when size_t is unsigned long ``` However, it produced a significant number of false positives. This was partly because Clang does not treat the `typedef` `size_t` and `__size_t` as having a common "sugar" type, and partly because a large amount of existing code either assumes `unsigned` (or `unsigned long`) is `size_t`, or they define the equivalent of size_t in their own way (such as sanitizer_internal_defs.h).2e67dcfdcd/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h (L203)
43 lines
1.8 KiB
C++
43 lines
1.8 KiB
C++
// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only %s -verify
|
|
|
|
extern "C" {
|
|
typedef char * va_list;
|
|
}
|
|
|
|
void test_no_arguments(int i, ...) {
|
|
__va_start(); // expected-error{{too few arguments to function call, expected at least 3, have 0}}
|
|
}
|
|
|
|
void test_one_argument(int i, ...) {
|
|
va_list ap;
|
|
__va_start(&ap); // expected-error{{too few arguments to function call, expected at least 3, have 1}}
|
|
}
|
|
|
|
void test_two_arguments(int i, ...) {
|
|
va_list ap;
|
|
__va_start(&ap, &i); // expected-error{{too few arguments to function call, expected at least 3, have 2}}
|
|
}
|
|
|
|
void test_non_last_argument(int i, int j, ...) {
|
|
va_list ap;
|
|
__va_start(&ap, &i, 4);
|
|
// expected-error@-1{{passing 'int *' to parameter of incompatible type 'const char *': type mismatch at 2nd parameter ('int *' vs 'const char *')}}
|
|
// expected-error@-2{{passing 'int' to parameter of incompatible type '__size_t' (aka 'unsigned int'): type mismatch at 3rd parameter ('int' vs '__size_t' (aka 'unsigned int'))}}
|
|
}
|
|
|
|
void test_stack_allocated(int i, ...) {
|
|
va_list ap;
|
|
int j;
|
|
__va_start(&ap, &j, 4);
|
|
// expected-error@-1{{passing 'int *' to parameter of incompatible type 'const char *': type mismatch at 2nd parameter ('int *' vs 'const char *')}}
|
|
// expected-error@-2{{passing 'int' to parameter of incompatible type '__size_t' (aka 'unsigned int'): type mismatch at 3rd parameter ('int' vs '__size_t' (aka 'unsigned int'))}}
|
|
}
|
|
|
|
void test_non_pointer_addressof(int i, ...) {
|
|
va_list ap;
|
|
__va_start(&ap, 1, 4);
|
|
// expected-error@-1{{passing 'int' to parameter of incompatible type 'const char *': type mismatch at 2nd parameter ('int' vs 'const char *')}}
|
|
// expected-error@-2{{passing 'int' to parameter of incompatible type '__size_t' (aka 'unsigned int'): type mismatch at 3rd parameter ('int' vs '__size_t' (aka 'unsigned int'))}}
|
|
}
|
|
|