91cdd35008
This is a major change on how we represent nested name qualifications in the AST. * The nested name specifier itself and how it's stored is changed. The prefixes for types are handled within the type hierarchy, which makes canonicalization for them super cheap, no memory allocation required. Also translating a type into nested name specifier form becomes a no-op. An identifier is stored as a DependentNameType. The nested name specifier gains a lightweight handle class, to be used instead of passing around pointers, which is similar to what is implemented for TemplateName. There is still one free bit available, and this handle can be used within a PointerUnion and PointerIntPair, which should keep bit-packing aficionados happy. * The ElaboratedType node is removed, all type nodes in which it could previously apply to can now store the elaborated keyword and name qualifier, tail allocating when present. * TagTypes can now point to the exact declaration found when producing these, as opposed to the previous situation of there only existing one TagType per entity. This increases the amount of type sugar retained, and can have several applications, for example in tracking module ownership, and other tools which care about source file origins, such as IWYU. These TagTypes are lazily allocated, in order to limit the increase in AST size. This patch offers a great performance benefit. It greatly improves compilation time for [stdexec](https://github.com/NVIDIA/stdexec). For one datapoint, for `test_on2.cpp` in that project, which is the slowest compiling test, this patch improves `-c` compilation time by about 7.2%, with the `-fsyntax-only` improvement being at ~12%. This has great results on compile-time-tracker as well:  This patch also further enables other optimziations in the future, and will reduce the performance impact of template specialization resugaring when that lands. It has some other miscelaneous drive-by fixes. About the review: Yes the patch is huge, sorry about that. Part of the reason is that I started by the nested name specifier part, before the ElaboratedType part, but that had a huge performance downside, as ElaboratedType is a big performance hog. I didn't have the steam to go back and change the patch after the fact. There is also a lot of internal API changes, and it made sense to remove ElaboratedType in one go, versus removing it from one type at a time, as that would present much more churn to the users. Also, the nested name specifier having a different API avoids missing changes related to how prefixes work now, which could make existing code compile but not work. How to review: The important changes are all in `clang/include/clang/AST` and `clang/lib/AST`, with also important changes in `clang/lib/Sema/TreeTransform.h`. The rest and bulk of the changes are mostly consequences of the changes in API. PS: TagType::getDecl is renamed to `getOriginalDecl` in this patch, just for easier to rebasing. I plan to rename it back after this lands. Fixes #136624 Fixes https://github.com/llvm/llvm-project/issues/43179 Fixes https://github.com/llvm/llvm-project/issues/68670 Fixes https://github.com/llvm/llvm-project/issues/92757
135 lines
4.0 KiB
C++
135 lines
4.0 KiB
C++
// RUN: %clang_cc1 %s -std=c++11 -fcxx-exceptions -fexceptions -fsyntax-only -Wignored-qualifiers -verify
|
|
|
|
int test1() {
|
|
throw;
|
|
}
|
|
|
|
// PR5071
|
|
template<typename T> T f() { }
|
|
|
|
template<typename T>
|
|
void g(T t) {
|
|
return t * 2; // okay
|
|
}
|
|
|
|
template<typename T>
|
|
T h() {
|
|
return 17;
|
|
}
|
|
|
|
// Don't warn on cv-qualified class return types, only scalar return types.
|
|
namespace ignored_quals {
|
|
struct S {};
|
|
const S class_c();
|
|
const volatile S class_cv();
|
|
|
|
const int scalar_c(); // expected-warning{{'const' type qualifier on return type has no effect}}
|
|
int const scalar_c2(); // expected-warning{{'const' type qualifier on return type has no effect}}
|
|
|
|
const
|
|
char*
|
|
const // expected-warning{{'const' type qualifier on return type has no effect}}
|
|
f();
|
|
|
|
char
|
|
const*
|
|
const // expected-warning{{'const' type qualifier on return type has no effect}}
|
|
g();
|
|
|
|
char* const h(); // expected-warning{{'const' type qualifier on return type has no effect}}
|
|
char* volatile i(); // expected-warning{{'volatile' type qualifier on return type has no effect}}
|
|
|
|
char*
|
|
volatile // expected-warning{{'const volatile' type qualifiers on return type have no effect}}
|
|
const
|
|
j();
|
|
|
|
const volatile int scalar_cv(); // expected-warning{{'const volatile' type qualifiers on return type have no effect}}
|
|
|
|
// FIXME: Maintain enough information that we can point the diagnostic at the 'volatile' keyword.
|
|
const
|
|
int S::*
|
|
volatile
|
|
mixed_ret(); // expected-warning {{'volatile' type qualifier on return type has no effect}}
|
|
|
|
const int volatile // expected-warning {{'const volatile' type qualifiers on return type have no effect}}
|
|
(((parens())));
|
|
|
|
_Atomic(int) atomic();
|
|
|
|
_Atomic // expected-warning {{'_Atomic' type qualifier on return type has no effect}}
|
|
int
|
|
atomic();
|
|
|
|
auto trailing_return_type() ->
|
|
const int; // expected-warning {{'const' type qualifier on return type has no effect}}
|
|
|
|
auto trailing_return_type_lambda = [](const int &x) ->
|
|
const int // expected-warning {{'const' type qualifier on return type has no effect}}
|
|
{ return x; };
|
|
|
|
const int ret_array()[4]; // expected-error {{cannot return array}}
|
|
}
|
|
|
|
namespace PR9328 {
|
|
typedef char *PCHAR;
|
|
class Test
|
|
{
|
|
const PCHAR GetName() { return 0; } // expected-warning{{'const' type qualifier on return type has no effect}}
|
|
};
|
|
}
|
|
|
|
class foo {
|
|
operator const int ();
|
|
operator int * const ();
|
|
};
|
|
|
|
namespace PR10057 {
|
|
struct S {
|
|
~S();
|
|
};
|
|
|
|
template <class VarType>
|
|
void Test(const VarType& value) {
|
|
return S() = value;
|
|
}
|
|
}
|
|
|
|
namespace return_has_expr {
|
|
struct S {
|
|
S() {
|
|
return 42; // expected-error {{constructor 'S' should not return a value}}
|
|
}
|
|
~S() {
|
|
return 42; // expected-error {{destructor '~S' should not return a value}}
|
|
}
|
|
};
|
|
}
|
|
|
|
// pr17759
|
|
namespace ctor_returns_void {
|
|
void f() {}
|
|
struct S {
|
|
S() { return f(); } // expected-error {{constructor 'S' must not return void expression}}
|
|
~S() { return f(); } // expected-error {{destructor '~S' must not return void expression}}
|
|
};
|
|
|
|
template <typename T> struct ST {
|
|
ST() { return f(); } // expected-error {{constructor 'ctor_returns_void::ST<T>' must not return void expression}}
|
|
// expected-error@-1 {{constructor 'ST' must not return void expression}}
|
|
~ST() { return f(); } // expected-error {{destructor '~ctor_returns_void::ST<T>' must not return void expression}}
|
|
// expected-error@-1 {{destructor '~ST' must not return void expression}}
|
|
};
|
|
|
|
ST<int> st; // expected-note {{in instantiation of member function 'ctor_returns_void::ST<int>::ST'}}
|
|
// expected-note@-1 {{in instantiation of member function 'ctor_returns_void::ST<int>::~ST'}}
|
|
}
|
|
|
|
void cxx_unresolved_expr() {
|
|
// The use of an undeclared variable tricks clang into building a
|
|
// CXXUnresolvedConstructExpr, and the missing ')' gives it an invalid source
|
|
// location for its rparen. Check that emitting a diag on the range of the
|
|
// expr doesn't assert.
|
|
return int(undeclared, 4; // expected-error {{use of undeclared identifier 'undeclared'}}
|
|
}
|