
This removes the delayed typo correction functionality from Clang (regular typo correction still remains) due to fragility of the solution. An RFC was posted here: https://discourse.llvm.org/t/rfc-removing-support-for-delayed-typo-correction/86631 and while that RFC was asking for folks to consider stepping up to be maintainers, and we did have a few new contributors show some interest, experiments show that it's likely worth it to remove this functionality entirely and focus efforts on improving regular typo correction. This removal fixes ~20 open issues (quite possibly more), improves compile time performance by roughly .3-.4% (https://llvm-compile-time-tracker.com/?config=Overview&stat=instructions%3Au&remote=AaronBallman&sortBy=date), and does not appear to regress diagnostic behavior in a way we wouldn't find acceptable. Fixes #142457 Fixes #139913 Fixes #138850 Fixes #137867 Fixes #137860 Fixes #107840 Fixes #93308 Fixes #69470 Fixes #59391 Fixes #58172 Fixes #46215 Fixes #45915 Fixes #45891 Fixes #44490 Fixes #36703 Fixes #32903 Fixes #23312 Fixes #69874
62 lines
1.4 KiB
C++
62 lines
1.4 KiB
C++
// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
|
|
|
|
namespace PR23186 {
|
|
decltype(ned); // expected-error {{use of undeclared identifier 'ned'}}
|
|
// The code below was triggering an UNREACHABLE in ASTContext::getTypeInfoImpl
|
|
// once the above code failed to recover properly after making the bogus
|
|
// correction of 'ned' to 'new'.
|
|
template <typename>
|
|
struct S {
|
|
enum { V };
|
|
void f() {
|
|
switch (0)
|
|
case V:
|
|
;
|
|
}
|
|
};
|
|
}
|
|
|
|
namespace PR23140 {
|
|
auto lneed = gned.*[] {}; // expected-error-re {{use of undeclared identifier 'gned'{{$}}}}
|
|
|
|
void test(int aaa, int bbb, int thisvar) {
|
|
int thatval = aaa * (bbb + thatvar); // expected-error {{use of undeclared identifier 'thatvar'; did you mean 'thatval'}} \
|
|
expected-note {{'thatval' declared here}}
|
|
}
|
|
}
|
|
|
|
namespace PR18854 {
|
|
void f() {
|
|
for (auto&& x : e) { // expected-error-re {{use of undeclared identifier 'e'{{$}}}}
|
|
auto Functor = [x]() {};
|
|
long Alignment = __alignof__(Functor);
|
|
}
|
|
}
|
|
}
|
|
|
|
namespace NewTypoExprFromResolvingTypoAmbiguity {
|
|
struct A {
|
|
void Swap(A *other);
|
|
};
|
|
|
|
struct pair {
|
|
int first;
|
|
A *second;
|
|
};
|
|
|
|
struct map {
|
|
public:
|
|
void swap(map &x);
|
|
pair find(int x);
|
|
};
|
|
|
|
void run(A *annotations) {
|
|
map new_annotations;
|
|
|
|
auto &annotation = *annotations;
|
|
auto new_it = new_annotations.find(5);
|
|
auto &new_anotation = new_it.second;
|
|
new_annotation->Swap(&annotation); // expected-error {{use of undeclared identifier 'new_annotation'}}
|
|
}
|
|
}
|