fde4b80cb7
Example:
int * const my_var = my_initializer;
Currently when transforming my_var to std::span the fixits:
- replace "int * const my_var = " with "std::span<int> const my_var {"
- add ", SIZE}" after "my_initializer" where SIZE is either inferred or
a placeholder
This patch makes that behavior less intrusive by not modifying variable
cv-qualifiers and initialization syntax.
The new behavior is:
- replace "int *" with "std::span<int>"
- add "{" before "my_initializer"
- add ", SIZE}" after "my_initializer"
This is an improvement on its own - since we don't touch the identifier,
we automatically can handle macros in them.
It also simplifies future work on initializer fixits.
101 lines
2.6 KiB
C++
101 lines
2.6 KiB
C++
// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage \
|
|
// RUN: -fsafe-buffer-usage-suggestions \
|
|
// RUN: -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s
|
|
|
|
void bar(int * param) {}
|
|
|
|
void foo1a() {
|
|
int *r = new int[7];
|
|
// CHECK-NOT: fix-it:"{{.*}}":{[[@LINE-1]]:
|
|
int *p = new int[4];
|
|
// CHECK-NOT: fix-it:"{{.*}}":{[[@LINE-1]]:
|
|
p = r;
|
|
int tmp = p[9];
|
|
int *q;
|
|
q = r; // FIXME: we do not fix `q = r` here as the `.data()` fix-it is not generally correct
|
|
}
|
|
|
|
void uuc_if_body() {
|
|
int *r = new int[7];
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{"
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:22-[[@LINE-3]]:22}:", 7}"
|
|
int *p = new int[4];
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{"
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:22-[[@LINE-3]]:22}:", 4}"
|
|
if (true)
|
|
p = r;
|
|
p[5] = 4;
|
|
}
|
|
|
|
void uuc_if_body1(bool flag) {
|
|
int *r = new int[7];
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{"
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:22-[[@LINE-3]]:22}:", 7}"
|
|
int *p = new int[4];
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{"
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:22-[[@LINE-3]]:22}:", 4}"
|
|
if (flag) {
|
|
p = r;
|
|
}
|
|
p[5] = 4;
|
|
}
|
|
|
|
void uuc_if_body2_ptr_init(bool flag) {
|
|
int *r = new int[7];
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:8}:"std::span<int> "
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-2]]:12-[[@LINE-2]]:12}:"{"
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:22-[[@LINE-3]]:22}:", 7}"
|
|
if (flag) {
|
|
} else {
|
|
int* p = r;
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:5-[[@LINE-1]]:9}:"std::span<int>"
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-2]]:14-[[@LINE-2]]:14}:"{"
|
|
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:15-[[@LINE-3]]:15}:", <# placeholder #>}"
|
|
p[5] = 4;
|
|
}
|
|
}
|
|
|
|
void uuc_if_cond_no_unsafe_op() {
|
|
int *r = new int[7];
|
|
int *p = new int[4];
|
|
if ((p = r)) {
|
|
int x = 0;
|
|
}
|
|
}
|
|
|
|
void uuc_if_cond_unsafe_op() {
|
|
int *r = new int[7];
|
|
int *p = new int[4];
|
|
if ((p = r)) {
|
|
p[3] = 2;
|
|
}
|
|
}
|
|
|
|
void uuc_if_cond_unsafe_op1() {
|
|
int *r = new int[7];
|
|
int *p = new int[4];
|
|
if ((p = r)) {
|
|
r[3] = 2;
|
|
}
|
|
}
|
|
|
|
void uuc_if_cond_unsafe_op2() {
|
|
int *r = new int[7];
|
|
int *p = new int[4];
|
|
if ((p = r)) {
|
|
r[3] = 2;
|
|
}
|
|
p[4] = 6;
|
|
}
|
|
|
|
void uuc_call1() {
|
|
int *w = new int[4];
|
|
int *y = new int[4];
|
|
bar(w = y);
|
|
w[5] = 0;
|
|
}
|