12f78e740c
In preparation of making `-Wreturn-type` default to an error (as there
is virtually no situation where you’d *want* to fall off the end of a
function that is supposed to return a value), this patch fixes tests
that have relied on this being only a warning, of which there seem
to be 3 kinds:
1. Tests which for no apparent reason have a function that triggers the
warning.
I suspect that a lot of these were on accident (or from before the
warning was introduced), since a lot of people will open issues w/ their
problematic code in the `main` function (which is the one case where you
don’t need to return from a non-void function, after all...), which
someone will then copy, possibly into a namespace, possibly renaming it,
the end result of that being that you end up w/ something that
definitely is not `main` anymore, but which still is declared as
returning `int`, and which still has no return statement (another reason
why I think this might apply to a lot of these is because usually the
actual return type of such problematic functions is quite literally
`int`).
A lot of these are really old tests that don’t use `-verify`, which is
why no-one noticed or had to care about the extra warning that was
already being emitted by them until now.
2. Tests which test either `-Wreturn-type`, `[[noreturn]]`, or what
codegen and sanitisers do whenever you do fall off the end of a
function.
3. Tests where I struggle to figure out what is even being tested
(usually because they’re Objective-C tests, and I don’t know
Objective-C), whether falling off the end of a function matters in the
first place, and tests where actually spelling out an expression to
return would be rather cumbersome (e.g. matrix types currently don’t
support list initialisation, so I can’t write e.g. `return {}`).
For tests that fall into categories 2 and 3, I just added
`-Wno-error=return-type` to the `RUN` lines and called it a day. This
was especially necessary for the former since `-Wreturn-type` is an
analysis-based warning, meaning that it is currently impossible to test
for more than one occurrence of it in the same compilation if it
defaults to an error since the analysis pass is skipped for subsequent
functions as soon as an error is emitted.
I’ve also added `-Werror=return-type` to a few tests that I had already
updated as this patch was previously already making the warning an error
by default, but we’ve decided to split that into two patches instead.
196 lines
3.4 KiB
Objective-C
196 lines
3.4 KiB
Objective-C
// RUN: %clang_analyze_cc1 -analyzer-config eagerly-assume=false %s -analyzer-checker=osx.cocoa.RetainCount,deadcode.DeadStores,core -analyzer-output=plist -analyzer-config deadcode.DeadStores:ShowFixIts=true -o %t.plist
|
||
// RUN: %normalize_plist <%t.plist | diff -ub %S/Inputs/expected-plists/plist-output.m.plist -
|
||
|
||
void test_null_init(void) {
|
||
int *p = 0;
|
||
*p = 0xDEADBEEF;
|
||
}
|
||
|
||
void test_null_assign(void) {
|
||
int *p;
|
||
p = 0;
|
||
*p = 0xDEADBEEF;
|
||
}
|
||
|
||
void test_null_assign_transitive(void) {
|
||
int *p;
|
||
p = 0;
|
||
int *q = p;
|
||
*q = 0xDEADBEEF;
|
||
}
|
||
|
||
void test_null_cond(int *p) {
|
||
if (!p) {
|
||
*p = 0xDEADBEEF;
|
||
}
|
||
}
|
||
|
||
void test_null_cond_transitive(int *q) {
|
||
if (!q) {
|
||
int *p = q;
|
||
*p = 0xDEADBEEF;
|
||
}
|
||
}
|
||
|
||
void test_null_field(void) {
|
||
struct s { int *p; } x;
|
||
x.p = 0;
|
||
*(x.p) = 0xDEADBEEF;
|
||
}
|
||
|
||
void test_assumptions(int a, int b)
|
||
{
|
||
if (a == 0) {
|
||
return;
|
||
}
|
||
if (b != 0) {
|
||
return;
|
||
}
|
||
int *p = 0;
|
||
*p = 0xDEADBEEF;
|
||
}
|
||
|
||
int *bar_cond_assign(void);
|
||
int test_cond_assign(void) {
|
||
int *p;
|
||
if (p = bar_cond_assign())
|
||
return 1;
|
||
return *p;
|
||
}
|
||
|
||
// The following previously crashed when generating extensive diagnostics.
|
||
@interface RDar10797980_help
|
||
@property (readonly) int x;
|
||
@end
|
||
|
||
@interface RDar10797980 {
|
||
RDar10797980_help *y;
|
||
}
|
||
- (void) test;
|
||
@end
|
||
|
||
@implementation RDar10797980
|
||
- (void) test {
|
||
if (y.x == 1) {
|
||
int *p = 0;
|
||
*p = 0xDEADBEEF; // expected-warning {{deference}}
|
||
}
|
||
}
|
||
|
||
// The original source for the above Radar contains another problem:
|
||
// if the end-of-path node is an implicit statement, it may not have a valid
|
||
// source location.
|
||
- (void)test2 {
|
||
if (bar_cond_assign()) {
|
||
id foo = [[RDar10797980 alloc] init]; // leak
|
||
}
|
||
(void)y; // first statement after the 'if' is an implicit 'self' DeclRefExpr
|
||
}
|
||
|
||
@end
|
||
|
||
// Test that loops are documented in the path.
|
||
void rdar12280665(void) {
|
||
for (unsigned i = 0; i < 2; ++i) {
|
||
if (i == 1) {
|
||
int *p = 0;
|
||
*p = 0xDEADBEEF; // expected-warning {{dereference}}
|
||
}
|
||
}
|
||
}
|
||
|
||
// Test for a "loop executed 0 times" diagnostic.
|
||
int *radar12322528_bar(void);
|
||
|
||
void radar12322528_for(int x) {
|
||
int *p = 0;
|
||
for (unsigned i = 0; i < x; ++i) {
|
||
p = radar12322528_bar();
|
||
}
|
||
*p = 0xDEADBEEF;
|
||
}
|
||
|
||
void radar12322528_while(int x) {
|
||
int *p = 0;
|
||
unsigned i = 0;
|
||
for ( ; i < x ; ) {
|
||
++i;
|
||
p = radar12322528_bar();
|
||
}
|
||
*p = 0xDEADBEEF;
|
||
}
|
||
|
||
void radar12322528_foo_2(void) {
|
||
int *p = 0;
|
||
for (unsigned i = 0; i < 2; ++i) {
|
||
if (i == 1)
|
||
break;
|
||
}
|
||
*p = 0xDEADBEEF;
|
||
}
|
||
|
||
void test_loop_diagnostics(void) {
|
||
int *p = 0;
|
||
for (int i = 0; i < 2; ++i) { p = 0; }
|
||
*p = 1;
|
||
}
|
||
|
||
void test_loop_diagnostics_2(void) {
|
||
int *p = 0;
|
||
for (int i = 0; i < 2; ) {
|
||
++i;
|
||
p = 0;
|
||
}
|
||
*p = 1;
|
||
}
|
||
|
||
void test_loop_diagnostics_3(void) {
|
||
int *p = 0;
|
||
int i = 0;
|
||
while (i < 2) {
|
||
++i;
|
||
p = 0;
|
||
}
|
||
*p = 1;
|
||
}
|
||
|
||
void test_loop_fast_enumeration(id arr) {
|
||
int x;
|
||
for (id obj in arr) {
|
||
x = 1;
|
||
}
|
||
x += 1;
|
||
}
|
||
|
||
@interface RDar12114812 { char *p; }
|
||
@end
|
||
|
||
@implementation RDar12114812
|
||
- (void)test {
|
||
p = 0;
|
||
*p = 1;
|
||
}
|
||
@end
|
||
|
||
// Test diagnostics for initialization of structs.
|
||
void RDar13295437_f(void *i) __attribute__((__nonnull__));
|
||
|
||
struct RDar13295437_S { int *i; };
|
||
|
||
void RDar13295437(void) {
|
||
struct RDar13295437_S s = {0};
|
||
struct RDar13295437_S *sp = &s;
|
||
RDar13295437_f(sp->i);
|
||
}
|
||
|
||
@interface Foo
|
||
- (int *) returnsPointer;
|
||
@end
|
||
|
||
int testFoo(Foo *x) {
|
||
if (x)
|
||
return 1;
|
||
return *[x returnsPointer];
|
||
}
|
||
|