c555c8d554
This addresses post-commit review feedback from someone who discovered
that we diagnosed code like the following:
```
struct S {
int len;
const char fam[];
} s;
```
despite it being invalid to initialize the flexible array member.
Note, this applies to flexible array members and zero-sized arrays at
the end of a structure (an old-style flexible array member), but it does
not apply to one-sized arrays at the end of a structure because those do
occupy storage that can be initialized.
133 lines
8.3 KiB
C
133 lines
8.3 KiB
C
// Both of these should enable everything.
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=unsafe-var-compat,unsafe-field-compat,zero-init-var,zero-init-field -Wc++-compat -Wno-tentative-definition-compat -fstrict-flex-arrays=2 %s
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=unsafe-var,unsafe-field,zero-init-var,zero-init-field,unsafe-field-restricted-flex -Wdefault-const-init -fstrict-flex-arrays=2 %s
|
|
|
|
// This should enable nothing.
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=good -Wno-default-const-init-unsafe %s
|
|
|
|
// Only unsafe field and variable diagnostics
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=unsafe-var,unsafe-field,unsafe-field-restricted-flex -fstrict-flex-arrays=2 %s
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=unsafe-var,unsafe-field,unsafe-field-restricted-flex -Wdefault-const-init-unsafe -fstrict-flex-arrays=2 %s
|
|
|
|
// Only zero init field and variable diagnostics
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=zero-init-var,zero-init-field -Wdefault-const-init -Wno-default-const-init-unsafe %s
|
|
|
|
// Only zero init and unsafe field diagnostics
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=zero-init-field,unsafe-field,unsafe-field-restricted-flex -Wno-default-const-init-var-unsafe -Wdefault-const-init-field -fstrict-flex-arrays=2 %s
|
|
|
|
// Only zero init and unsafe variable diagnostics
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=zero-init-var,unsafe-var -Wno-default-const-init-field-unsafe -Wdefault-const-init-var %s
|
|
|
|
// Only unsafe field diagnostics, but with flexible arrays set to any kind of array
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=unsafe-field -Wno-default-const-init-var-unsafe -Wdefault-const-init-field-unsafe -fstrict-flex-arrays=0 %s
|
|
|
|
// C++ tests
|
|
// RUN: %clang_cc1 -fsyntax-only -verify=cxx -x c++ %s
|
|
|
|
// good-no-diagnostics
|
|
|
|
struct A { int i; };
|
|
struct S{ const int i; }; // unsafe-field-note 2 {{member 'i' declared 'const' here}} \
|
|
unsafe-field-compat-note 2 {{member 'i' declared 'const' here}} \
|
|
cxx-note 3 {{default constructor of 'S' is implicitly deleted because field 'i' of const-qualified type 'const int' would not be initialized}}
|
|
struct T { struct S s; }; // cxx-note {{default constructor of 'T' is implicitly deleted because field 's' has a deleted default constructor}}
|
|
struct U { struct S s; const int j; };
|
|
struct V { int i; const struct A a; }; // unsafe-field-note {{member 'a' declared 'const' here}} \
|
|
unsafe-field-compat-note {{member 'a' declared 'const' here}} \
|
|
cxx-note {{default constructor of 'V' is implicitly deleted because field 'a' of const-qualified type 'const struct A' would not be initialized}}
|
|
struct W { struct A a; const int j; }; // unsafe-field-note {{member 'j' declared 'const' here}} \
|
|
unsafe-field-compat-note {{member 'j' declared 'const' here}} \
|
|
cxx-note {{default constructor of 'W' is implicitly deleted because field 'j' of const-qualified type 'const int' would not be initialized}}
|
|
union Z1 { int i; const int j; };
|
|
union Z2 { int i; const struct A a; };
|
|
|
|
void f() {
|
|
struct S s1; // unsafe-field-warning {{default initialization of an object of type 'struct S' with const member leaves the object uninitialized}} \
|
|
unsafe-field-compat-warning {{default initialization of an object of type 'struct S' with const member leaves the object uninitialized and is incompatible with C++}} \
|
|
cxx-error {{call to implicitly-deleted default constructor of 'struct S'}}
|
|
struct S s2 = { 0 };
|
|
}
|
|
void g() {
|
|
struct T t1; // unsafe-field-warning {{default initialization of an object of type 'struct T' with const member leaves the object uninitialized}} \
|
|
unsafe-field-compat-warning {{default initialization of an object of type 'struct T' with const member leaves the object uninitialized and is incompatible with C++}} \
|
|
cxx-error {{call to implicitly-deleted default constructor of 'struct T'}}
|
|
struct T t2 = { { 0 } };
|
|
}
|
|
void h() {
|
|
struct U u1 = { { 0 } };
|
|
struct U u2 = { { 0 }, 0 };
|
|
}
|
|
void x() {
|
|
struct V v1; // unsafe-field-warning {{default initialization of an object of type 'struct V' with const member leaves the object uninitialized}} \
|
|
unsafe-field-compat-warning {{default initialization of an object of type 'struct V' with const member leaves the object uninitialized and is incompatible with C++}} \
|
|
cxx-error {{call to implicitly-deleted default constructor of 'struct V'}}
|
|
struct V v2 = { 0 };
|
|
struct V v3 = { 0, { 0 } };
|
|
}
|
|
void y() {
|
|
struct W w1; // unsafe-field-warning {{default initialization of an object of type 'struct W' with const member leaves the object uninitialized}} \
|
|
unsafe-field-compat-warning {{default initialization of an object of type 'struct W' with const member leaves the object uninitialized and is incompatible with C++}} \
|
|
cxx-error {{call to implicitly-deleted default constructor of 'struct W'}}
|
|
struct W w2 = { 0 };
|
|
struct W w3 = { { 0 }, 0 };
|
|
}
|
|
void z() {
|
|
// Note, we explicitly do not diagnose default initialization of unions with
|
|
// a const member. Those can be reasonable, the only problematic case is if
|
|
// the only member of the union is const, but that's a very odd situation to
|
|
// begin with so we accept it as a false negative.
|
|
union Z1 z1;
|
|
union Z2 z2;
|
|
}
|
|
|
|
// Test a tentative definition which does eventually get an initializer.
|
|
extern const int i;
|
|
const int i = 12;
|
|
|
|
static const int j; // zero-init-var-warning {{default initialization of an object of type 'const int' is incompatible with C++}} \
|
|
cxx-error {{default initialization of an object of const type 'const int'}}
|
|
const int k; // zero-init-var-warning {{default initialization of an object of type 'const int' is incompatible with C++}} \
|
|
cxx-error {{default initialization of an object of const type 'const int'}}
|
|
const struct S s; // zero-init-var-warning {{default initialization of an object of type 'const struct S' is incompatible with C++}} \
|
|
cxx-error {{call to implicitly-deleted default constructor of 'const struct S'}}
|
|
const union Z1 z3; // zero-init-var-warning {{default initialization of an object of type 'const union Z1' is incompatible with C++}} \
|
|
cxx-error {{default initialization of an object of const type 'const union Z1' without a user-provided default constructor}}
|
|
|
|
void func() {
|
|
const int a; // unsafe-var-warning {{default initialization of an object of type 'const int' leaves the object uninitialized}} \
|
|
unsafe-var-compat-warning {{default initialization of an object of type 'const int' leaves the object uninitialized and is incompatible with C++}} \
|
|
cxx-error {{default initialization of an object of const type 'const int'}}
|
|
static const int b; // zero-init-var-warning {{default initialization of an object of type 'const int' is incompatible with C++}} \
|
|
cxx-error {{default initialization of an object of const type 'const int'}}
|
|
}
|
|
|
|
// Test the behavior of flexible array members. Those cannot be initialized
|
|
// when a stack-allocated object of the structure type is created. We handle
|
|
// degenerate flexible arrays based on -fstrict-flex-arrays. Note that C++ does
|
|
// not have flexible array members at all, which is why the test is disabled
|
|
// there.
|
|
#ifndef __cplusplus
|
|
struct RealFAM {
|
|
int len;
|
|
const char fam[];
|
|
};
|
|
|
|
struct FakeFAM {
|
|
int len;
|
|
const char fam[0];
|
|
};
|
|
|
|
struct NotTreatedAsAFAM {
|
|
int len;
|
|
const char fam[1]; // unsafe-field-restricted-flex-note {{member 'fam' declared 'const' here}} \
|
|
unsafe-field-compat-note {{member 'fam' declared 'const' here}}
|
|
};
|
|
|
|
void test_fams() {
|
|
struct RealFAM One;
|
|
struct FakeFAM Two;
|
|
struct NotTreatedAsAFAM Three; // unsafe-field-restricted-flex-warning {{default initialization of an object of type 'struct NotTreatedAsAFAM' with const member leaves the object uninitialized}} \
|
|
unsafe-field-compat-warning {{default initialization of an object of type 'struct NotTreatedAsAFAM' with const member leaves the object uninitialized and is incompatible with C++}}
|
|
}
|
|
#endif // !defined(__cplusplus)
|