0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
127 lines
2.9 KiB
Objective-C
127 lines
2.9 KiB
Objective-C
// RUN: %clang_cc1 -x objective-c -fsyntax-only -verify -Wno-objc-root-class %s
|
|
// RUN: %clang_cc1 -x objective-c++ -fsyntax-only -verify -Wno-objc-root-class %s
|
|
|
|
@interface StopAccessingIvarsDirectlyExample
|
|
@property(strong) id name, rank, serialNumber;
|
|
@end
|
|
|
|
@implementation StopAccessingIvarsDirectlyExample
|
|
|
|
- (void)identifyYourSelf {
|
|
if (self.name && self.rank && self.serialNumber)
|
|
self.name = 0;
|
|
}
|
|
|
|
// @synthesize name, rank, serialNumber;
|
|
// default synthesis allows direct access to property ivars.
|
|
- (id)init {
|
|
_name = _rank = _serialNumber = 0;
|
|
return self;
|
|
}
|
|
|
|
- (void)dealloc {
|
|
}
|
|
@end
|
|
|
|
|
|
// Test2
|
|
@interface Test2
|
|
@property(strong, nonatomic) id object;
|
|
@end
|
|
|
|
// object has user declared setter/getter so it won't be
|
|
// default synthesized; thus causing user error.
|
|
@implementation Test2
|
|
- (id) bar { return object; } // expected-error {{use of undeclared identifier 'object'}}
|
|
- (void)setObject:(id)newObject {}
|
|
- (id)object { return 0; }
|
|
@end
|
|
|
|
// Test3
|
|
@interface Test3
|
|
{
|
|
id uid; // expected-note {{instance variable is declared here}}
|
|
}
|
|
@property (readwrite, assign) id uid; // expected-note {{property declared here}}
|
|
@end
|
|
|
|
@implementation Test3 // expected-warning {{autosynthesized property 'uid' will use synthesized instance variable '_uid', not existing instance variable 'uid'}}
|
|
// Oops, forgot to write @synthesize! will be default synthesized
|
|
- (void) myMethod {
|
|
self.uid = 0; // Use of the “setter”
|
|
uid = 0; // Use of the wrong instance variable
|
|
_uid = 0; // Use of the property instance variable
|
|
}
|
|
@end
|
|
|
|
@interface Test4 {
|
|
id _var;
|
|
}
|
|
@property (readwrite, assign) id var;
|
|
@end
|
|
|
|
|
|
// default synthesize property named 'var'
|
|
@implementation Test4
|
|
- (id) myMethod {
|
|
return self->_var; // compiles because 'var' is synthesized by default
|
|
}
|
|
@end
|
|
|
|
@interface Test5
|
|
{
|
|
id _var;
|
|
}
|
|
@property (readwrite, assign) id var;
|
|
@end
|
|
|
|
// default synthesis of property 'var'
|
|
@implementation Test5
|
|
- (id) myMethod {
|
|
Test5 *foo = 0;
|
|
return foo->_var; // OK
|
|
}
|
|
@end
|
|
|
|
@interface Test6
|
|
{
|
|
id _var; // expected-note {{'_var' declared here}}
|
|
}
|
|
@property (readwrite, assign) id var;
|
|
@end
|
|
|
|
// no default synthesis. So error is expected.
|
|
@implementation Test6
|
|
- (id) myMethod
|
|
{
|
|
return var; // expected-error {{use of undeclared identifier 'var'}}
|
|
}
|
|
@synthesize var = _var;
|
|
@end
|
|
|
|
int* _object;
|
|
|
|
@interface Test7
|
|
@property (readwrite, assign) id object;
|
|
@end
|
|
|
|
// With default synthesis, '_object' is be the synthesized ivar not the global
|
|
// 'int*' object. So no error.
|
|
@implementation Test7
|
|
- (id) myMethod {
|
|
return _object;
|
|
}
|
|
@end
|
|
|
|
@interface Test8
|
|
{
|
|
id _y;
|
|
id y; // expected-note {{instance variable is declared here}}
|
|
}
|
|
@property(copy) id y; // expected-note {{property declared here}}
|
|
@end
|
|
|
|
|
|
@implementation Test8 @end // expected-warning {{autosynthesized property 'y' will use instance variable '_y', not existing instance variable 'y'}}
|
|
|