0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
59 lines
1.6 KiB
Objective-C
59 lines
1.6 KiB
Objective-C
// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fsyntax-only -verify %s -fobjc-arc
|
|
//
|
|
// These tests exist as a means to help ensure that diagnostics aren't printed
|
|
// in overload resolution in ObjC.
|
|
|
|
struct Type1 { int a; };
|
|
typedef const __attribute__((objc_bridge(id))) void * CFTypeRef;
|
|
@interface Iface1 @end
|
|
|
|
@interface NeverCalled
|
|
- (void) test:(struct Type1 *)arg;
|
|
- (void) test2:(CFTypeRef)arg;
|
|
@end
|
|
|
|
@interface TakesIface1
|
|
- (void) test:(Iface1 *)arg;
|
|
- (void) test2:(Iface1 *)arg;
|
|
@end
|
|
|
|
// PR26085
|
|
void testTakesIface1(id x, Iface1 *arg) {
|
|
// This should resolve silently to `TakesIface1`.
|
|
[x test:arg];
|
|
[x test2:arg];
|
|
}
|
|
|
|
@class NSString;
|
|
@interface NeverCalledv2
|
|
- (void) testStr:(NSString *)arg;
|
|
@end
|
|
|
|
@interface TakesVanillaConstChar
|
|
- (void) testStr:(const void *)a;
|
|
@end
|
|
|
|
// Not called out explicitly by PR26085, but related.
|
|
void testTakesNSString(id x) {
|
|
// Overload resolution should not emit a diagnostic about needing to add an
|
|
// '@' before "someStringLiteral".
|
|
[x testStr:"someStringLiteral"];
|
|
}
|
|
|
|
id CreateSomething(void);
|
|
|
|
@interface TakesCFTypeRef
|
|
- (void) testCFTypeRef:(CFTypeRef)arg;
|
|
@end
|
|
|
|
@interface NeverCalledv3
|
|
- (void) testCFTypeRef:(struct Type1 *)arg;
|
|
@end
|
|
|
|
// Not called out explicitly by PR26085, but related.
|
|
void testTakesCFTypeRef(id x) {
|
|
// Overload resolution should occur silently, select the CFTypeRef overload,
|
|
// and produce a single complaint. (with notes)
|
|
[x testCFTypeRef:CreateSomething()]; // expected-error{{implicit conversion of Objective-C pointer type 'id' to C pointer type 'CFTypeRef'}} expected-note{{use __bridge}} expected-note{{use __bridge_retained}}
|
|
}
|