0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
118 lines
4.6 KiB
Plaintext
118 lines
4.6 KiB
Plaintext
// RUN: %clang_cc1 -fblocks -fobjc-arc -fobjc-runtime-has-weak %s -verify
|
|
|
|
__attribute__((objc_root_class))
|
|
@interface NSObject
|
|
@end
|
|
|
|
@class Forward;
|
|
@class Forward2;
|
|
|
|
// Tests for generic arguments.
|
|
|
|
@interface PC1<T> : NSObject
|
|
- (T) get;
|
|
- (void) set: (T) v; // expected-note 4{{passing argument to}}
|
|
@end
|
|
|
|
void test1a(PC1<__weak id> *obj) { // expected-error {{type argument '__weak id' cannot be qualified with '__weak'}}
|
|
id x = [obj get];
|
|
[obj set: x];
|
|
}
|
|
|
|
void test1b(PC1<__strong id> *obj) { // expected-error {{type argument '__strong id' cannot be qualified with '__strong'}}
|
|
id x = [obj get];
|
|
[obj set: x];
|
|
}
|
|
|
|
void test1c(PC1<id> *obj) {
|
|
id x = [obj get];
|
|
[obj set: x];
|
|
}
|
|
|
|
// Test that this doesn't completely kill downstream type-checking.
|
|
void test1d(PC1<__weak Forward*> *obj) { // expected-error {{type argument 'Forward *__weak' cannot be qualified with '__weak'}}
|
|
Forward2 *x = [obj get]; // expected-error {{cannot initialize}}
|
|
[obj set: x]; // expected-error {{cannot initialize a parameter of type 'Forward *' with an lvalue of type 'Forward2 *__strong'}}
|
|
}
|
|
|
|
void test1e(PC1<__strong Forward*> *obj) { // expected-error {{type argument 'Forward *__strong' cannot be qualified with '__strong'}}
|
|
Forward2 *x = [obj get]; // expected-error {{cannot initialize}}
|
|
[obj set: x]; // expected-error {{cannot initialize a parameter of type 'Forward *'}}
|
|
}
|
|
|
|
void test1f(PC1<Forward*> *obj) {
|
|
Forward2 *x = [obj get]; // expected-error {{cannot initialize}}
|
|
[obj set: x]; // expected-error {{cannot initialize a parameter of type 'Forward *'}}
|
|
}
|
|
|
|
// Typedefs are fine, just silently ignore them.
|
|
typedef __strong id StrongID;
|
|
void test1g(PC1<StrongID> *obj) {
|
|
Forward2 *x = [obj get];
|
|
[obj set: x];
|
|
}
|
|
|
|
typedef __strong Forward *StrongForward;
|
|
void test1h(PC1<StrongForward> *obj) {
|
|
Forward2 *x = [obj get]; // expected-error {{cannot initialize}}
|
|
[obj set: x]; // expected-error {{cannot initialize a parameter of type 'Forward *'}}
|
|
}
|
|
|
|
// These aren't really ARC-specific, but they're the same basic idea.
|
|
void test1i(PC1<const id> *obj) { // expected-error {{type argument 'const id' cannot be qualified with 'const'}}
|
|
id x = [obj get];
|
|
[obj set: x];
|
|
}
|
|
|
|
void test1j(PC1<volatile id> *obj) { // expected-error {{type argument 'volatile id' cannot be qualified with 'volatile'}}
|
|
id x = [obj get];
|
|
[obj set: x];
|
|
}
|
|
|
|
void test1k(PC1<__attribute__((address_space(256))) id> *obj) { // expected-error {{type argument '__attribute__((address_space(256))) id' cannot be qualified with '__attribute__((address_space(256)))'}}
|
|
id x = [obj get];
|
|
[obj set: x];
|
|
}
|
|
|
|
// Template-specific tests.
|
|
template <class T> PC1<T> *test2_temp();
|
|
void test2a() { test2_temp<id>(); }
|
|
void test2b() { test2_temp<const id>(); }
|
|
void test2c() { test2_temp<volatile id>(); }
|
|
void test2d() { test2_temp<__strong id>(); }
|
|
void test2e() { test2_temp<__weak id>(); }
|
|
void test2f() { test2_temp<__attribute__((address_space(256))) id>(); }
|
|
|
|
template <class T> PC1<const T> *test3a(); // expected-error {{type argument 'const T' cannot be qualified with 'const'}}
|
|
template <class T> PC1<__strong T> *test3b(); // expected-error {{type argument '__strong T' cannot be qualified with '__strong'}}
|
|
|
|
// Tests for generic parameter bounds.
|
|
|
|
@interface PC2<T : __strong id> // expected-error {{type bound '__strong id' for type parameter 'T' cannot be qualified with '__strong'}}
|
|
@end
|
|
|
|
@interface PC3<T : __weak id> // expected-error {{type bound '__weak id' for type parameter 'T' cannot be qualified with '__weak'}}
|
|
@end
|
|
|
|
@interface PC4<T : __strong Forward*> // expected-error {{type bound 'Forward *__strong' for type parameter 'T' cannot be qualified with '__strong'}}
|
|
@end
|
|
|
|
@interface PC5<T : __weak Forward*> // expected-error {{type bound 'Forward *__weak' for type parameter 'T' cannot be qualified with '__weak'}}
|
|
@end
|
|
|
|
@interface PC6<T : StrongID> // expected-error {{type bound 'StrongID' (aka '__strong id') for type parameter 'T' cannot be qualified with '__strong'}}
|
|
@end
|
|
|
|
@interface PC7<T : StrongForward> // expected-error {{type bound 'StrongForward' (aka 'Forward *__strong') for type parameter 'T' cannot be qualified with '__strong'}}
|
|
@end
|
|
|
|
// These aren't really ARC-specific, but they're the same basic idea.
|
|
@interface PC8<T : const id> // expected-error {{type bound 'const id' for type parameter 'T' cannot be qualified with 'const'}}
|
|
@end
|
|
|
|
@interface PC9<T : volatile id> // expected-error {{type bound 'volatile id' for type parameter 'T' cannot be qualified with 'volatile'}}
|
|
@end
|
|
|
|
@interface PC10<T : __attribute__((address_space(256))) id> // expected-error {{type bound '__attribute__((address_space(256))) id' for type parameter 'T' cannot be qualified with '__attribute__((address_space(256)))'}}
|
|
@end
|