7553bad1ac
LICM currently requests optimized use MSSA form. This is wasteful, because LICM doesn't actually care about most uses, only those of invariant pointers in loops. Everything else doesn't need to be optimized. LICM already uses the clobber walker in most places. This patch adjusts one place that was using getDefiningAccess() to use it as well, so we no longer have a dependence on pre-optimized uses. This change is not NFC in that the fallback on the defining access when there are too many clobber calls may now fall back to an unoptimized use. In practice, I've not seen any problems with this though. If desired, we could also increase licm-mssa-optimization-cap to a higher value (increasing this from 100 to 200 has no impact on average compile-time -- but also doesn't appear to have any impact on LICM quality either). This makes for a 0.9% geomean compile-time improvement on CTMark. Differential Revision: https://reviews.llvm.org/D147437
73 lines
2.5 KiB
LLVM
73 lines
2.5 KiB
LLVM
; RUN: opt -disable-output -aa-pipeline=basic-aa -passes='loop-mssa(licm),print<memoryssa>' < %s 2>&1 | FileCheck %s
|
|
|
|
|
|
@a = external dso_local global i16, align 1
|
|
@c = external dso_local global i16, align 1
|
|
|
|
; CHECK-LABEL: @main()
|
|
|
|
; CHECK: entry:
|
|
; CHECK-NEXT: %res.addr.i = alloca i16
|
|
; CHECK-NEXT: ; MemoryUse(liveOnEntry)
|
|
; CHECK-NEXT: %c.promoted = load i16, ptr @c
|
|
; CHECK-NEXT: br label %for.cond.i
|
|
|
|
; CHECK: for.cond.i:
|
|
; CHECK-NEXT: ; [[NO5:.*]] = MemoryPhi({entry,liveOnEntry},{f.exit.i,[[NO5]]})
|
|
; CHECK-NEXT: %inc.i1 = phi i16 [ %inc.i, %f.exit.i ], [ %c.promoted, %entry ]
|
|
; CHECK-NEXT: %inc.i = add nsw i16 %inc.i1, 1
|
|
; CHECK-NEXT: br i1 false, label %f.exit.thread.i, label %f.exit.i
|
|
|
|
; CHECK: f.exit.thread.i:
|
|
; CHECK-NEXT: %inc.i.lcssa = phi i16 [ %inc.i, %for.cond.i ]
|
|
; CHECK-NEXT: ; [[NO6:.*]] = MemoryDef([[NO5]])
|
|
; CHECK-NEXT: store i16 %inc.i.lcssa, ptr @c, align 1
|
|
; CHECK-NEXT: ; [[NO2:.*]] = MemoryDef([[NO6]])
|
|
; CHECK-NEXT: store i16 1, ptr @a, align 1
|
|
; CHECK-NEXT: ; MemoryUse([[NO6]])
|
|
; CHECK-NEXT: %tmp2 = load i16, ptr @c, align 1
|
|
; CHECK-NEXT: br label %g.exit
|
|
|
|
; CHECK: f.exit.i
|
|
; CHECK-NEXT: br i1 false, label %g.exit.loopexit, label %for.cond.i
|
|
|
|
; CHECK: g.exit.loopexit:
|
|
; CHECK-NEXT: %inc.i.lcssa2 = phi i16 [ %inc.i, %f.exit.i ]
|
|
; CHECK-NEXT: ; [[NO7:.*]] = MemoryDef([[NO5]])
|
|
; CHECK-NEXT: store i16 %inc.i.lcssa2, ptr @c, align 1
|
|
; CHECK-NEXT: br label %g.exit
|
|
|
|
; CHECK: g.exit
|
|
; CHECK-NEXT: ; [[NO4:.*]] = MemoryPhi({f.exit.thread.i,[[NO2]]},{g.exit.loopexit,[[NO7]]})
|
|
; CHECK-NEXT: ; MemoryUse([[NO4]])
|
|
; CHECK-NEXT: %tmp1 = load i16, ptr @c, align 1
|
|
; CHECK-NEXT: ; [[NO3:.*]] = MemoryDef([[NO4]])
|
|
; CHECK-NEXT: store i16 %tmp1, ptr %res.addr.i, align 1
|
|
; CHECK-NEXT: ret void
|
|
|
|
define dso_local void @main() {
|
|
entry:
|
|
%res.addr.i = alloca i16, align 1
|
|
br label %for.cond.i
|
|
|
|
for.cond.i: ; preds = %f.exit.i, %entry
|
|
%tmp0 = load i16, ptr @c, align 1
|
|
%inc.i = add nsw i16 %tmp0, 1
|
|
store i16 %inc.i, ptr @c, align 1
|
|
br i1 false, label %f.exit.thread.i, label %f.exit.i
|
|
|
|
f.exit.thread.i: ; preds = %for.cond.i
|
|
store i16 1, ptr @a, align 1
|
|
%tmp2 = load i16, ptr @c, align 1
|
|
br label %g.exit
|
|
|
|
f.exit.i: ; preds = %for.cond.i
|
|
br i1 false, label %g.exit, label %for.cond.i
|
|
|
|
g.exit: ; preds = %f.exit.i, %f.exit.thread.i
|
|
%tmp1 = load i16, ptr @c, align 1
|
|
store i16 %tmp1, ptr %res.addr.i, align 1
|
|
ret void
|
|
}
|
|
|