094572701d
This patch makes the final major change of the RemoveDIs project, changing the default IR output from debug intrinsics to debug records. This is expected to break a large number of tests: every single one that tests for uses or declarations of debug intrinsics and does not explicitly disable writing records. If this patch has broken your downstream tests (or upstream tests on a configuration I wasn't able to run): 1. If you need to immediately unblock a build, pass `--write-experimental-debuginfo=false` to LLVM's option processing for all failing tests (remember to use `-mllvm` for clang/flang to forward arguments to LLVM). 2. For most test failures, the changes are trivial and mechanical, enough that they can be done by script; see the migration guide for a guide on how to do this: https://llvm.org/docs/RemoveDIsDebugInfo.html#test-updates 3. If any tests fail for reasons other than FileCheck check lines that need updating, such as assertion failures, that is most likely a real bug with this patch and should be reported as such. For more information, see the recent PSA: https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578
70 lines
3.3 KiB
LLVM
70 lines
3.3 KiB
LLVM
; RUN: llc -start-before=codegenprepare -stop-after=codegenprepare -mtriple=x86_64-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: llc -start-before=codegenprepare -stop-after=codegenprepare -mtriple=x86_64-unknown-unknown %s -o - --try-experimental-debuginfo-iterators | FileCheck %s
|
|
;
|
|
; CGP duplicates address calculation into each basic block that contains loads
|
|
; or stores, so that they can be folded into instruction memory operands for
|
|
; example. dbg.value's should be redirected to identify such local address
|
|
; computations, to give the best opportunity for variable locations to be
|
|
; preserved.
|
|
; This test has two dbg.values in it, one before and one after the relevant
|
|
; memory instruction. Test that the one before does _not_ get updated (as that
|
|
; would either make it use-before-def or shift when the variable appears), and
|
|
; that the dbg.value after the memory instruction does get updated.
|
|
|
|
define dso_local i8 @foo(ptr %p, i32 %cond) !dbg !7 {
|
|
entry:
|
|
; There should be no dbg.values in this block.
|
|
; CHECK-LABEL: entry:
|
|
; CHECK-NOT: #dbg_value
|
|
%arith = getelementptr i8, ptr %p, i32 3
|
|
%load1 = load i8, ptr %arith
|
|
%cmpresult = icmp eq i32 %cond, 0
|
|
br i1 %cmpresult, label %next, label %ret
|
|
|
|
next:
|
|
; Address calcs should be duplicated into this block. One dbg.value should be
|
|
; updated, and the other should not.
|
|
; CHECK-LABEL: next:
|
|
; CHECK: #dbg_value(ptr %arith, ![[DIVAR:[0-9]+]],
|
|
; CHECK-SAME: !DIExpression()
|
|
; CHECK-NEXT: %[[GEPVAR:[0-9a-zA-Z]+]] = getelementptr i8, ptr %p,
|
|
; CHECK-SAME: i64 3
|
|
; CHECK-NEXT: %loaded = load i8, ptr %[[GEPVAR]]
|
|
; CHECK-NEXT: #dbg_value(ptr %[[GEPVAR]],
|
|
; CHECK-SAME: ![[DIVAR]],
|
|
; CHECK-NEXT: #dbg_value(!DIArgList(ptr %[[GEPVAR]],
|
|
; CHECK-SAME: ptr %[[GEPVAR]]), ![[DIVAR]],
|
|
call void @llvm.dbg.value(metadata ptr %arith, metadata !12, metadata !DIExpression()), !dbg !14
|
|
%loaded = load i8, ptr %arith
|
|
call void @llvm.dbg.value(metadata ptr %arith, metadata !12, metadata !DIExpression()), !dbg !14
|
|
call void @llvm.dbg.value(metadata !DIArgList(ptr %arith, ptr %arith), metadata !12, metadata !DIExpression()), !dbg !14
|
|
ret i8 %loaded
|
|
|
|
ret:
|
|
ret i8 0
|
|
}
|
|
|
|
; CHECK: ![[DIVAR]] = !DILocalVariable(name: "p",
|
|
|
|
declare void @llvm.dbg.value(metadata, metadata, metadata)
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!3, !4, !5}
|
|
!llvm.ident = !{!6}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, nameTableKind: None)
|
|
!1 = !DIFile(filename: "test.cpp", directory: ".")
|
|
!2 = !{}
|
|
!3 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!4 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!5 = !{i32 1, !"wchar_size", i32 4}
|
|
!6 = !{!"clang version 8.0.0 (trunk 348209)"}
|
|
!7 = distinct !DISubprogram(name: "foo", linkageName: "foo", scope: !1, file: !1, line: 4, type: !8, scopeLine: 5, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !11)
|
|
!8 = !DISubroutineType(types: !9)
|
|
!9 = !{null, !10}
|
|
!10 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
|
|
!11 = !{!12}
|
|
!12 = !DILocalVariable(name: "p", arg: 1, scope: !7, file: !1, line: 4, type: !10)
|
|
!14 = !DILocation(line: 4, column: 15, scope: !7)
|
|
!20 = distinct !DILexicalBlock(scope: !7, file: !1, line: 8, column: 7)
|