Evgeniy Brevnov a1b78fb929 [JT][CT] Preserve exisiting BPI/BFI during JumpThreading
Currently, JT creates and updates local instances of BPI\BFI. As a result global ones have to be invalidated if JT made any changes.
In fact, JT doesn't use any information from BPI/BFI for the sake of the transformation itself. It only creates BPI/BFI to keep them up to date. But since it updates local copies (besides cases when it updates profile metadata) it just waste of time.

Current patch is a rework of D124439. D124439 makes one step and replaces local copies with global ones retrieved through AnalysisPassManager. Here we do one more step and don't create BPI/BFI if the only reason of creation is to keep BPI/BFI up to date. Overall logic is the following. If there is cached BPI/BFI then update it along the transformations. If there is no existing BPI/BFI, then create it only if it is required to update profile metadata.

Please note if BPI/BFI exists on exit from JT (either cached or created) it is always up to date and no reason to invalidate it.

Reviewed By: mkazantsev

Differential Revision: https://reviews.llvm.org/D136827
2023-02-16 16:08:34 +07:00

99 lines
2.1 KiB
LLVM

; RUN: opt -passes=jump-threading -S < %s | FileCheck %s
define void @test() {
; CHECK-LABEL: @test()
bb:
%tmp = call i32 @a()
%tmp1 = icmp eq i32 %tmp, 1
br i1 %tmp1, label %bb5, label %bb2
; CHECK: br i1 %tmp1,{{.*}} !prof ![[PROF1:[0-9]+]]
bb2: ; preds = %bb
%tmp3 = call i32 @b()
%tmp4 = icmp ne i32 %tmp3, 1
br label %bb5
; CHECK: br i1 %tmp4, {{.*}} !prof ![[PROF2:[0-9]+]]
bb5: ; preds = %bb2, %bb
%tmp6 = phi i1 [ false, %bb ], [ %tmp4, %bb2 ]
br i1 %tmp6, label %bb8, label %bb7, !prof !0
bb7: ; preds = %bb5
call void @bar()
br label %bb8
bb8: ; preds = %bb7, %bb5
ret void
}
define void @test_single_pred1() {
; CHECK-LABEL: @test_single_pred1()
bb:
%tmp = call i32 @a()
%tmp1 = icmp eq i32 %tmp, 1
br i1 %tmp1, label %bb5_1, label %bb2
; CHECK: br i1 %tmp1,{{.*}} !prof ![[PROF1:[0-9]+]]
bb5_1:
br label %bb5;
bb2:
%tmp3 = call i32 @b()
%tmp4 = icmp ne i32 %tmp3, 1
br label %bb5
; CHECK: br i1 %tmp4, {{.*}} !prof ![[PROF2:[0-9]+]]
bb5:
%tmp6 = phi i1 [ false, %bb5_1 ], [ %tmp4, %bb2 ]
br i1 %tmp6, label %bb8, label %bb7, !prof !0
bb7:
call void @bar()
br label %bb8
bb8:
ret void
}
define void @test_single_pred2() {
; CHECK-LABEL: @test_single_pred2()
bb:
%tmp = call i32 @a()
%tmp1 = icmp eq i32 %tmp, 1
br i1 %tmp1, label %bb5_1, label %bb2
; CHECK: br i1 %tmp1,{{.*}} !prof ![[PROF1:[0-9]+]]
bb5_1:
br label %bb5_2;
bb5_2:
br label %bb5;
bb2:
%tmp3 = call i32 @b()
%tmp4 = icmp ne i32 %tmp3, 1
br label %bb5
; CHECK: br i1 %tmp4, {{.*}} !prof ![[PROF2:[0-9]+]]
bb5:
%tmp6 = phi i1 [ false, %bb5_2 ], [ %tmp4, %bb2 ]
br i1 %tmp6, label %bb8, label %bb7, !prof !0
bb7:
call void @bar()
br label %bb8
bb8:
ret void
}
declare void @bar()
declare i32 @a()
declare i32 @b()
!0 = !{!"branch_weights", i32 2146410443, i32 1073205}
;CHECK: ![[PROF1]] = !{!"branch_weights", i32 1073205, i32 2146410443}
;CHECK: ![[PROF2]] = !{!"branch_weights", i32 -2147483648, i32 0}