The option added in #174522 breaks simulator tests, since `set_default` overrides `False` values with the default. Since these options are either string or boolean, this patches set_default to override only un-set or empty string values (empty string is not truth-y and therefore would be overwritten by defaults currently, so this is NFCI)
This commit is contained in:
parent
ccca3b8c67
commit
0aea22f13e
@ -2,7 +2,7 @@
|
||||
|
||||
# Set attribute value if it is unset.
|
||||
def set_default(attr, value):
|
||||
if not getattr(config, attr, None):
|
||||
if getattr(config, attr, "") == "":
|
||||
setattr(config, attr, value)
|
||||
|
||||
# Generic config options for all compiler-rt lit tests.
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user