Add a breadcrumb comment to make debugging a user error when using ./utils/update_analyze_test_checks.py easier.

We won't talk about how long it took me to figure this out.  The difference in batch vs interactive on the "did you mean to print bitcode" message made this confusing.
This commit is contained in:
Philip Reames 2021-11-18 09:05:28 -08:00
parent 1e954a1c66
commit 180625fcb4

View File

@ -182,6 +182,9 @@ def invoke_tool(exe, cmd_args, ir, preprocess_cmd=None, verbose=False):
stdout = subprocess.check_output(exe + ' ' + applySubstitutions(cmd_args, substitutions),
shell=True, stdin=ir_file)
if sys.version_info[0] > 2:
# FYI, if you crashed here with a decode error, your run line probably
# results in bitcode or other binary format being written to the pipe.
# For an opt test, you probably want to add -S or -disable-output.
stdout = stdout.decode()
# Fix line endings to unix CR style.
return stdout.replace('\r\n', '\n')