shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Offload] Fix OL_DEVICE_INFO_MAX_MEM_ALLOC_SIZE on AMD (#154521)

Browse Source 
This wasn't handled with the normal info API, so needs special handling.
This commit is contained in:
Ross Brunton 2025-08-21 09:37:58 +01:00 committed by GitHub
parent a9692391f6
commit 273ca1f77b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
offload/liboffload/src/OffloadImpl.cpp
View File

@ -340,8 +340,15 @@ Error olGetDeviceInfoImplDetail(ol_device_handle_t Device,
// None of the existing plugins specify a limit on a single allocation,
// so return the global memory size instead
case OL_DEVICE_INFO_MAX_MEM_ALLOC_SIZE:
PropName = OL_DEVICE_INFO_GLOBAL_MEM_SIZE;
break;
[[fallthrough]];
// AMD doesn't provide the global memory size (trivially) with the device info
// struct, so use the plugin interface
case OL_DEVICE_INFO_GLOBAL_MEM_SIZE: {
uint64_t Mem;
if (auto Err = Device->Device->getDeviceMemorySize(Mem))
return Err;
return Info.write<uint64_t>(Mem);
} break;
default:
break;
@ -369,14 +376,6 @@ Error olGetDeviceInfoImplDetail(ol_device_handle_t Device,
return Info.writeString(std::get<std::string>(Entry->Value).c_str());
}
case OL_DEVICE_INFO_GLOBAL_MEM_SIZE: {
// Uint64 values
if (!std::holds_alternative<uint64_t>(Entry->Value))
return makeError(ErrorCode::BACKEND_FAILURE,
"plugin returned incorrect type");
return Info.write(std::get<uint64_t>(Entry->Value));
}
case OL_DEVICE_INFO_MAX_WORK_GROUP_SIZE:
case OL_DEVICE_INFO_VENDOR_ID:
case OL_DEVICE_INFO_NUM_COMPUTE_UNITS: