shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

[SLP]Fix comparison in bitwidth check.

Browse Source 
Projected bitwidth should be less than the original, not greater.
This commit is contained in:
Alexey Bataev 2024-03-21 04:13:23 -07:00
parent 3ac243bc0d
commit 34f0a8aaba
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
View File

@ -13995,7 +13995,7 @@ bool BoUpSLP::collectValuesToDemote(
if (MultiNodeScalars.contains(V))
return false;
uint32_t OrigBitWidth = DL->getTypeSizeInBits(V->getType());
if (OrigBitWidth < BitWidth) {
if (OrigBitWidth > BitWidth) {
APInt Mask = APInt::getBitsSetFrom(OrigBitWidth, BitWidth);
if (MaskedValueIsZero(V, Mask, SimplifyQuery(*DL)))
return true;

22
llvm/test/Transforms/SLPVectorizer/orig-btiwidth-les-projected.ll Normal file
View File

@ -0,0 +1,22 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
; RUN: opt -S --passes=slp-vectorizer < %s | FileCheck %s
define i32 @test(i4 %0) {
; CHECK-LABEL: define i32 @test(
; CHECK-SAME: i4 [[TMP0:%.*]]) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP1:%.*]] = trunc i8 0 to i4
; CHECK-NEXT: [[TMP2:%.*]] = trunc i8 0 to i4
; CHECK-NEXT: [[ADD_R:%.*]] = or i4 [[TMP1]], [[TMP0]]
; CHECK-NEXT: [[ADD_R14:%.*]] = or i4 0, [[TMP2]]
; CHECK-NEXT: [[CMP_NOT:%.*]] = icmp eq i4 [[ADD_R]], [[ADD_R14]]
; CHECK-NEXT: ret i32 0
;
entry:
%1 = trunc i8 0 to i4
%2 = trunc i8 0 to i4
%add.r = or i4 %1, %0
%add.r14 = or i4 0, %2
%cmp.not = icmp eq i4 %add.r, %add.r14
ret i32 0
}