shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Fix buildbot failure by explicitly disabling partial reductions in TTI. (#190165)

Browse Source 
Partial reductions were previously disabled by default, but by
implementing a generic cost-model in BasicTTIImpl (#189905) this now
accidentally enables the use of those when vectorising loops for targets
that may not support this yet.
This commit is contained in:
Sander de Smalen 2026-04-03 16:33:39 +01:00 committed by GitHub
parent 1484e0f16a
commit 62bbe3fffc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
10 changed files with 92 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/Target/AMDGPU/R600TargetTransformInfo.h
View File

@ -66,6 +66,15 @@ public:
unsigned Index, const Value *Op0, const Value *Op1,
TTI::VectorInstrContext VIC =
TTI::VectorInstrContext::None) const override;
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
};
} // end namespace llvm

9
llvm/lib/Target/DirectX/DirectXTargetTransformInfo.h
View File

@ -39,6 +39,15 @@ public:
unsigned ScalarOpdIdx) const override;
bool isTargetIntrinsicWithOverloadTypeAtArg(Intrinsic::ID ID,
int OpdIdx) const override;
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
};
} // namespace llvm

9
llvm/lib/Target/Hexagon/HexagonTargetTransformInfo.h
View File

@ -169,6 +169,15 @@ public:
bool forceScalarizeMaskedScatter(VectorType *VTy,
Align Alignment) const override;
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
/// @}
InstructionCost

9
llvm/lib/Target/LoongArch/LoongArchTargetTransformInfo.h
View File

@ -57,6 +57,15 @@ public:
TTI::MemCmpExpansionOptions
enableMemCmpExpansion(bool OptSize, bool IsZeroCmp) const override;
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
};
} // end namespace llvm

9
llvm/lib/Target/Mips/MipsTargetTransformInfo.h
View File

@ -36,6 +36,15 @@ public:
bool isLSRCostLess(const TargetTransformInfo::LSRCost &C1,
const TargetTransformInfo::LSRCost &C2) const override;
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
};
} // end namespace llvm

9
llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.h
View File

@ -222,6 +222,15 @@ public:
return false;
}
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
ValueUniformity getValueUniformity(const Value *V) const override;
};

9
llvm/lib/Target/PowerPC/PPCTargetTransformInfo.h
View File

@ -169,6 +169,15 @@ public:
getMemIntrinsicInstrCost(const MemIntrinsicCostAttributes &MICA,
TTI::TargetCostKind CostKind) const override;
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
private:
// The following constant is used for estimating costs on power9.
static const InstructionCost::CostType P9PipelineFlushEstimate = 80;

9
llvm/lib/Target/SPIRV/SPIRVTargetTransformInfo.h
View File

@ -64,6 +64,15 @@ public:
bool isLegalMaskedGather(Type *DataType, Align Alignment) const override;
bool isLegalMaskedScatter(Type *DataType, Align Alignment) const override;
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
};
} // namespace llvm

9
llvm/lib/Target/Sparc/SparcTargetTransformInfo.h
View File

@ -51,6 +51,15 @@ public:
Type *Ty = nullptr) const override;
TypeSize
getRegisterBitWidth(TargetTransformInfo::RegisterKind K) const override;
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF, TTI::PartialReductionExtendKind OpAExtend,
TTI::PartialReductionExtendKind OpBExtend, std::optional<unsigned> BinOp,
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
/// @}
};

11
llvm/lib/Target/VE/VETargetTransformInfo.h
View File

@ -157,6 +157,17 @@ public:
return true;
return !isSupportedReduction(II->getIntrinsicID());
}
InstructionCost getPartialReductionCost(
unsigned Opcode, Type *InputTypeA, Type *InputTypeB, Type *AccumType,
ElementCount VF,
TargetTransformInfo::PartialReductionExtendKind OpAExtend,
TargetTransformInfo::PartialReductionExtendKind OpBExtend,
std::optional<unsigned> BinOp,
TargetTransformInfo::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override {
return InstructionCost::getInvalid();
}
};
} // namespace llvm